iwx(4): Whitespace fix

2021-07-19 Thread Ashton Fagg
Found this while poking around - an extra newline in if_iwx.c. Index: sys/dev/pci/if_iwx.c === RCS file: /cvs/src/sys/dev/pci/if_iwx.c,v retrieving revision 1.69 diff -u -p -u -p -r1.69 if_iwx.c --- sys/dev/pci/if_iwx.c 18 Jul 2021 13

ix(4)/riscv64: Make ix(4) work when MSI-X interrupts aren't available

2021-07-19 Thread Ashton Fagg
I have an Intel 82599 10 gigabit ethernet card I wanted to get working on my SiFive Unmatched board. I found the ix(4) driver has some weirdness around MSI-X interrupts. While the driver supports operating both with and without MSI-X support, it's hard-coded via a flag rather than dynamically chec

pipex(4): use per-CPU counters for session statistics

2021-07-19 Thread Vitaliy Makkoveev
With bluhm@'s "forwarding in parallel" diff pipex(4) session could be accessed in parallel through (*ifp->if_input) -> ether_input(). Except statistics and MPPE data PPPOE sessions are mostly immutable. We have only place where we should reset 'idle_time' in input path with shared netlock. But sin

Re: forwarding in parallel

2021-07-19 Thread Vitaliy Makkoveev
On Mon, Jul 19, 2021 at 10:56:32PM +0200, Alexander Bluhm wrote: > On Mon, Jul 19, 2021 at 08:02:30PM +0300, Vitaliy Makkoveev wrote: > > I mean the case when ip_local() called by ip_ours(). Unfortunately, I'm > > not familiar with PPTP but it looks affected because it don't use tcp or > > udp as t

Re: forwarding in parallel

2021-07-19 Thread Alexander Bluhm
On Mon, Jul 19, 2021 at 08:02:30PM +0300, Vitaliy Makkoveev wrote: > I mean the case when ip_local() called by ip_ours(). Unfortunately, I'm > not familiar with PPTP but it looks affected because it don't use tcp or > udp as transport but encapsulates them into ip frames. Sorry for noise > if I'm w

Re: forwarding in parallel

2021-07-19 Thread Vitaliy Makkoveev
On Mon, Jul 19, 2021 at 06:40:07PM +0200, Alexander Bluhm wrote: > On Fri, Jul 09, 2021 at 10:47:49PM +0300, Vitaliy Makkoveev wrote: > > If I understood your diff right, pipex(4) is also affected through: > > > > ip_local() > >-> ip_deliver() > > -> (*pr_input)() > >-> gre_input()

Re: forwarding in parallel ipsec workaround

2021-07-19 Thread Hrvoje Popovski
On 19.7.2021. 17:53, Alexander Bluhm wrote: > Hi, > > I found why the IPsec workaround did not work. > > At init time we set ifiq->ifiq_softnet = net_tq(ifp->if_index + > idx), but the workaround modifies net_tq() at runtime. Modifying > net_tq() at runtime is bad anyway as task_add() and task_d

Re: Mark ICMP code optional in pf.conf.5

2021-07-19 Thread Klemens Nanni
On Mon, Jul 19, 2021 at 03:15:37PM +0200, Martin Vahlensieck wrote: > The code part for icmp{,6}-type is optional. Below is a diff marking > it as such. Should the text be changed as well? The text reads fine as is, no need to repeat that they're optional when the brackets make it clear already.

Re: forwarding in parallel

2021-07-19 Thread Alexander Bluhm
On Fri, Jul 09, 2021 at 10:47:49PM +0300, Vitaliy Makkoveev wrote: > If I understood your diff right, pipex(4) is also affected through: > > ip_local() >-> ip_deliver() > -> (*pr_input)() >-> gre_input() > -> gre_input_key() >-> gre_input_1() > ->

Re: forwarding in parallel ipsec workaround

2021-07-19 Thread Vitaliy Makkoveev
On Mon, Jul 19, 2021 at 05:53:40PM +0200, Alexander Bluhm wrote: > Hi, > > I found why the IPsec workaround did not work. > > At init time we set ifiq->ifiq_softnet = net_tq(ifp->if_index + > idx), but the workaround modifies net_tq() at runtime. Modifying > net_tq() at runtime is bad anyway as

forwarding in parallel ipsec workaround

2021-07-19 Thread Alexander Bluhm
Hi, I found why the IPsec workaround did not work. At init time we set ifiq->ifiq_softnet = net_tq(ifp->if_index + idx), but the workaround modifies net_tq() at runtime. Modifying net_tq() at runtime is bad anyway as task_add() and task_del() could be called with different task queues. So bette

bgpd support for RFC9072

2021-07-19 Thread Claudio Jeker
This adds support for RFC9072: Extended Optional Parameters Length for BGP OPEN Message. I did not add any knobs to force the new format. Seems to work for me (tested both formats with bgpd). The other ususal suspects have no support yet so lets see. -- :wq Claudio Index: bgpd.8

Mark ICMP code optional in pf.conf.5

2021-07-19 Thread Martin Vahlensieck
Hi The code part for icmp{,6}-type is optional. Below is a diff marking it as such. Should the text be changed as well? Or am I missing a reason why it is not marked optional? Best, Martin Index: pf.conf.5 === RCS file: /cvs/src