Re: iwm(4): use new firmware images with fragattack fixes

2021-05-25 Thread Kevin Lo
On Tue, May 25, 2021 at 03:48:16PM +0200, Stefan Sperling wrote: > > This patch allows iwm(4) to use new firmware images which are part > of the iwm-20210512 firmware package, available via fw_update (you > need to run fw_update *before* booting with this patch). > > The new firmware images were

Re: smtpd: unused code

2021-05-25 Thread Todd C . Miller
On Tue, 25 May 2021 22:50:32 +0200, Eric Faurot wrote: > This diff removes more unused code. OK millert@ - todd

smtpd: unused code

2021-05-25 Thread Eric Faurot
This diff removes more unused code. Eric. Index: config.c === RCS file: /cvs/src/usr.sbin/smtpd/config.c,v retrieving revision 1.55 diff -u -p -r1.55 config.c --- config.c9 Apr 2021 16:43:43 - 1.55 +++ config.c25 M

Re: vga(4): fix vga_doswitch() declaration

2021-05-25 Thread Mark Kettenis
> Date: Tue, 25 May 2021 13:53:57 -0500 > From: Scott Cheloha > > Timeout callback functions should be void (*)(void *). I'd rather not > cast in order to shove the function pointer into timeout_set(9). > > ok? sure, ok kettenis@ > Index: vga.c > ==

vga(4): fix vga_doswitch() declaration

2021-05-25 Thread Scott Cheloha
Timeout callback functions should be void (*)(void *). I'd rather not cast in order to shove the function pointer into timeout_set(9). ok? Index: vga.c === RCS file: /cvs/src/sys/dev/ic/vga.c,v retrieving revision 1.73 diff -u -p -r

Re: panic(9): set panicstr atomically

2021-05-25 Thread Theo de Raadt
gwes wrote: > On 5/25/21 10:26 AM, Theo de Raadt wrote: > > Alexander Bluhm wrote: > > > >> On Tue, May 25, 2021 at 04:15:26PM +0200, Mark Kettenis wrote: > >>> Wouldn't be too hard. But unless you're on a serial console, that > >>> will probably be more than a screenful of information, so not

Re: panic(9): set panicstr atomically

2021-05-25 Thread gwes
On 5/25/21 10:26 AM, Theo de Raadt wrote: Alexander Bluhm wrote: On Tue, May 25, 2021 at 04:15:26PM +0200, Mark Kettenis wrote: Wouldn't be too hard. But unless you're on a serial console, that will probably be more than a screenful of information, so not terribly useful. The most important

Re: iwm(4): use new firmware images with fragattack fixes

2021-05-25 Thread Florian Obser
So far this is working on my X1 gen2: iwm0 at pci2 dev 0 function 0 "Intel AC 7260" rev 0x83, msi iwm0: hw rev 0x140, fw ver 17.3216344376.0 -- I'm not entirely sure you are real.

Re: iwm(4): use new firmware images with fragattack fixes

2021-05-25 Thread Björn Ketelaars
On Tue 25/05/2021 15:48, Stefan Sperling wrote: > This patch allows iwm(4) to use new firmware images which are part > of the iwm-20210512 firmware package, available via fw_update (you > need to run fw_update *before* booting with this patch). > > The new firmware images were published right afte

Re: panic(9): set panicstr atomically

2021-05-25 Thread Theo de Raadt
Alexander Bluhm wrote: > On Tue, May 25, 2021 at 04:15:26PM +0200, Mark Kettenis wrote: > > Wouldn't be too hard. But unless you're on a serial console, that > > will probably be more than a screenful of information, so not terribly > > useful. > > The most important things must fit on the firs

Re: panic(9): set panicstr atomically

2021-05-25 Thread Alexander Bluhm
On Tue, May 25, 2021 at 04:15:26PM +0200, Mark Kettenis wrote: > Wouldn't be too hard. But unless you're on a serial console, that > will probably be more than a screenful of information, so not terribly > useful. The most important things must fit on the first VGA screen. Then user can make a p

Re: panic(9): set panicstr atomically

2021-05-25 Thread Mark Kettenis
> From: Scott Cheloha > Date: Tue, 25 May 2021 08:42:05 -0500 > > > On May 25, 2021, at 08:20, Theo de Raadt wrote: > > > > Scott Cheloha wrote: > > > >>> On Mon, May 24, 2021 at 10:12:53PM -0500, Scott Cheloha wrote: > >>> On Sat, May 22, 2021 at 01:35:53AM +0200, Alexander Bluhm wrote: > >

Re: panic(9): set panicstr atomically

2021-05-25 Thread Theo de Raadt
Scott Cheloha wrote: > > If the 2nd cpu to enter panic actually has a more relevant panic, now > > it will be missed. > > I said we could keep the printing. I even > kept the printing in my latest patch. So I > don't know what you're arguing against > here. You start spinning cpus inside panic

iwm(4): use new firmware images with fragattack fixes

2021-05-25 Thread Stefan Sperling
This patch allows iwm(4) to use new firmware images which are part of the iwm-20210512 firmware package, available via fw_update (you need to run fw_update *before* booting with this patch). The new firmware images were published right after the fragattacks embargo period ended. An advisory was pu

Re: panic(9): set panicstr atomically

2021-05-25 Thread Scott Cheloha
> On May 25, 2021, at 08:20, Theo de Raadt wrote: > > Scott Cheloha wrote: > >>> On Mon, May 24, 2021 at 10:12:53PM -0500, Scott Cheloha wrote: >>> On Sat, May 22, 2021 at 01:35:53AM +0200, Alexander Bluhm wrote: On Fri, May 21, 2021 at 02:00:54PM -0500, Scott Cheloha wrote: > Given a

Re: ld.so: program headers: do not rely on DYNAMIC coming before GNU_RELRO

2021-05-25 Thread Klemens Nanni
On Tue, May 25, 2021 at 12:00:21AM -0900, Philip Guenther wrote: > On Mon, May 24, 2021 at 4:59 AM Klemens Nanni wrote: > > > When tinkering with ld.so crashes due to file corruption the other day > > I tested a few changes but did not want to replace /usr/libexec/ld.so > > and since recompiling

Re: panic(9): set panicstr atomically

2021-05-25 Thread Theo de Raadt
Scott Cheloha wrote: > On Mon, May 24, 2021 at 10:12:53PM -0500, Scott Cheloha wrote: > > On Sat, May 22, 2021 at 01:35:53AM +0200, Alexander Bluhm wrote: > > > On Fri, May 21, 2021 at 02:00:54PM -0500, Scott Cheloha wrote: > > > > Given all of this, would it be better if secondary CPUs spin in >

Re: bgpd extend capability support (add-path, enhanced rr)

2021-05-25 Thread Claudio Jeker
On Tue, May 18, 2021 at 05:35:01PM +0200, Claudio Jeker wrote: > bgpd(8) will soon support ADD-PATH (RFC7911) and enhanced route refresh > (RFC7313). This is the frist step toward this. > It add the capability parsers, extends the capability struct and adds the > capability negotiation bits. The ro

Re: bgpd upgrade to RFC6793

2021-05-25 Thread Claudio Jeker
On Tue, May 18, 2021 at 12:48:06PM +0200, Claudio Jeker wrote: > Our four-byte AS support dates back to the days of the original draft. > Since then a new RFC 6793 got released that adjusted the error handling a > bit. RFC 6793 just treats any error on AS4_PATH attribute with attribute > drop with

Re: ld.so: program headers: do not rely on DYNAMIC coming before GNU_RELRO

2021-05-25 Thread Philip Guenther
On Mon, May 24, 2021 at 4:59 AM Klemens Nanni wrote: > When tinkering with ld.so crashes due to file corruption the other day > I tested a few changes but did not want to replace /usr/libexec/ld.so > and since recompiling executable to change their interpreter is not > always an option, I went fo

Re: Add f_modify and f_process callbacks to socket filterops

2021-05-25 Thread Martin Pieuchot
On 20/05/21(Thu) 14:16, Visa Hankala wrote: > On Thu, May 20, 2021 at 11:35:32AM +0200, Martin Pieuchot wrote: > > On 18/05/21(Tue) 14:22, Visa Hankala wrote: > > > This diff adds f_modify and f_process callbacks to socket event filters. > > > As a result, socket events are handled using the non-le