Re: patch: make ld.so aware of pthread_key_create destructor - Re: multimedia/mpv debug vo=gpu crash on exit

2021-05-07 Thread Sebastien Marie
On Thu, May 06, 2021 at 06:23:08PM -0700, Anindya Mukherjee wrote: > On Thu, May 06, 2021 at 08:00:56AM -0600, Todd C. Miller wrote: > > On Thu, 06 May 2021 09:32:28 +0200, Sebastien Marie wrote: > > > > > We already take care of such situation with __cxa_thread_atexit_impl > > > (in libc/stdlib/t

Re: patch: make ld.so aware of pthread_key_create destructor - Re: multimedia/mpv debug vo=gpu crash on exit

2021-05-07 Thread Sebastien Marie
On Fri, May 07, 2021 at 04:41:50PM -0700, Anindya Mukherjee wrote: > On Thu, May 06, 2021 at 08:00:56AM -0600, Todd C. Miller wrote: > > On Thu, 06 May 2021 09:32:28 +0200, Sebastien Marie wrote: > > > > > We already take care of such situation with __cxa_thread_atexit_impl > > > (in libc/stdlib/t

Re: patch: make ld.so aware of pthread_key_create destructor - Re: multimedia/mpv debug vo=gpu crash on exit

2021-05-07 Thread Anindya Mukherjee
On Thu, May 06, 2021 at 08:00:56AM -0600, Todd C. Miller wrote: > On Thu, 06 May 2021 09:32:28 +0200, Sebastien Marie wrote: > > > We already take care of such situation with __cxa_thread_atexit_impl > > (in libc/stdlib/thread_atexit.c), by keeping an additionnal reference > > on object loaded (it

Re: more rsync cleanup

2021-05-07 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.05.06 17:59:32 +0200: > As noticed by benno@ the blk.blks buffer is leaked in some cases. > Fix those and cleanup up the pre_* functions a bit more. > I increased the diff context a bit to make the diff easier to read. reads ok > > -- > :wq Claudi

Re: softraid(4) crypto/raid1c refactoring

2021-05-07 Thread Stefan Sperling
The few test reports I've received for this are looking fine. Would any developer dare to OK this? On Tue, Apr 27, 2021 at 03:46:56PM +0200, Stefan Sperling wrote: > Refactor softraid crypto code to allow use of a discipline-specific data > structure for RAID1C volumes, as requested by jsing@ duri

Re: services(5): add default ftps ports

2021-05-07 Thread Jan Klemkow
On Thu, May 06, 2021 at 11:09:03AM -0600, Theo de Raadt wrote: > Jan Klemkow wrote: > > > > > > I'm working on a diff to bring ftps with libtls into our ftpd(8). > > > > > There > > > > > is a "getaddrinfo(NULL, "ftps", &hints, &res0)" call, which uses this > > > > > port. Thus, I made this ch

Re: citrus_none: don't allow codepoints > 0x7f

2021-05-07 Thread Todd C . Miller
On Fri, 07 May 2021 16:47:19 +0200, Martijn van Duren wrote: > ping Restricting things to 7-bit ASCII in the C/POSIX locale seems like the correct thing to do. OK millert@ - todd

rsync fix file handling in uploader

2021-05-07 Thread Claudio Jeker
So yesterday I committed a change to simplify file handling. This removed the O_NONBLOCK flag from openat() but today I realized that this was a bit premature. The code at that point does not know if the file is actually a regular file and so if you put a fifo in place of a regular file it will han

Re: citrus_none: don't allow codepoints > 0x7f

2021-05-07 Thread Martijn van Duren
ping On Sun, 2021-04-18 at 16:44 +0200, Martijn van Duren wrote: > Hello tech@, > > Currently we accept codepoints 0-0xff in citrus_none, but the C/POSIX > locale use 7 bit ascii, allowing us currently to return unspecified > values. From code-inspection, NetBSD does the same thing we do (since >

Re: printf(1): support \u and \U

2021-05-07 Thread Todd C . Miller
On Fri, 07 May 2021 16:39:34 +0200, Martijn van Duren wrote: > Any takers? > > Updated diff after previous commit below. OK millert@ - todd

Re: printf(1): support \u and \U

2021-05-07 Thread Martijn van Duren
Any takers? Updated diff after previous commit below. martijn@ On Sun, 2021-04-18 at 23:54 +0200, Martijn van Duren wrote: > On Sun, 2021-04-18 at 22:53 +0200, Martijn van Duren wrote: > > On Sun, 2021-04-18 at 17:52 +0200, Martijn van Duren wrote: > > > I'm always frustrated when a unicode char

snmpd rename context to pdutype

2021-05-07 Thread Martijn van Duren
When moving the traphandler to the snmpe process I overlooked the fact that "type" is being saved inside the switch statement under the sm_context name. RFC3411 talks about pduType, and the name context means something completely different in the v3 world. The diff below moves our naming closer to

Re: Time to commit FUSE changes

2021-05-07 Thread Stuart Henderson
On 2021/05/07 17:14, Helg wrote: > Hi tech@ > > Now that 6.9 has been released I'd like to commit my changes to replace > libfuse from base with the reference implementation from ports. > > Can I please have an OK? I'll commit the ports changes at the same time > (separate email already sent to p

rsync exit code and error cleanup

2021-05-07 Thread Claudio Jeker
Currently our rsync does not follow the exit codes from rsync. Also the error handling is complex because ERR() and ERRX() are not terminating the process. This diff tries to start cleaning up the mess a bit. Introduce some exit codes to use and apply them in places where it is obvious. The rsync

Re: macppc: add ld.script for kernel, ofwboot

2021-05-07 Thread Mark Kettenis
> Date: Fri, 7 May 2021 00:04:57 -0400 > From: George Koehler > > Hello tech list, > > I want macppc to switch from ld.bfd to ld.lld, but there is a problem > when lld links ofwboot or the kernel. I propose to fix it by adding > ld.script for both. These scripts also work with ld.bfd, so I wan