Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-24 Thread Alexandr Nedvedicky
Hello, > We really need to fix ip_send() such the output task will handle IP options > properly. took a look at bug reported by Dominik earlier today. Looks like there are two issues: 1) ip_insertoptions() does not update length of IP header (ip_hl) 2) ip_hl is being o

httpd: Allow overriding global "no index"

2021-03-24 Thread Quentin Rameau
Hello, It's been noted that the "directory no index" configuration always shadow any other directory index configuration, for example: directory no index location "/foo/" { directory auto index } Even when requesting /foo/, the global no index option overrides the location-specific auto

Re: arm64: make cwfg(4) report battery information to apm(4)

2021-03-24 Thread Jeremie Courreges-Anglas
On Wed, Mar 24 2021, Klemens Nanni wrote: > On Wed, Mar 24, 2021 at 12:49:51AM +0100, Jeremie Courreges-Anglas wrote: > >> >> > @@ -202,6 +217,12 @@ cwfg_attach(struct device *parent, struc >> >> > >> >> > sensor_task_register(sc, cwfg_update_sensors, 5); >> >> > >> >> > +#if NAPM >

Re: Huawei ME906s-158 LTE, cdce(4) vs umb(4)

2021-03-24 Thread Stuart Henderson
On 2021/03/25 00:30, Patrick Wildt wrote: > Without having looked at anything, it might be worth looking at the most > recent mail in this thread: > > 'Re: [PATCH] umb(4) fix for X20 (DW5821e) in Dell Latitude 7300' > oh, usb runs through all drivers looking for a VID/PID match before then runni

Re: Huawei ME906s-158 LTE, cdce(4) vs umb(4)

2021-03-24 Thread Patrick Wildt
On Wed, Mar 24, 2021 at 11:23:11PM +, Stuart Henderson wrote: > In my ongoing search to find a umb(4) that will actually work that > isn't the one in my laptop (since my EM7305 has been a failure), > I picked up a Huawei ME906s-158 off ebay. It attaches to cdce and ugen > and fails to work: >

Huawei ME906s-158 LTE, cdce(4) vs umb(4)

2021-03-24 Thread Stuart Henderson
In my ongoing search to find a umb(4) that will actually work that isn't the one in my laptop (since my EM7305 has been a failure), I picked up a Huawei ME906s-158 off ebay. It attaches to cdce and ugen and fails to work: cdce0 at uhub2 port 4 configuration 2 interface 0 "Huawei Technologies Co.,

Re: libcrypto bio_cb.c: fix mangled debug output

2021-03-24 Thread Theo Buehler
On Wed, Mar 24, 2021 at 11:09:41AM +0100, Martin Vahlensieck wrote: > Hi > > This fixes mangled output from the openssl(1) -debug option: > > Before: > $ openssl aes-256-cbc -out test -debug > BIO[0x9102a7e5ctrl(106) - FILE pointer > BIO[0x9102a7e5ctrl return 1 > BIO[0x9102a801ctrl(108) - FILE po

vmd(8): fix packet handling for dhcpleased(8)

2021-03-24 Thread Dave Voutila
tech@, While migrating an existing -current vm to use dhcpleased(8), one of the issues discovered was the dhcp/bootp handling built into vmd(8) for local interfaces was improperly missing packets sent to the ethernet address of the host-side tap(4) device. (vmd(8) was only looking for broadcast pa

Re: athn(4): switch Tx rate control to RA

2021-03-24 Thread Lauri Tirkkonen
On Tue, Mar 23 2021 18:01:27 +0100, Stefan Sperling wrote: > This switches athn(4) to the new RA Tx rate adaptation module. > Tests on athn(4) PCI devices are welcome. > USB devices don't need to be tested in this case Tx rate adaptation > is taken care of by firmware. > > I could only test on AR9

Re: sdmmc(4) off-by-one on boundary check

2021-03-24 Thread Marcus Glocker
On Wed, Mar 24, 2021 at 02:05:27PM -0600, Theo de Raadt wrote: > Marcus Glocker wrote: > > > On Tue, Mar 23, 2021 at 09:52:42AM -0600, Theo de Raadt wrote: > > > > > Mark Kettenis wrote: > > > > > > > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > > > > > ==

Re: sdmmc(4) off-by-one on boundary check

2021-03-24 Thread Mark Kettenis
> Date: Wed, 24 Mar 2021 20:58:48 +0100 > From: Marcus Glocker > > On Tue, Mar 23, 2021 at 09:52:42AM -0600, Theo de Raadt wrote: > > > Mark Kettenis wrote: > > > > > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > > > > === > > > > > R

Re: sdmmc(4) off-by-one on boundary check

2021-03-24 Thread Theo de Raadt
Marcus Glocker wrote: > On Tue, Mar 23, 2021 at 09:52:42AM -0600, Theo de Raadt wrote: > > > Mark Kettenis wrote: > > > > > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > > > > === > > > > > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.

Re: sdmmc(4) off-by-one on boundary check

2021-03-24 Thread Marcus Glocker
On Tue, Mar 23, 2021 at 09:52:42AM -0600, Theo de Raadt wrote: > Mark Kettenis wrote: > > > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > > > === > > > > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.c,v > > > > retrieving revision 1.59 >

Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-24 Thread Alexandr Nedvedicky
Hello Dominik, thanks for reporting a bug. I'll take a look at it later today. your proposed fix re-introduces a recursion to PF, which we want to avoid, hence we let icmp_send() to dispatch outbound ICMP response to task. We really need to fix ip_send() such the output task will handle IP optio

efiboot/arm64: fix "mach dtb" return code to avoid bogus boot

2021-03-24 Thread Klemens Nanni
Bootloader command functions must return zero in case of failure, returning 1 tells the bootloader to boot the file. arm64's `machine dtb' command has it the wrong way so using it triggers a boot that doesn't make any sense: >> OpenBSD/arm64 BOOTAA64 1.4 boot> mach dtb boo

Re: wsconsctl.conf: mention mouse.tp.tapping in example

2021-03-24 Thread Raf Czlonka
On Wed, Mar 24, 2021 at 01:42:19PM GMT, Klemens Nanni wrote: > On Tue, Mar 23, 2021 at 12:41:25PM +, Raf Czlonka wrote: > > According to wsmouse(4), the orders is as follows: > > > > This list of three parameters configures these mappings, > > in the order: > > > >

Re: wsconsctl.conf: mention mouse.tp.tapping in example

2021-03-24 Thread Klemens Nanni
On Tue, Mar 23, 2021 at 12:41:25PM +, Raf Czlonka wrote: > According to wsmouse(4), the orders is as follows: > > This list of three parameters configures these mappings, > in the order: > >one-finger,two-finger,three-finger > > Setting a parameter to a

[ICMP] IP options lead to malformed reply

2021-03-24 Thread Schreilechner, Dominik
Hi, When sending an ICMP request with IP options to an OpenBSD Box, the ICMP payload of the reply is malformed. In the reply the length field of the IP header is 20, even though the reply contains the IP options. Meaning, in this packet the IP options are part of ICMP and not IP. This was tested w

Re: monotonic time going back by wrong skews

2021-03-24 Thread Josh Rickmar
On Wed, Mar 24, 2021 at 05:40:21PM +0900, YASUOKA Masahiko wrote: > Hi, > > I hit a problem which is caused by going back of monotonic time. It > happens on hosts on VMware ESXi. > > I wrote the program which repeats the problem. > > % cc -o monotime monotime.c -lpthread > % ./monotime > 194

Re: monotonic time going back by wrong skews

2021-03-24 Thread YASUOKA Masahiko
Hi, > Second, why is taking the minimum value the optimal choice? I would > assume an average would be better. Basically if you have a sequency > like 900, 900, 900, 900, 0, 900, 900, 900 you pick 0 which could lead > to some problems, right? Or am I missing something?" Skews on VMware >> -8445

libcrypto bio_cb.c: fix mangled debug output

2021-03-24 Thread Martin Vahlensieck
Hi This fixes mangled output from the openssl(1) -debug option: Before: $ openssl aes-256-cbc -out test -debug BIO[0x9102a7e5ctrl(106) - FILE pointer BIO[0x9102a7e5ctrl return 1 BIO[0x9102a801ctrl(108) - FILE pointer BIO[0x9102a801ctrl return 1 ... After: $ openssl aes-256-cbc -out test -debug B

Re: monotonic time going back by wrong skews

2021-03-24 Thread Paul Irofti
Hi, Thank you for taking this to tech@ as requested! I will reproduce here what I replied to Yasouka and Scott (which I think proposed taking the minimum skew value) in private. "First, thank you very much for the in-depth analysis. I would suggest you take this to a public forum like tech@

mfs + cd9660: vop #define cleanup

2021-03-24 Thread Sebastien Marie
Hi, The following diff removes some #define which hide generic vop functions behind another classic name. It makes clearer which vop functions are real fileystem-implementations and which one are only stubs. Only mfs and cd9660 are using such #define. No functional changes are intented. Commen

Re: namei/execve: entanglement's simplification

2021-03-24 Thread Sebastien Marie
Please withdraw for now. sys/exec.h change doesn't fit well in userland. Thanks. On Mon, Mar 22, 2021 at 11:05:06AM +0100, Sebastien Marie wrote: > Hi, > > The following diff tries to simplify a bit the entanglement of namei > data and execve(2) syscall. > > Currently, when called, sys_execve(

monotonic time going back by wrong skews

2021-03-24 Thread YASUOKA Masahiko
Hi, I hit a problem which is caused by going back of monotonic time. It happens on hosts on VMware ESXi. I wrote the program which repeats the problem. % cc -o monotime monotime.c -lpthread % ./monotime 194964 Starting 562210 Starting 483046 Starting 148865 Starting 148865 Back 991.80804