Re: pcidump(8): add missing PCI classes

2021-03-05 Thread Jan Klemkow
On Fri, Mar 05, 2021 at 09:22:28AM -0700, Theo de Raadt wrote: > Fix dump() to convert subclass == NULL into something else, or maybe the > fix should be in pci_subclass() itself. My initial mistake was to use zero in an empty list. This leads to one element in the list, which causes wrong list h

Re: pcidump(8): add missing PCI classes

2021-03-05 Thread Jan Klemkow
On Fri, Mar 05, 2021 at 04:13:53PM +0100, Mark Kettenis wrote: > > Date: Fri, 5 Mar 2021 12:05:38 +0100 > > From: Jan Klemkow > > Content-Type: text/plain; charset=us-ascii > > Content-Disposition: inline > > > > Hi, > > > > this diff adds the missing PCI classes Accelerator and Instrumentation.

slaacd(8): various code cleanup & withdraw nameservers when interface goes down

2021-03-05 Thread Florian Obser
Here are a bunch of diffs on top for Fernando's RFC 8981 work, but is independent of it, might apply without it, I haven't tried. I started to cleanup slaacd(8) by applying things I learned while implementing dhcpleased(8). I'm nowhere near done but it got to the point where it fixes two bugs: 1)

Re: slacd(8): Implement RFC 8981 (revised RFC 4941, IPv6 Temporary Address Extensions) (revised patch)

2021-03-05 Thread Florian Obser
Anyone? I'll probably put this in tomorrow. Diffs are piling up... On Thu, Mar 04, 2021 at 11:47:10AM +0100, Florian Obser wrote: > Works fine here, OK florian > > On Wed, Mar 03, 2021 at 08:50:59PM -0300, Fernando Gont wrote: > > This revised patch adresses a minor issue pointed out by Florian (

Re: Ignore /tmp/.Xauth* in daily

2021-03-05 Thread Vadim Zhukov
чт, 4 мар. 2021 г. в 02:02, Vadim Zhukov : > > Hello all. > > Since xenodm has DEF_USER_AUTH_DIR set to "/tmp", we need to ignore > /tmp/.Xauth* in daily cleanup, don't we? > > Found the hard way a few minutes ago on my X240. Thanks sthen@, I've realized this happens only when xenodm could not cre

Re: rpki-client validate URI function

2021-03-05 Thread Theo Buehler
On Fri, Mar 05, 2021 at 05:36:53PM +0100, Claudio Jeker wrote: [...] > Here we go. This should be better. ok tb

Re: rpki-client validate URI function

2021-03-05 Thread Claudio Jeker
On Fri, Mar 05, 2021 at 04:58:44PM +0100, Claudio Jeker wrote: > On Fri, Mar 05, 2021 at 04:08:55PM +0100, Theo Buehler wrote: > > On Fri, Mar 05, 2021 at 01:48:43PM +0100, Claudio Jeker wrote: > > > Instead of adding similar checks all over the place introduce a > > > valid_uri() function that che

Re: pcidump(8): add missing PCI classes

2021-03-05 Thread Theo de Raadt
Fix dump() to convert subclass == NULL into something else, or maybe the fix should be in pci_subclass() itself. Converting NULL to %s into "(null)" is non-standard and has led to sloppier code, there have been efforts improve the whole tree enough that we could one day simply crash on such circum

Re: rpki-client validate URI function

2021-03-05 Thread Claudio Jeker
On Fri, Mar 05, 2021 at 04:08:55PM +0100, Theo Buehler wrote: > On Fri, Mar 05, 2021 at 01:48:43PM +0100, Claudio Jeker wrote: > > Instead of adding similar checks all over the place introduce a > > valid_uri() function that checks if a URI is valid enough for rpki-client. > > rpki-client does not

Re: rpki-client validate filehash function

2021-03-05 Thread Theo Buehler
On Fri, Mar 05, 2021 at 03:15:48PM +0100, Claudio Jeker wrote: > RRDP also uses SHA256 hashes to validate files (before withdraws and > updates). Again move this from the implementation in mft.c to validate.c > this way it can be reused. > > OK? ok tb > -- > :wq Claudio > > Index: extern.h > =

Re: Fix assigning array variables in ksh

2021-03-05 Thread Vadim Zhukov
пт, 5 мар. 2021 г. в 18:14, Theo Buehler : > > On Sun, Feb 21, 2021 at 10:04:07PM +0300, Vadim Zhukov wrote: > > Hello all. > > > > This continues the 'Another potential ksh bug?' thread on misc@: > > https://marc.info/?l=openbsd-misc&m=160736700220621&w=2 > > This present is a bit too late for Chr

Re: Fix assigning array variables in ksh

2021-03-05 Thread Theo Buehler
On Sun, Feb 21, 2021 at 10:04:07PM +0300, Vadim Zhukov wrote: > Hello all. > > This continues the 'Another potential ksh bug?' thread on misc@: > https://marc.info/?l=openbsd-misc&m=160736700220621&w=2 > This present is a bit too late for Christmas, but at least the Day of > Red Army is coming soo

Re: pcidump(8): add missing PCI classes

2021-03-05 Thread Mark Kettenis
> Date: Fri, 5 Mar 2021 12:05:38 +0100 > From: Jan Klemkow > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > > Hi, > > this diff adds the missing PCI classes Accelerator and Instrumentation. > Thus, we can replace a few unknown in its output: > > - 0x0008: Class

Re: rpki-client validate URI function

2021-03-05 Thread Theo Buehler
On Fri, Mar 05, 2021 at 01:48:43PM +0100, Claudio Jeker wrote: > Instead of adding similar checks all over the place introduce a > valid_uri() function that checks if a URI is valid enough for rpki-client. > rpki-client does not accept files or directories starting with ., bails on > URI that have

pcidump(8): add missing PCI classes

2021-03-05 Thread Jan Klemkow
Hi, this diff adds the missing PCI classes Accelerator and Instrumentation. Thus, we can replace a few unknown in its output: - 0x0008: Class: 13 (unknown), Subclass: 00 (unknown), + 0x0008: Class: 13 Instrumentation, Subclass: 00 (null), Both Classes have vendor specific APIs. So,

uhidev: allow devices to match specific multiple reports

2021-03-05 Thread joshua stein
uhidev allows a child device to claim all reports by calling *_match functions with the report id set to UHIDEV_CLAIM_ALLREPORTID. umt needs this because it has to access 3 reports which has worked okay up until now because devices with umt and a ukbd have usually presented them on separate uhi

rpki-client validate filehash function

2021-03-05 Thread Claudio Jeker
RRDP also uses SHA256 hashes to validate files (before withdraws and updates). Again move this from the implementation in mft.c to validate.c this way it can be reused. OK? -- :wq Claudio Index: extern.h === RCS file: /cvs/src/usr.s

rpki-client validate URI function

2021-03-05 Thread Claudio Jeker
Instead of adding similar checks all over the place introduce a valid_uri() function that checks if a URI is valid enough for rpki-client. rpki-client does not accept files or directories starting with ., bails on URI that have strange characters and valid_uri() will also check that the protocol is

Re: pcidump(8): add missing PCI classes

2021-03-05 Thread David Gwynne
ok. > On 5 Mar 2021, at 9:05 pm, Jan Klemkow wrote: > > Hi, > > this diff adds the missing PCI classes Accelerator and Instrumentation. > Thus, we can replace a few unknown in its output: > > - 0x0008: Class: 13 (unknown), Subclass: 00 (unknown), > + 0x0008: Class: 13 Instrumentati

Re: use 64bit ethernet addresses in carp(4)

2021-03-05 Thread Hrvoje Popovski
On 5.3.2021. 6:11, David Gwynne wrote: > this passes the destination ethernet address from the network packet > as a uint64_t from ether_input into carp_input, so it can use it > to see if a carp interface should take the packet. > > it's been working on amd64 and sparc64. anyone else want to try?

Re: Kill SINGLE_PTRACE

2021-03-05 Thread Martin Pieuchot
On 04/03/21(Thu) 12:25, Claudio Jeker wrote: > On Thu, Mar 04, 2021 at 11:06:21AM +0100, Martin Pieuchot wrote: > > [...] > > The comment documents what sibling threads are supposed to do once the > > current one has called single_thread_set() with a given SINGLE_* option. > > > > Sibling threads

Re: Read `ps_single' once

2021-03-05 Thread Martin Pieuchot
On 04/03/21(Thu) 11:45, Mark Kettenis wrote: > > Date: Thu, 4 Mar 2021 11:19:23 +0100 > > From: Martin Pieuchot > > > > On 04/03/21(Thu) 11:01, Mark Kettenis wrote: > > > > Date: Thu, 4 Mar 2021 10:54:48 +0100 > > > > From: Patrick Wildt > > > > > > > > Am Thu, Mar 04, 2021 at 10:42:24AM +0100