Re: Use correct config descriptor in ugen_set_config

2021-02-04 Thread Marcus Glocker
On Thu, Feb 04, 2021 at 10:28:42PM +0100, Thomas Jeunet wrote: > On Wed, Feb 03, 2021 at 08:30:42PM +0100, Marcus Glocker wrote: > > On Sun, Jan 31, 2021 at 07:05:29PM +0100, Thomas Jeunet wrote: > > > > > Hello tech, > > > > > > in ugen_set_config, the cached config descriptor (ugen.c:213) is >

Re: have pf_route bail out if it resolves a route with RTF_LOCAL set

2021-02-04 Thread David Gwynne
On Fri, Jan 29, 2021 at 03:23:31PM +0100, Alexander Bluhm wrote: > On Fri, Jan 29, 2021 at 10:53:09AM +1000, David Gwynne wrote: > > > Are you sure that it does not break any use case? I have seen so > > > much strange stuff. What is the advantage? > > > > The current behaviour is lucky at best,

Re: Use correct config descriptor in ugen_set_config

2021-02-04 Thread Thomas Jeunet
On Wed, Feb 03, 2021 at 08:30:42PM +0100, Marcus Glocker wrote: > On Sun, Jan 31, 2021 at 07:05:29PM +0100, Thomas Jeunet wrote: > > > Hello tech, > > > > in ugen_set_config, the cached config descriptor (ugen.c:213) is > > obsolete after the call to usbd_set_config_no (ugen.c:220). Use a > > ref

Re: uhidpp(4): logitech hid++ device driver

2021-02-04 Thread Bryan Steele
On Tue, Feb 02, 2021 at 08:23:29AM +0100, Anton Lindqvist wrote: > On Sat, Jan 30, 2021 at 01:18:07PM +0200, Ville Valkonen wrote: > > On Sat, 2021-01-30 at 08:36 +0100, Anton Lindqvist wrote: > > > On Fri, Jan 29, 2021 at 10:15:05PM +0200, Ville Valkonen wrote: > > > > Hi, > > > > > > > > I have

rpki-client remove debug code

2021-02-04 Thread Claudio Jeker
This bit of debug code to understand the progress of rpki-client is no longer helpful. Most of the time this is a stuck rsync that causes delays and those are now nicely handled by an internal timeout. I propose to remove this. -- :wq Claudio Index: main.c ===

Re: rpki-client call a file a file

2021-02-04 Thread Theo Buehler
On Thu, Feb 04, 2021 at 03:09:33PM +0100, Claudio Jeker wrote: > The uri field in the entity queue struct is never a URI but always a local > path to the file in the repo. Rename the field so I'm less confused. > Compiler agrees with my change. Agreed. Some of the functions you need to touch also

rpki-client call a file a file

2021-02-04 Thread Claudio Jeker
The uri field in the entity queue struct is never a URI but always a local path to the file in the repo. Rename the field so I'm less confused. Compiler agrees with my change. -- :wq Claudio ? http.c ? http.diff ? obj Index: extern.h ==

Re: rpki-client, simplify main process

2021-02-04 Thread Theo Buehler
On Thu, Feb 04, 2021 at 11:37:08AM +0100, Claudio Jeker wrote: > Instead of passing around variables all the way down to entity_write_req() > and repo_lookup() use global variables. Especially for the repository > handling this will become more complex with the introduction of RRDP. > Also shuffle

Re: reference trpt(8) in getsockopt(2)

2021-02-04 Thread Alexander Bluhm
On Thu, Feb 04, 2021 at 12:34:22PM +0100, Claudio Jeker wrote: > Also should we export the tcp_debug buffer via sysctl so that > trpt can run without kern.allowkmem? I have set kern.allowkmem on my development and testing machines. But of course a sysctl that always works would make this often for

PF_UNIX sockets unlocking

2021-02-04 Thread Vitaliy Makkoveev
The latest version of the PF_UNIX sockets unlocking diff. The new `unp_lock' rwlock(9) was used as solock()'s backend to protect the whole layer. We release solock() while we perform all vnode(9) related operations. Since fifo subsystem uses unix sockets as backend this is required to enforce `i_

Re: reference trpt(8) in getsockopt(2)

2021-02-04 Thread Claudio Jeker
On Thu, Feb 04, 2021 at 12:30:17PM +0100, Alexander Bluhm wrote: > Hi, > > I always forget the name of trpt(8). It should be refereced in the > SO_DEBUG section of getsockopt(2). > > ok? Yes please. Also should we export the tcp_debug buffer via sysctl so that trpt can run without kern.allowkme

reference trpt(8) in getsockopt(2)

2021-02-04 Thread Alexander Bluhm
Hi, I always forget the name of trpt(8). It should be refereced in the SO_DEBUG section of getsockopt(2). ok? bluhm Index: lib/libc/sys/getsockopt.2 === RCS file: /data/mirror/openbsd/cvs/src/lib/libc/sys/getsockopt.2,v retrieving

Re: tcpbench -D

2021-02-04 Thread Claudio Jeker
On Thu, Feb 04, 2021 at 11:45:26AM +0100, Alexander Bluhm wrote: > Hi, > > I would like to analyse tcpbench(1) TCP connections. So I copied > the nc -D socket debug option. > > ok? Fine with me. OK claudio@ > Index: usr.bin/tcpbench/tcpbench.1 > ===

tcpbench -D

2021-02-04 Thread Alexander Bluhm
Hi, I would like to analyse tcpbench(1) TCP connections. So I copied the nc -D socket debug option. ok? bluhm Index: usr.bin/tcpbench/tcpbench.1 === RCS file: /data/mirror/openbsd/cvs/src/usr.bin/tcpbench/tcpbench.1,v retrieving r

rpki-client, simplify main process

2021-02-04 Thread Claudio Jeker
Instead of passing around variables all the way down to entity_write_req() and repo_lookup() use global variables. Especially for the repository handling this will become more complex with the introduction of RRDP. Also shuffle code around a bit so that all entity queue functions are together. OK?

Re: rpki-client factor out the parser code into own module

2021-02-04 Thread Claudio Jeker
On Wed, Feb 03, 2021 at 10:20:47PM +0100, Theo Buehler wrote: > On Wed, Feb 03, 2021 at 08:08:20PM +0100, Claudio Jeker wrote: > > This is just shuffling code around and adds a few definitions to extern.h. > > The goal is to reduce the amount of code in main.c. I constantly get lost > > in all the