Re: uhidpp(4): logitech hid++ device driver

2021-01-28 Thread Anton Lindqvist
Ping On Fri, Jan 22, 2021 at 08:18:51AM +0100, Anton Lindqvist wrote: > Hi, > Here's a new driver for Logitech HID++ devices, currently limited to > exposing battery sensors. Here's an example using a Logitech M330 mouse: > > $ dmesg | grep uhidpp > uhidpp0 at uhidev1 device 1 mouse "

usbhidctl: efault

2021-01-28 Thread Anton Lindqvist
Hi, While running usbhidctl on my USB mouse it occasionally fails as follows: # usbhidctl -f /dev/wsmouse2 usbhidctl: USB_GET_REPORT (probably not supported by device): Bad address The EFAULT happens during copyin(9) in sys_ioctl() while copying the supplied usb_ctl_report struc

Re: have pf_route bail out if it resolves a route with RTF_LOCAL set

2021-01-28 Thread David Gwynne
On Thu, Jan 28, 2021 at 08:09:36PM +0100, Alexander Bluhm wrote: > On Thu, Jan 28, 2021 at 09:57:33AM +1000, David Gwynne wrote: > > calling if_output with a route to a local IP is confusing, and I'm not > > sure it makes sense anyway. > > > > this treats a an RTF_LOCAL route like an invalid round

Re: [External] : pf: route-to IPs, not interfaces

2021-01-28 Thread Alexandr Nedvedicky
Hello David, thanks for nice wrap up of the story... > > this change does the following: > > - stores the route info in the state instead of the pf rule > > this allows route-to to keep working when the ruleset changes, and > allows route-to info to be sent over pfsync. there's enough spa

Re: systat(1): improve parsing of delay value

2021-01-28 Thread Alexander Bluhm
On Thu, Jan 28, 2021 at 09:06:51PM +0100, Martijn van Duren wrote: > Thanks for checking. Should be fixed below. OK bluhm@ > Index: main.c > === > RCS file: /cvs/src/usr.bin/systat/main.c,v > retrieving revision 1.72 > diff -u -p -r1

Re: pf: route-to IPs, not interfaces

2021-01-28 Thread Alexander Bluhm
On Thu, Jan 28, 2021 at 10:54:30PM +1000, David Gwynne wrote: > this is the diff from the "pf route-to issues" thread, but on it's own. I think we should make progress and commit something. > the caveat is that route-to becomes tied to pass rules that create > state, like rdr-to and nat-to.

Re: snmpd: remove print_{verbose,debug}

2021-01-28 Thread Klemens Nanni
On Sun, Jan 24, 2021 at 02:48:39PM +0100, Martijn van Duren wrote: > Nothing seems to use them and I see no reason in the forseeable future > to start using them. OK kn

Re: snmpd: remove print_{verbose,debug}

2021-01-28 Thread Martijn van Duren
ping On Sun, 2021-01-24 at 14:48 +0100, Martijn van Duren wrote: > Nothing seems to use them and I see no reason in the forseeable future > to start using them. > > OK? > > martijn@ > > Index: snmpd.h > === > RCS file: /cvs/src/usr

Re: systat(1): improve parsing of delay value

2021-01-28 Thread Martijn van Duren
On Tue, 2021-01-26 at 16:40 +0100, Alexander Bluhm wrote: > On Mon, Jan 25, 2021 at 11:17:04AM +0100, Martijn van Duren wrote: > > if (argc == 1) { > > -   double del = atof(argv[0]); > > -   if (del == 0) > > +   delay = strtodnum(argv[0], 0, UINT32_MAX

Re: have pf_route bail out if it resolves a route with RTF_LOCAL set

2021-01-28 Thread Alexander Bluhm
On Thu, Jan 28, 2021 at 09:57:33AM +1000, David Gwynne wrote: > calling if_output with a route to a local IP is confusing, and I'm not > sure it makes sense anyway. > > this treats a an RTF_LOCAL route like an invalid round and drops the > packet. > > ok? Are you sure that it does not break any

ldapd(8): Xr ldap(1)

2021-01-28 Thread Todd C . Miller
Add ldap(1) to SEE ALSO in ldapd(8). I don't think there is a need to add it to ldapctl(8) or ldapd.conf(5). - todd Index: usr.sbin/ldapd/ldapd.8 === RCS file: /cvs/src/usr.sbin/ldapd/ldapd.8,v retrieving revision 1.14 diff -u -p -

Re: rpki-client remove double checking of hashes

2021-01-28 Thread Claudio Jeker
On Thu, Jan 28, 2021 at 05:19:31PM +0100, Theo Buehler wrote: > On Thu, Jan 28, 2021 at 04:42:00PM +0100, Claudio Jeker wrote: > > Initially rpki-client checked the file hash while parsing the file (.roa, > > .cert or .crl) but since a while rpki-client does the hash check early > > during the .mft

Re: rpki-client remove double checking of hashes

2021-01-28 Thread Theo Buehler
On Thu, Jan 28, 2021 at 04:42:00PM +0100, Claudio Jeker wrote: > Initially rpki-client checked the file hash while parsing the file (.roa, > .cert or .crl) but since a while rpki-client does the hash check early > during the .mft parsing with mft_check(). After that all files in the > fileandhash a

Re: search usbd_interfaces in case of non-compliant device

2021-01-28 Thread Mark Kettenis
> Date: Thu, 28 Jan 2021 16:45:12 +0100 > From: Marcus Glocker > Cc: Alexandre Ratchov , tech@openbsd.org, ratc...@openbsd.org, > st...@openbsd.org, kette...@openbsd.org, m...@openbsd.org > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > > On Thu, Jan 28, 2021 a

Re: search usbd_interfaces in case of non-compliant device

2021-01-28 Thread Marcus Glocker
On Thu, Jan 28, 2021 at 02:38:04PM +, Edd Barrett wrote: > On Thu, Jan 28, 2021 at 09:56:14AM +, Edd Barrett wrote: > > > > Here's a revised diff that always searches the array, instead of first > trying the expected index. Everyone agreed that this makes for simpler > code, and that sinc

rpki-client remove double checking of hashes

2021-01-28 Thread Claudio Jeker
Initially rpki-client checked the file hash while parsing the file (.roa, .cert or .crl) but since a while rpki-client does the hash check early during the .mft parsing with mft_check(). After that all files in the fileandhash attribute are verified and so there is no need to do it again. All in a

Re: search usbd_interfaces in case of non-compliant device

2021-01-28 Thread Edd Barrett
On Thu, Jan 28, 2021 at 09:56:14AM +, Edd Barrett wrote: > Here's a revised diff that always searches the array, instead of first trying the expected index. Everyone agreed that this makes for simpler code, and that since this function isn't called much, there's no real performance concern. C

pf: route-to IPs, not interfaces

2021-01-28 Thread David Gwynne
this is the diff from the "pf route-to issues" thread, but on it's own. the summary of why i wanted to do this is: - route-to, reply-to, and dup-to do not work with pfsync this is because the information about where to route-to is stored in rules, and it is hard to have a ruleset synced 100%

Re: search usbd_interfaces in case of non-compliant device

2021-01-28 Thread Edd Barrett
Hi, On Wed, Jan 27, 2021 at 08:58:21AM +0100, Alexandre Ratchov wrote: > ok ratchov Thanks everyone for your OKs. Here's an updated diff that caters for Marcus' recent attribute renaming and which also has the long comment wrapped. I'll commit it shortly if nothing else comes up. Index: usbdi