Re: IPv6 pf_test EACCES

2020-12-21 Thread Claudio Jeker
On Mon, Dec 21, 2020 at 11:34:04PM +0100, Alexander Bluhm wrote: > Hi, > > A while ago we decided to pass EACCES to uerland if pf blocks a > packet. IPv6 still has the old EHOSTUNREACH code. > > Use the same errno for dropped IPv6 packets as in IPv4. > > ok? Seems reasonable. OK claudio@ > In

IPv6 pf_test EACCES

2020-12-21 Thread Alexander Bluhm
Hi, A while ago we decided to pass EACCES to uerland if pf blocks a packet. IPv6 still has the old EHOSTUNREACH code. Use the same errno for dropped IPv6 packets as in IPv4. ok? bluhm Index: netinet6/ip6_output.c === RCS file: /d

Re: [please test] acpi: more *sleep(9) -> *sleep_nsec(9) conversions

2020-12-21 Thread Greg Steuck
Paul Irofti writes: > I think Scott should split his diff in two so people can test which > part breaks suspend-resume. Can you try reverting the dsdt.c bits and > leaving the acpiec part of the diff in your tree and see if suspend is > still broken? Reverting dsdt.c and applying acpiec.c part r

Re: Force knote state update in klist_invalidate()

2020-12-21 Thread Martin Pieuchot
On 21/12/20(Mon) 16:45, Visa Hankala wrote: > There is a slight inconsistency in klist_invalidate(). If the knote is > already in the event queue and has flag EV_ONESHOT, kqueue_scan() will > not invoke the newly set f_event. In this case, the kevent(2) system > call will return the knote's origina

uvmexp & per-CPU counters

2020-12-21 Thread Martin Pieuchot
During a page fault multiples counters are updated. They fall into two categories "fault counters" and "global statistics" both of which are currently represented by int-sized fields inside a global: `uvmexp'. Diff below makes use of the per-CPU counters_inc(9) API to make sure no update is lost

Re: prototype of delay(9) is inconsistent

2020-12-21 Thread Mark Kettenis
> Date: Mon, 21 Dec 2020 11:25:28 -0600 > From: Scott Cheloha > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > > The manpage for delay(9) suggests that the prototype is: > > void delay(int); > > But on armv7, arm64, hppa, macppc, and powerpc64 the input is unsigned >

Re: prototype of delay(9) is inconsistent

2020-12-21 Thread Theo de Raadt
catching underflow which results in infinite delays is probably very handy. Scott Cheloha wrote: > The manpage for delay(9) suggests that the prototype is: > > void delay(int); > > But on armv7, arm64, hppa, macppc, and powerpc64 the input is unsigned > or a u_int instead of an int. Like this

prototype of delay(9) is inconsistent

2020-12-21 Thread Scott Cheloha
The manpage for delay(9) suggests that the prototype is: void delay(int); But on armv7, arm64, hppa, macppc, and powerpc64 the input is unsigned or a u_int instead of an int. Like this: void delay(unsigned); or this: void delay(u_int); Can we pick a prototype and stick to it? An upside of a

Force knote state update in klist_invalidate()

2020-12-21 Thread Visa Hankala
There is a slight inconsistency in klist_invalidate(). If the knote is already in the event queue and has flag EV_ONESHOT, kqueue_scan() will not invoke the newly set f_event. In this case, the kevent(2) system call will return the knote's original event state that no longer reflects the state that

Re: WITNESS panic: acquiring blockable sleep lock with spinlock or critical section held (rwlock) kmmaplk

2020-12-21 Thread Martin Pieuchot
On 20/12/20(Sun) 20:55, Mark Kettenis wrote: > > Date: Sat, 19 Dec 2020 18:07:41 -0300 > > From: Martin Pieuchot > > > > On 18/12/20(Fri) 08:04, Todd C. Miller wrote: > > > On Fri, 18 Dec 2020 13:34:39 +0100, Mark Kettenis wrote: > > > > > > > Anyway, your analysis is right. When a kernel threa

Re: tsleep(9): sleep on private channel if ident is NULL

2020-12-21 Thread Mark Kettenis
> Date: Fri, 18 Dec 2020 13:49:32 -0600 > From: Scott Cheloha > > Hi, > > This patch adds support for passing NULL as the ident when calling > tsleep(9) etc. When this happens, sleep_setup() will use the address > of the sleep_state struct as the value for p_wchan. This address is > basically

Re: smtp(1) add authentication

2020-12-21 Thread Eric Faurot
On Sun, Dec 20, 2020 at 07:58:56PM +0100, Martijn van Duren wrote: > Playing around with the filter API I want an easier way to send mail > with authentication instead of doing the transaction manually via > openssl or via bloated mailclients. Turns out we already have all the > plumbing in place a

Re: [please test] acpi: more *sleep(9) -> *sleep_nsec(9) conversions

2020-12-21 Thread Mark Kettenis
> Date: Sun, 20 Dec 2020 16:23:25 -0600 > From: Scott Cheloha > > Short version: > > Please test if this patch breaks suspend or hibernate on your > machine. Reply with the results of your test and your dmesg. > > Both are still working on my Lenovo Thinkpad X1 Carbon Gen 6. > > Long version:

Re: [please test] acpi: more *sleep(9) -> *sleep_nsec(9) conversions

2020-12-21 Thread Paul Irofti
I think Scott should split his diff in two so people can test which part breaks suspend-resume. Can you try reverting the dsdt.c bits and leaving the acpiec part of the diff in your tree and see if suspend is still broken? Paul