fortune: allow to use symlinks

2020-12-14 Thread Vadim Zhukov
Hello, all. This allows fortune(6) to open fortune files via symlinks. Maybe this is a stupid idea, I dunno, but it seems inconsistent that I can't put a symlink to my fortunes collection in /usr/share/games/fortune and then simply call "fortune foo" instead of "fortune /usr/local/share/games/fort

Re: Remove variable count from kqueue_scan()

2020-12-14 Thread Vitaliy Makkoveev
ok mvs@ > On 14 Dec 2020, at 18:40, Visa Hankala wrote: > > In function kqueue_scan(), variables count and nkev follow relation > count + nkev == maxevents. The code becomes a bit simpler if count > is removed. > > OK? > > Index: kern/kern_event.c >

Re: Double entry in /usr/src/lib/libcurses/curs_util.3

2020-12-14 Thread Chris Bennett
On Mon, Dec 14, 2020 at 09:06:21PM +, Stuart Henderson wrote: > > This is present in the latest release upstream, could you report it > there please? > https://invisible-island.net/ncurses/announce.html#h2-development > > SEE ALSO are usually in (at least roughly) alphabetical order so it's

Re: Double entry in /usr/src/lib/libcurses/curs_util.3

2020-12-14 Thread Stuart Henderson
On 2020/12/14 14:45, Chris Bennett wrote: > See also has a double entry. > > Chris Bennett This is present in the latest release upstream, could you report it there please? https://invisible-island.net/ncurses/announce.html#h2-development SEE ALSO are usually in (at least roughly) alphabetical o

Double entry in /usr/src/lib/libcurses/curs_util.3

2020-12-14 Thread Chris Bennett
See also has a double entry. Chris Bennett Index: curs_util.3 === RCS file: /cvs/src/lib/libcurses/curs_util.3,v retrieving revision 1.6 diff -u -p -u -p -r1.6 curs_util.3 --- curs_util.3 12 Jan 2010 23:21:59 - 1.6 +++ curs

Re: bgpd send side hold timer

2020-12-14 Thread Job Snijders
Hi all, This patch appears to be a very elegant solution to a thorny subtle problem: what to do when a peer is not accepting new routing information from you? I've seen in the wild that some crashed BGP implementations continue to be able to generate KEEPALIVE messages, and are able to TCP ACK ke

bgpd send side hold timer

2020-12-14 Thread Claudio Jeker
The BGP protocol has a keepalive packet which resets the hold timer when a packet is received. The problem is this covers only one side of the transmission. It seems that some BGP implementations fail to process messages in some cases but still send out KEEPALIVE packets. So bgpd thinks everything

Remove variable count from kqueue_scan()

2020-12-14 Thread Visa Hankala
In function kqueue_scan(), variables count and nkev follow relation count + nkev == maxevents. The code becomes a bit simpler if count is removed. OK? Index: kern/kern_event.c === RCS file: src/sys/kern/kern_event.c,v retrieving revi

Re: rw_lock_held() & friends

2020-12-14 Thread Visa Hankala
On Mon, Dec 14, 2020 at 10:59:05AM -0300, Martin Pieuchot wrote: > On 08/12/20(Tue) 14:39, Visa Hankala wrote: > > On Mon, Dec 07, 2020 at 03:25:00PM -0300, Martin Pieuchot wrote: > > > Simple diff below to add the rw_lock_held() as well as a read & write > > > version. > > > > > > This allows us

[diff] usr.sbin/smtpd: fix event handling upon exit

2020-12-14 Thread GILLES CHEHADE
Hello, Upon termination, the parent process will call parent_shutdown() which will in turn call mproc_clear() to properly terminate IPC with child processes. In mproc_clear(), event_del() is called but a check is lacking to ensure event_add() was called prior to this. On OpenBSD, this doesn’t

Re: rw_lock_held() & friends

2020-12-14 Thread Martin Pieuchot
On 08/12/20(Tue) 14:39, Visa Hankala wrote: > On Mon, Dec 07, 2020 at 03:25:00PM -0300, Martin Pieuchot wrote: > > Simple diff below to add the rw_lock_held() as well as a read & write > > version. > > > > This allows us to reduce the difference with NetBSD in UVM by adding the > > following check

Re: diff: replace useless use of MCLGETL with MCLGET

2020-12-14 Thread Alexander Bluhm
On Sat, Dec 12, 2020 at 02:05:48PM +0100, Jan Klemkow wrote: > Thus, this diff removes '(void)' from the MCLGET macro > -#define MCLGET(m, how) (void) m_clget((m), (how), MCLBYTES) > +#define MCLGET(m, how) m_clget((m), (how), MCLBYTES) The MCLGET API is to add a cluster to an existing mbuf. Retu

snmp - remove BER_TYPE_BOOLEAN

2020-12-14 Thread Martijn van Duren
I can't find any reference in RFC2578 for a boolean type, nor have I seen it in the wild and the TruthValue diff I just committed give me a strong indication that this was added without any real reason. OK to remove? martijn@ Index: usr.bin/snmp/smi.c