Re: [PATCH] Convert ddb_sysctl to sysctl_bounded_arr

2020-12-08 Thread George Koehler
On Fri, 04 Dec 2020 20:15:13 -0800 Greg Steuck wrote: > George Koehler writes: > > > If I do ddb set a bad value, then sysctl refuses to show the value: > > > > # sysctl ddb.console=1 > > ddb.console: 0 -> 1 > > # sysctl ddb.trigger=1 > > Stopped at ddb_sysctl+0x114:

Re: FT232H variant which works

2020-12-08 Thread Daniel Bolgheroni
On Tue, Dec 08, 2020 at 03:04:58PM -0300, Daniel Bolgheroni wrote: > Hi tech@, > Sorry, duplicate, disconsider since I sent it again just to find out I had no rDNS. -- db

FT232H variant which works

2020-12-08 Thread Daniel Bolgheroni
Hi tech@, I have a FT232H variant (marked FT232HQ, 0403:6014) which works with uftdi(4). Still related to uftdi(4), sys/dev/usb/ftdi.c has a comment saying uftdi(4) does not support multiple serial ports because ucom(4), but I'm able to use both ucom(4) in parallel from a FT2232H (dual). Thank y

FT232H variant in uftdi(4)

2020-12-08 Thread Daniel Bolgheroni
Hi tech@, I have a FT232H variant (marked FT232HQ, 0403:6014) which works with uftdi(4). Still related to uftdi(4), sys/dev/usb/ftdi.c has a comment saying uftdi(4) does not support multiple serial ports because ucom(4), but I'm able to use both ucom(4) in parallel from the same FT2232H (dual).

Re: [PATCH] Convert gre_sysctl to sysctl_bounded_arr

2020-12-08 Thread George Koehler
ok gkoehler@ with one comment change, see below. On Sat, 21 Nov 2020 15:36:58 -0800 Greg Steuck wrote: > diff --git sys/net/if_gre.c sys/net/if_gre.c > index cb5beeaad62..deacad9c755 100644 > --- sys/net/if_gre.c > +++ sys/net/if_gre.c > @@ -1109,7 +1109,7 @@ gre_input_key(struct mbuf **mp, int

Re: ieee80211: Flush reorder buffer after gap timeout

2020-12-08 Thread Stefan Sperling
On Tue, Dec 08, 2020 at 04:49:27PM +0100, Tobias Heider wrote: > Hi, > > here is another diff that should fix associating with > some APs that currently don't work. > > If block ack is active and the first frame got lost, > subsequent packets are held back until a timeout expires. > When this tim

ieee80211: Flush reorder buffer after gap timeout

2020-12-08 Thread Tobias Heider
Hi, here is another diff that should fix associating with some APs that currently don't work. If block ack is active and the first frame got lost, subsequent packets are held back until a timeout expires. When this timeout expires, the gap at the start of the reorder buffer is skipped and subsequ

Re: uvm_fault: entering swap code

2020-12-08 Thread Martin Pieuchot
On 08/12/20(Tue) 22:55, Jonathan Matthew wrote: > On Mon, Dec 07, 2020 at 03:15:50PM -0300, Martin Pieuchot wrote: > > Getting a page from the fault handler might require poking at some > > swap-related states. > > > > These are not in the hot-path of the fault handler so for the moment > > just a

Re: rw_lock_held() & friends

2020-12-08 Thread Visa Hankala
On Mon, Dec 07, 2020 at 03:25:00PM -0300, Martin Pieuchot wrote: > Simple diff below to add the rw_lock_held() as well as a read & write > version. > > This allows us to reduce the difference with NetBSD in UVM by adding the > following checks: > > KASSERT(rw_write_held(amap->am_lock)); >

Re: ipmi(4): ipmi_poll_thread(): tsleep(9) -> tsleep_nsec(9)

2020-12-08 Thread Stuart Henderson
On 2020/12/07 22:54, Scott Cheloha wrote: > On Wed, Dec 02, 2020 at 11:43:32PM +0100, Mark Kettenis wrote: > > > From: "Constantine A. Murenin" > > > Date: Wed, 2 Dec 2020 14:04:52 -0800 > > > > > > Not sure if you've seen it, but ipmi(4) has been disabled for over 12 > > > years, because it's br

sleep_setup/finish simplification

2020-12-08 Thread Martin Pieuchot
Diff below aims to simplify the API to put a thread on a sleep queue and reduce it to the following: sleep_setup(); /* check condition or release lock */ sleep_finish(); It is motivated by my work to sleep the SCHED_LOCK() but might as well prevent/fix some bugs. The tric

Re: uvm_fault: entering swap code

2020-12-08 Thread Jonathan Matthew
On Mon, Dec 07, 2020 at 03:15:50PM -0300, Martin Pieuchot wrote: > Getting a page from the fault handler might require poking at some > swap-related states. > > These are not in the hot-path of the fault handler so for the moment > just assert that the KERNEL_LOCK() is held or grab it if the funct

Re: kqpoll_init/exit()

2020-12-08 Thread Martin Pieuchot
On 08/12/20(Tue) 11:45, Mark Kettenis wrote: > > Date: Mon, 7 Dec 2020 14:18:41 -0300 > > From: Martin Pieuchot > [,..] > > Index: kern/kern_event.c > > === > > RCS file: /cvs/src/sys/kern/kern_event.c,v > > retrieving revision 1.146

Re: uvm_fault: kill goto in uvm_fault()

2020-12-08 Thread Theo Buehler
On Mon, Dec 07, 2020 at 04:08:46PM -0300, Martin Pieuchot wrote: > Diff below rewrites uvm_fault() using a loop. > > I added a KERNEL_LOCK/UNLOCK() dance around the part that won't be > unlocked soon to illustrate where this is going. > > ok? I'm also ok with this. Total bikesheed, but I would

Re: kqpoll_init/exit()

2020-12-08 Thread Mark Kettenis
> Date: Mon, 7 Dec 2020 14:18:41 -0300 > From: Martin Pieuchot > > Diff below adds a per-thread kqueue that will be initialized during the > first select(2) or poll(2) syscall and freed upon exit. > > Along with this queue a per-thread serial number is used to check the > integrity of events enq

Re: uvm_fault: kill goto in uvm_fault()

2020-12-08 Thread Jonathan Matthew
On Mon, Dec 07, 2020 at 04:08:46PM -0300, Martin Pieuchot wrote: > Diff below rewrites uvm_fault() using a loop. > > I added a KERNEL_LOCK/UNLOCK() dance around the part that won't be > unlocked soon to illustrate where this is going. > > ok? yes, ok jmatthew@ > > Index: uvm/uvm_fault.c >

Re: IPv6 packets are not forwarded via IPsec tunnel

2020-12-08 Thread Stuart Henderson
On 2020/12/08 10:26, Yuichiro NAITO wrote: > The inner packet destination address is written in the encapsulated packet and > the final address to be delivered. > The outer packet destination address is peer address of IPsec tunnel. > > Do you mean that I have to set the routing table entry for th