Re: [PATCH] Add IOMMU support for Intel VT-d and AMD-Vi

2020-10-05 Thread Mark Kettenis
> Date: Thu, 17 Sep 2020 20:54:51 -0500 > From: Jordan Hargrave > Cc: ma...@peereboom.org, kette...@openbsd.org, tech@openbsd.org, > d...@openbsd.org, j...@openbsd.org > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > > Ok made more changes > > On Mon, Sep

Re: Bad definition of SIOCG80211JOIN

2020-10-05 Thread Theo de Raadt
OK deraadt Gerhard Roth wrote: > The current definition of SIOCG80211JOIN uses 256 for the command, > but the _IOC() macro only allows 8 bit for the command value. > Using 256 would set the lowermost bit of the ioctl group. > Fortunately, 'i' (0x69) already has the lowermost bit set. Otherwise

Re: mmap: Do not push KERNEL_LOCK() too far

2020-10-05 Thread Mark Kettenis
> Date: Mon, 5 Oct 2020 11:25:39 +0200 > From: Martin Pieuchot > > On 03/10/20(Sat) 12:59, Mark Kettenis wrote: > > > Date: Fri, 2 Oct 2020 10:32:27 +0200 > > > From: Martin Pieuchot > > > > > > On 01/10/20(Thu) 21:44, Mark Kettenis wrote: > > > > > Date: Thu, 1 Oct 2020 14:10:56 +0200 > > > >

Bad definition of SIOCG80211JOIN

2020-10-05 Thread Gerhard Roth
The current definition of SIOCG80211JOIN uses 256 for the command, but the _IOC() macro only allows 8 bit for the command value. Using 256 would set the lowermost bit of the ioctl group. Fortunately, 'i' (0x69) already has the lowermost bit set. Otherwise SIOCG80211JOIN would never reach ifioctl().

Re: mmap: Do not push KERNEL_LOCK() too far

2020-10-05 Thread Martin Pieuchot
On 03/10/20(Sat) 12:59, Mark Kettenis wrote: > > Date: Fri, 2 Oct 2020 10:32:27 +0200 > > From: Martin Pieuchot > > > > On 01/10/20(Thu) 21:44, Mark Kettenis wrote: > > > > Date: Thu, 1 Oct 2020 14:10:56 +0200 > > > > From: Martin Pieuchot > > > > > > > > While studying a bug report from naddy@