Re: [PATCH netcat] Only force fd's to -1 once

2020-09-27 Thread Duncan Roe
On Sun, Sep 27, 2020 at 08:27:24PM -0600, Theo de Raadt wrote: > Duncan Roe wrote: > > > > I disagree with your plan. This kind of "force it off" programming is > > > typical. > > > > > Might be typical, but I think it's sloppy. > > I don't think it is sloppy. > > Instead, I think your additional

Re: [PATCH netcat] Only force fd's to -1 once

2020-09-27 Thread Theo de Raadt
Duncan Roe wrote: > > I disagree with your plan. This kind of "force it off" programming is > > typical. > > > Might be typical, but I think it's sloppy. I don't think it is sloppy. Instead, I think your additional logic complicates review.

Re: [PATCH netcat] Only force fd's to -1 once

2020-09-27 Thread Duncan Roe
On Sun, Sep 27, 2020 at 07:53:27PM -0600, Theo de Raadt wrote: > Duncan Roe wrote: > > > On Sun, Sep 27, 2020 at 02:18:21PM -0600, Bob Beck wrote: > > > On Sun, Sep 27, 2020 at 02:46:39PM +1000, Duncan Roe wrote: > > > > The motivation for this is to make debug logs less confusing. > > > > > > Wha

Re: [PATCH netcat] Only force fd's to -1 once

2020-09-27 Thread Theo de Raadt
Duncan Roe wrote: > On Sun, Sep 27, 2020 at 02:18:21PM -0600, Bob Beck wrote: > > On Sun, Sep 27, 2020 at 02:46:39PM +1000, Duncan Roe wrote: > > > The motivation for this is to make debug logs less confusing. > > > > What is this fixing and what behavior are you changing? > > You can only see t

Re: [PATCH netcat] Only force fd's to -1 once

2020-09-27 Thread Duncan Roe
On Sun, Sep 27, 2020 at 02:18:21PM -0600, Bob Beck wrote: > On Sun, Sep 27, 2020 at 02:46:39PM +1000, Duncan Roe wrote: > > The motivation for this is to make debug logs less confusing. > > What is this fixing and what behavior are you changing? You can only see the difference when running nc unde

Re: apmd(8) and hw.perfpolicy quirks

2020-09-27 Thread Ted Unangst
On 2020-09-27, Jeremie Courreges-Anglas wrote: > The diff below teaches apmd(8) -H to set hw.perfpolicy="manual" and > hw.setperf=100, instead of setting hw.perfpolicy="high". sure. if you would like to own this, by all means. :)

[PATCH ssh] VisualHostKey: unknown keys

2020-09-27 Thread Dmitry Lapshin
After using VisualHostKey ssh client option for some time, I've found out that for me it's quite useful for manual host key verification (where DNS-signed host keys are not available, for example), but it's too noisy for casual usage when it outputs ASCII art on every login. So, I've implemented a

Re: [PATCH netcat] Only force fd's to -1 once

2020-09-27 Thread Bob Beck
On Sun, Sep 27, 2020 at 02:46:39PM +1000, Duncan Roe wrote: > The motivation for this is to make debug logs less confusing. What is this fixing and what behavior are you changing? > > All changed lines have previously demonstrated the problem. > > Signed-off-by: Duncan Roe > --- > usr.bin/nc/

Re: RFC: kern.video.record

2020-09-27 Thread Laurence Tratt
On Sun, Sep 13, 2020 at 09:23:36AM +0100, Laurence Tratt wrote: > Since I recently opened my big fat mouth and suggested that > "kern.video.record" (analogous to kern.audio.record) might be a good idea, I > decided to put together a quick prototype (heavily based on the > kern.audio.record code).

Re: apmd(8) and hw.perfpolicy quirks

2020-09-27 Thread Jeremie Courreges-Anglas
On Thu, Sep 24 2020, Jeremie Courreges-Anglas wrote: > On Wed, Sep 23 2020, "Ted Unangst" wrote: >> On 2020-09-23, Jeremie Courreges-Anglas wrote: >> >>> ok? >> >> Seems fine. >> >> >>> Note: I inlined the apmd(8)->apm(8) perfpolicy conversion for now, which >>> brings a question. I find it weir