Re: amd64: add tsc_delay(), a TSC-based delay(9) implementation

2020-08-23 Thread Scott Cheloha
On Sun, Aug 23, 2020 at 11:45:22PM -0500, Scott Cheloha wrote: > > [...] > > > > This patch (or something equivalent) is a prerequisite to running the > > > lapic timer in oneshot or TSC deadline mode. Using the lapic timer to > > > implement delay(9) when it isn't running in periodic mode is to

Re: aggr.4 and trunk.4: omit common ifconfig options

2020-08-23 Thread Jason McIntyre
On Mon, Aug 24, 2020 at 01:26:06AM +0200, Klemens Nanni wrote: > ifconfig(8)'s TRUNK (LINK AGGREGATION) nicely combines the two drivers > and I'd like to further omit common stuff from the drive specific > manuals. > > This aids in the overall design of having options documented in > ifconfig(8) a

Re: amd64: add tsc_delay(), a TSC-based delay(9) implementation

2020-08-23 Thread Scott Cheloha
On Mon, Aug 24, 2020 at 01:55:45AM +0200, Mark Kettenis wrote: > > Date: Sun, 23 Aug 2020 18:11:12 -0500 > > From: Scott Cheloha > > > > Hi, > > > > Other BSDs use the TSC to implement delay(9) if the TSC is constant > > and invariant. Here's a patch to add something similar to our kernel. > >

Re: amd64: add tsc_delay(), a TSC-based delay(9) implementation

2020-08-23 Thread Mark Kettenis
> Date: Sun, 23 Aug 2020 18:11:12 -0500 > From: Scott Cheloha > > Hi, > > Other BSDs use the TSC to implement delay(9) if the TSC is constant > and invariant. Here's a patch to add something similar to our kernel. If the TSC is fine as a timecounter it should be absolutely fine for use as dela

aggr.4 and trunk.4: omit common ifconfig options

2020-08-23 Thread Klemens Nanni
ifconfig(8)'s TRUNK (LINK AGGREGATION) nicely combines the two drivers and I'd like to further omit common stuff from the drive specific manuals. This aids in the overall design of having options documented in ifconfig(8) alone unless they're inherently driver specific, e.g. `trunkproto' which sta

amd64: add tsc_delay(), a TSC-based delay(9) implementation

2020-08-23 Thread Scott Cheloha
Hi, Other BSDs use the TSC to implement delay(9) if the TSC is constant and invariant. Here's a patch to add something similar to our kernel. This patch (or something equivalent) is a prerequisite to running the lapic timer in oneshot or TSC deadline mode. Using the lapic timer to implement del

Re: timekeep: fixing large skews on amd64 with RDTSCP

2020-08-23 Thread Hrvoje Popovski
On 23.8.2020. 16:50, Claudio Jeker wrote: > On Sun, Aug 23, 2020 at 04:06:01PM +0200, Christian Weisgerber wrote: >> Scott Cheloha: >> >>> This "it might slow down the network stack" thing keeps coming up, and >>> yet nobody can point to (a) who expressed this concern or (b) what the >>> penalty is

top: toggle routing tables

2020-08-23 Thread Klemens Nanni
Add `t' to swap the WAIT column with RTABLE (and vice versa); WAIT is wide enough to fit RTABLE, somewhat adds additional value to STATE and seems therefore most appropiate to hide in favour of RTABLE. Internally, I renamed the existing CMD_rtable command to filter routing tables into CMD_rtablei

Re: Improve semantics and punctuation in ifconfig.8

2020-08-23 Thread Jason McIntyre
On Sat, Aug 22, 2020 at 02:18:48PM -0700, Evan Silberman wrote: > Not to provoke a deep philosophical debate about the difference between > Ql, Cm, and Sy, but surely Em isn't the best choice here. A couple other > nits that bothered me in the same general region, I guess your taste > might vary. >

Re: top: filter by routing table

2020-08-23 Thread Remi Locherer
On Sun, Aug 23, 2020 at 10:45:14PM +0200, Klemens Nanni wrote: > On Sun, Aug 23, 2020 at 10:39:21PM +0200, Remi Locherer wrote: > > I like the feature and it works as advertised. > > > > It would be nice to have a column that displays the rtable id of > > each process when T is used. When I type "

Re: top: filter by routing table

2020-08-23 Thread Klemens Nanni
On Sun, Aug 23, 2020 at 10:39:21PM +0200, Remi Locherer wrote: > I like the feature and it works as advertised. > > It would be nice to have a column that displays the rtable id of > each process when T is used. When I type "T-0" I see a list of procs > not in rtable 0. But I still do not know in

Re: top: filter by routing table

2020-08-23 Thread Remi Locherer
On Sat, Aug 22, 2020 at 05:20:56PM -0600, Todd C. Miller wrote: > This looks good to me but I've refrained from commenting simply > because I don't use rtables at all myself. Can we get some feedback > from people who actually use rtables? > > - todd > I like the feature and it works as advert

Re: awk: implement mktime() function

2020-08-23 Thread Jason McIntyre
On Sun, Aug 23, 2020 at 10:25:37AM -0600, Todd C. Miller wrote: > Both gawk and mawk include mktime() in their time functions. > We have strftime() and systime() but no mktime(). The following > diff makes our awk more compatible with other implementations. > > - todd > hi/ i think the text i

awk: implement mktime() function

2020-08-23 Thread Todd C . Miller
Both gawk and mawk include mktime() in their time functions. We have strftime() and systime() but no mktime(). The following diff makes our awk more compatible with other implementations. - todd Index: usr.bin/awk/awk.1 === RCS fil

Re: timekeep: fixing large skews on amd64 with RDTSCP

2020-08-23 Thread Claudio Jeker
On Sun, Aug 23, 2020 at 04:06:01PM +0200, Christian Weisgerber wrote: > Scott Cheloha: > > > This "it might slow down the network stack" thing keeps coming up, and > > yet nobody can point to (a) who expressed this concern or (b) what the > > penalty is in practice. > > It was kettenis@ who simpl

Re: timekeep: fixing large skews on amd64 with RDTSCP

2020-08-23 Thread Christian Weisgerber
Scott Cheloha: > This "it might slow down the network stack" thing keeps coming up, and > yet nobody can point to (a) who expressed this concern or (b) what the > penalty is in practice. It was kettenis@ who simply raised the question and asked for comments from the network people. I think we sh

Re: timekeep: fixing large skews on amd64 with RDTSCP

2020-08-23 Thread Mark Kettenis
> Date: Sat, 22 Aug 2020 22:05:44 -0500 > From: Scott Cheloha > > On Tue, Jul 28, 2020 at 10:02:07AM +0300, Paul Irofti wrote: > > > > [...] > > > > Is the issue with LFENCE slowing down the network stack settled? That was > > the argument against it last time. > > ... a month passes. Nobody

Re: pf: remove ptr_array from struct pf_ruleset

2020-08-23 Thread Klemens Nanni
On Mon, Jul 20, 2020 at 05:07:03PM +0200, Klemens Nanni wrote: > On Mon, Jul 20, 2020 at 01:14:00PM +0200, Alexandr Nedvedicky wrote: > > I took a closer look at your change and related area. Below is an alternate > > way to fix the bug you've found. > Thanks for bringing it up again, I forgot to

Re: video -c: showing auto white balance temperature

2020-08-23 Thread Marcus Glocker
On Sun, 23 Aug 2020 08:59:10 +0100 Laurence Tratt wrote: > On Sun, Aug 23, 2020 at 09:17:57AM +0200, Marcus Glocker wrote: > > Hello Marcus, > > > Sorry for the delay - I'm back to business mode and need to take > > care about naive project managers with crazy requirements the most > > of the d

Re: timekeep: fixing large skews on amd64 with RDTSCP

2020-08-23 Thread Paul Irofti
Hi, As I see this is addressed to me I will reply. I am in the mountains until the end of the month with poor internet connection. First, it was not me that stated that the network stack is blocking the change. Somebody said that during the initial development of the user timeclock when I prop

Re: video -c: showing auto white balance temperature

2020-08-23 Thread Laurence Tratt
On Sun, Aug 23, 2020 at 09:17:57AM +0200, Marcus Glocker wrote: Hello Marcus, > Sorry for the delay - I'm back to business mode and need to take care > about naive project managers with crazy requirements the most of the day Rather you than me :) > See inline some (nitpicking) feedback and adap

Re: video -c: showing auto white balance temperature

2020-08-23 Thread Marcus Glocker
Hello Laurie, Sorry for the delay - I'm back to business mode and need to take care about naive project managers with crazy requirements the most of the day ... See inline some (nitpicking) feedback and adapted diff. Ok for you? Thanks, Marcus On Sun, 9 Aug 2020 13:09:34 +0100 Laurence Tratt