On Sun, Jul 12, 2020 at 07:44:47PM +0200, Klemens Nanni wrote:
> Feedback? OK?
You need to have pf.h in scope to condition on NPF > 0.
panic: kernel diagnostic assertion "m->m_ptheader.pf.statekey == NULL" failed:
file "/usr/src/sys/net/pf.c" line 7455
Index: sys/net/if_wg.c
===
On Sun, Jul 12, 2020 at 11:44:57PM -0400, George Koehler wrote:
> Hello tech list,
>
> My CLOCK_MONOTONIC can jump backwards.
I can reproduce it here. Very unsettling.
> It looks like a problem with tk_generation in the user timekeep page.
> If tk_offset_count and tk_offset change but tk_gener
Hello tech list,
My CLOCK_MONOTONIC can jump backwards. It looks like a problem with
tk_generation in the user timekeep page. If tk_offset_count and
tk_offset change but tk_generation doesn't change, then libc can mix
old and new values and calculate a bogus time.
This diff tries to fix it. Th
ok mvs@
> On 13 Jul 2020, at 01:22, Klemens Nanni wrote:
>
> On Sun, Jul 12, 2020 at 10:31:49PM +0300, Vitaliy Makkoveev wrote:
>> I like to have "sizeof(*omi)" in corresponding malloc(9) too.
>>
>> cut begin
>> 827 omi = malloc(sizeof(struct sr_meta_opt_item), M_DEVBU
On Sun, Jul 12, 2020 at 10:31:49PM +0300, Vitaliy Makkoveev wrote:
> I like to have "sizeof(*omi)" in corresponding malloc(9) too.
>
> cut begin
> 827 omi = malloc(sizeof(struct sr_meta_opt_item), M_DEVBUF,
> 828 M_WAITOK | M_ZERO);
> cut end
On Sun, Jul 12, 2020 at 08:51:08PM +0200, Klemens Nanni wrote:
> While omi->omi_som seems variable in size, omi is only ever allocated
> with one size and softraid.c uses the same size for free(9) as well.
>
> Tested with cryto softraid and keydisk.
>
> Feedback? OK?
>
>
> Index: dev/softraid_c
While omi->omi_som seems variable in size, omi is only ever allocated
with one size and softraid.c uses the same size for free(9) as well.
Tested with cryto softraid and keydisk.
Feedback? OK?
Index: dev/softraid_crypto.c
===
RCS f
On Sun, Jul 12, 2020 at 07:44:47PM +0200, Klemens Nanni wrote:
OK mvs@
> Feedback? OK?
>
>
> Index: sys/net/if_wg.c
> ===
> RCS file: /cvs/src/sys/net/if_wg.c,v
> retrieving revision 1.9
> diff -u -p -r1.9 if_wg.c
> --- sys/net/if_
We overallocate by quite a bit for bootable disks; spotted while
reading the code and tested by installboot(8)ing onto vnd(4) backed
softraid disks (after booting a kernel with this diff).
$ egdb --quiet obj/bsd.gdb
Reading symbols from obj/bsd.gdb...done.
(gdb) p sizeof(s
ok zx2c4
> Date: Sun, 12 Jul 2020 19:30:38 +0200
> From: Christian Weisgerber
>
> Mark Kettenis:
>
> > > Date: Sun, 12 Jul 2020 18:12:39 +0200
> > > From: Christian Weisgerber
> > >
> > > The PowerPC/Power ISA Time Base is a 64-bit register. We can use
> > > the full lower 32 bits.
> > >
> > > OK?
>
Mark Kettenis:
> > There is the strong suspicion that the 0x7fff mask in the various
> > armv7 timecounters was simply copied from powerpc, and that these really
> > are full 32-bit counters.
> >
> > I wanted to verify this from the data sheets, but I'm insufficiently
> > familiar with the AR
Feedback? OK?
Index: sys/net/if_wg.c
===
RCS file: /cvs/src/sys/net/if_wg.c,v
retrieving revision 1.9
diff -u -p -r1.9 if_wg.c
--- sys/net/if_wg.c 10 Jul 2020 13:26:42 - 1.9
+++ sys/net/if_wg.c 12 Jul 2020 16:31:03 -
Mark Kettenis:
> > Date: Sun, 12 Jul 2020 18:12:39 +0200
> > From: Christian Weisgerber
> >
> > The PowerPC/Power ISA Time Base is a 64-bit register. We can use
> > the full lower 32 bits.
> >
> > OK?
>
> Sure, but this needs to be coordinated with the userland diff.
No. tc_update_timekeep(
On Fri, Jun 26, 2020 at 07:42:50AM -0700, jo...@armadilloaerospace.com wrote:
> Optimized 32 bit character rendering with unrolled rows and pairwise
> foreground / background pixel rendering.
>
> If it weren't for the 5x8 font, I would have just assumed everything
> was an even width and made the
> Date: Sun, 12 Jul 2020 18:23:09 +0200
> From: Christian Weisgerber
>
> Christian Weisgerber:
>
> > - tb_get_timecount, NULL, 0x7fff, 0, "tb", 0, NULL, 0
> > + tb_get_timecount, NULL, 0x, 0, "tb", 0, NULL, 0
>
> PS: Do we prefer ~0u over 0x?
I prefer 0x. We ty
> Date: Sun, 12 Jul 2020 18:12:39 +0200
> From: Christian Weisgerber
>
> The PowerPC/Power ISA Time Base is a 64-bit register. We can use
> the full lower 32 bits.
>
> OK?
Sure, but this needs to be coordinated with the userland diff. And
we'd better change it quick because doing it later is
> Date: Sun, 12 Jul 2020 18:21:48 +0200
> From: Christian Weisgerber
>
> There is the strong suspicion that the 0x7fff mask in the various
> armv7 timecounters was simply copied from powerpc, and that these really
> are full 32-bit counters.
>
> I wanted to verify this from the data sheets,
Christian Weisgerber:
> - tb_get_timecount, NULL, 0x7fff, 0, "tb", 0, NULL, 0
> + tb_get_timecount, NULL, 0x, 0, "tb", 0, NULL, 0
PS: Do we prefer ~0u over 0x?
--
Christian "naddy" Weisgerber na...@mips.inka.de
There is the strong suspicion that the 0x7fff mask in the various
armv7 timecounters was simply copied from powerpc, and that these really
are full 32-bit counters.
I wanted to verify this from the data sheets, but I'm insufficiently
familiar with the ARM ecosystem to locate those.
Back in Se
The PowerPC/Power ISA Time Base is a 64-bit register. We can use
the full lower 32 bits.
OK?
Index: arch/macppc/macppc/clock.c
===
RCS file: /cvs/src/sys/arch/macppc/macppc/clock.c,v
retrieving revision 1.44
diff -u -p -r1.44 clock.
Florian Obser wrote:
> On Sun, Jul 12, 2020 at 09:10:57AM +0200, Otto Moerbeek wrote:
> > On Sun, Jul 12, 2020 at 09:57:02AM +0430, Ali Farzanrad wrote:
> >
> > > Hi @tech,
> > >
> > > I was comparing jsmn.c in acme-client with jsmn.c in FreeBSD [1].
> > > I found a switch without a default case
On Sun, 12 Jul 2020 09:13:47 +0200
Otto Moerbeek :
> On Mon, Jun 29, 2020 at 02:30:41PM +0200, Otto Moerbeek wrote:
>
> > On Sun, Jun 21, 2020 at 03:35:21PM +0200, Otto Moerbeek wrote:
> >
> > > Hi,
> > >
> > > both phase 1 and phase 5 need cylinder group metadata. This diff
> > > keeps the
While working on the OpenBSD/powerpc64 pmap I noticed that the code we
use for the G5 machines has a bug and doesn't remove execute
permission from mappings when it should.
Since I don't have a G5 machine readily available, can somebody test
this diff for me?
Index: arch/powerpc/powerpc/pmap.c
=
On Sun, Jul 12, 2020 at 11:07:05AM +0200, Solene Rapenne wrote:
> On Sun, 12 Jul 2020 09:13:47 +0200
> Otto Moerbeek :
>
> > On Mon, Jun 29, 2020 at 02:30:41PM +0200, Otto Moerbeek wrote:
> >
> > > On Sun, Jun 21, 2020 at 03:35:21PM +0200, Otto Moerbeek wrote:
> > >
> > > > Hi,
> > > >
> > >
> Date: Sun, 12 Jul 2020 00:06:21 +0200
> From: Christian Weisgerber
>
> Mark Kettenis:
>
> > Nevertheless, here is a different take on the problem. Since the
> > timecounter only uses the low 32 bits we don't need the double read.
> > This version also changes the timecounter mask from 0x7f
On Sun, Jul 12, 2020 at 09:10:57AM +0200, Otto Moerbeek wrote:
> On Sun, Jul 12, 2020 at 09:57:02AM +0430, Ali Farzanrad wrote:
>
> > Hi @tech,
> >
> > I was comparing jsmn.c in acme-client with jsmn.c in FreeBSD [1].
> > I found a switch without a default case which is an undefined behavior:
> >
On Mon, Jun 29, 2020 at 02:30:41PM +0200, Otto Moerbeek wrote:
> On Sun, Jun 21, 2020 at 03:35:21PM +0200, Otto Moerbeek wrote:
>
> > Hi,
> >
> > both phase 1 and phase 5 need cylinder group metadata. This diff
> > keeps the cg data read in phase 1 in memory to be used by phase 5 if
> > possibl
On Sun, Jul 12, 2020 at 09:57:02AM +0430, Ali Farzanrad wrote:
> Hi @tech,
>
> I was comparing jsmn.c in acme-client with jsmn.c in FreeBSD [1].
> I found a switch without a default case which is an undefined behavior:
>
> @@ -69,6 +69,8 @@
> case '\t' : case '\r' : case '\
29 matches
Mail list logo
