unfinished diff to let pcidump print VPD info

2020-06-07 Thread David Gwynne
I was looking for something in a devices VPD info and got this far before finding out it wasn't there. I'm a bit over it now though. PCI VPD stuff is weird because the capability doesn't contain the data itself, it's a register that lets you communicate with whatever is storing the data on the dev

[PATCH] [xenocara] app/xenodm/config/Xsetup_0 - reduce the number of lines

2020-06-07 Thread Raf Czlonka
Hi all, I've been running openbsd-backgrounds on all of my desktop machines and thought this can be simplified a bit: - fewer lines to uncomment - easier to automate, i.e. via one liner, script, config management, etc. - still under 80 columns wide For your consideration. Cheers, Raf Index: a

Re: BIOCINSTALLBOOT/sparc64 installboot: EFBIG on too big boot loaders

2020-06-07 Thread Klemens Nanni
On Sun, Jun 07, 2020 at 03:24:30PM +0200, Klemens Nanni wrote: > On Sun, Jun 07, 2020 at 12:42:57AM +1000, Joel Sing wrote: > > While this works, you would be better off making use of the error > > reporting mechanism that exists. A compile tested only diff for > > the kernel side is below. A diff

Re: biovar.h: Add missing include guard

2020-06-07 Thread Klemens Nanni
On Sun, Jun 07, 2020 at 10:31:31AM -0600, Theo de Raadt wrote: > No. > > "So at minimum, the leading _"... Does "_SYS_DEV_BIOVAR_H_" not contain a leading underscore? What am I missing?

Re: biovar.h: Add missing include guard

2020-06-07 Thread Theo de Raadt
No. "So at minimum, the leading _"... Klemens Nanni wrote: > On Sun, Jun 07, 2020 at 09:58:44AM -0600, Theo de Raadt wrote: > > Bad naming. The correct protection is visible in others in the same > > directory, most of them doing it better. > > > > audio_if.h:#ifndef _SYS_DEV_AUDIO_IF_H_ > >

Re: biovar.h: Add missing include guard

2020-06-07 Thread Klemens Nanni
On Sun, Jun 07, 2020 at 09:58:44AM -0600, Theo de Raadt wrote: > Bad naming. The correct protection is visible in others in the same > directory, most of them doing it better. > > audio_if.h:#ifndef _SYS_DEV_AUDIO_IF_H_ > ipmi.h:#ifndef _IPMI_H_ > ipmivar.h:#ifndef _IPMIVAR_H_ > midi_if.h:#ifndef

Re: biovar.h: Add missing include guard

2020-06-07 Thread Theo de Raadt
Bad naming. The correct protection is visible in others in the same directory, most of them doing it better. audio_if.h:#ifndef _SYS_DEV_AUDIO_IF_H_ ipmi.h:#ifndef _IPMI_H_ ipmivar.h:#ifndef _IPMIVAR_H_ midi_if.h:#ifndef _SYS_DEV_MIDI_IF_H_ midivar.h:#ifndef _SYS_DEV_MIDIVAR_H_ radio_if.h:#ifndef

Re: BIOCINSTALLBOOT/sparc64 installboot: EFBIG on too big boot loaders

2020-06-07 Thread Klemens Nanni
On Sun, Jun 07, 2020 at 12:42:57AM +1000, Joel Sing wrote: > While this works, you would be better off making use of the error > reporting mechanism that exists. A compile tested only diff for > the kernel side is below. A diff to installboot would be needed to > graft some code similar to that in

biovar.h: Add missing include guard

2020-06-07 Thread Klemens Nanni
Building installboot(8) with multiple includes fails without this. OK? Index: dev/biovar.h === RCS file: /cvs/src/sys/dev/biovar.h,v retrieving revision 1.45 diff -u -p -r1.45 biovar.h --- dev/biovar.h14 Aug 2016 04:08:03