Fix comment typo in if_bnx.c

2020-05-16 Thread Delyan Raychev
Pardon the triviality of this diff. I'd like to use this to say Hi, learn the flow, and grow in contributions from here! Thanks! Index: sys/dev/pci/if_bnx.c === RCS file: /cvs/src/sys/dev/pci/if_bnx.c,v retrieving revision 1.126 dif

Re: Code changes for clarity

2020-05-16 Thread Jonathan Gray
On Sat, May 16, 2020 at 12:13:37PM -0700, jo...@armadilloaerospace.com wrote: > (Not sure if this belongs in tech@ or misc@) I think tech@ is fine for discussion of code. > > What is the thinking around non-functional code changes that just > improve clarity without functionality changes? I can

Correcty reloading unresolved host in syslogd @Conf lines

2020-05-16 Thread sven falempin
This was looked at before. Did not get through. --- /usr/src/usr.sbin/syslogd/syslogd.c Wed May 13 19:17:17 2020 +++ ./syslogd.c Mon Feb 10 16:05:59 2020 @@ -2416,6 +2416,7 @@ s = 0; strlcpy(progblock, "*", sizeof(progblock)); strlcpy(hostblock, "*", sizeof(hostblock)); +

Re: 6.7 snaps upgrade went fine - Intel ax200ngw not so much

2020-05-16 Thread sven falempin
On Fri, May 15, 2020 at 11:17 AM Stefan Sperling wrote: > On Fri, May 15, 2020 at 11:11:44AM -0400, sven falempin wrote: > > Index: if_iwx.c > > === > > RCS file: /cvs/src/sys/dev/pci/if_iwx.c,v > > retrieving revision 1.11 > > diff

Re: Elecom mouse patch to recognize all the buttons

2020-05-16 Thread Sivaram Gowkanapalli
Hello, Could anyone with commit privileges please take this patch? It commits without any issues to -current. Thanks From: Sivaram Gowkanapalli Sent: Friday, May 8, 2020 11:24 PM To: tech@openbsd.org Subject: Elecom mouse patch to recognize all the butto

Code changes for clarity

2020-05-16 Thread johnc
(Not sure if this belongs in tech@ or misc@) What is the thinking around non-functional code changes that just improve clarity without functionality changes? I can imagine bad experiences with that, but there is certainly room for improvement. For instance, in the wsdisplay_emulops structure, th

Re: userland clock_gettime proof of concept

2020-05-16 Thread Mark Kettenis
> From: "Theo de Raadt" > Date: Sat, 16 May 2020 11:34:22 -0600 > > Paul Irofti wrote: > > > - the clock quality issue was brought back; afaics the current > > diff does exactly what the syscall is doing and the > > information is updated inside every tc_windup() which makes thi

Re: userland clock_gettime proof of concept

2020-05-16 Thread Theo de Raadt
Mark Kettenis wrote: > [...] And you also need to find a > solution for proper synchronization between userland and the kernel. > Currently they can race eachother in the sense that userland can read > the time at the same time the kernel is updating it. A generation > mechanism like the timeha

Re: userland clock_gettime proof of concept

2020-05-16 Thread Mark Kettenis
> Date: Sat, 16 May 2020 02:40:02 +0300 > From: Paul Irofti > > Here is an updated diff that addresses the following points mentioned by > kettenis@: > > - syscall fallback was implemented from the first version > > - the low resolution clock argument, I think, was shown not to be a > p

ospf6d: remove F_IFACE_AVAIL

2020-05-16 Thread Denis Fondras
This information is never used/checked. Index: kroute.c === RCS file: /cvs/src/usr.sbin/ospf6d/kroute.c,v retrieving revision 1.63 diff -u -p -r1.63 kroute.c --- kroute.c16 May 2020 15:54:12 - 1.63 +++ kroute.c16 May

Re: userland clock_gettime proof of concept

2020-05-16 Thread Theo de Raadt
It seems very wrong that this find_timekeep() function is called 3 times, and EACH TIME it walks the same two arrays, AND I expect bad things to happen if a program messes with it's environment early on, meaning this stops pointing to a place the right place on the stack: > + stackp = (Elf_Add

Re: userland clock_gettime proof of concept

2020-05-16 Thread Theo de Raadt
Paul Irofti wrote: > Here is a third version of the diff. With this robert@ is able to use > chrome with almost all the calls to kernel clock_gettime gone. I > think the number dropped from 600,000 to 400. Robert can give you more > details. But the idea is that it is very fast now. Zoom zoom. B

Re: userland clock_gettime proof of concept

2020-05-16 Thread Robert Nagy
On 16/05/20 20:14 +0300, Paul Irofti wrote: > Make sure you clean your /usr/share/relink directory before compiling > and installing this! Robert's machine was picking up old objects and > creating a broken library on every reboot becuase his directory was not > clean. It was actually an old .so i

Re: userland clock_gettime proof of concept

2020-05-16 Thread Paul Irofti
Here is a third version of the diff. With this robert@ is able to use chrome with almost all the calls to kernel clock_gettime gone. I think the number dropped from 600,000 to 400. Robert can give you more details. But the idea is that it is very fast now. Zoom zoom. The diff includes a temporary

Re: Mention /etc/examples/ in those config files manpages + FILES short description

2020-05-16 Thread Jason McIntyre
On Thu, Apr 30, 2020 at 07:13:16PM +0200, clematis wrote: > Hello, > > Following the previous thread about /etc/examples/doas.conf [1] , > I've noticed those example files aren't always listed in their > respective manpage or without a description. > This has been discussed here recently for bgpd.

Re: iwm(4): re-add CCMP hardware offload support

2020-05-16 Thread Stefan Sperling
On Sat, May 16, 2020 at 05:41:43PM +0200, Stefan Sperling wrote: > On Fri, May 15, 2020 at 05:02:28PM +0200, Stefan Sperling wrote: > > This has been attempted before, but had to backed out because in some > > cases firmware was failing to decrypt a subset of received frames, which > > resulted in

Re: iwm(4): re-add CCMP hardware offload support

2020-05-16 Thread Stefan Sperling
On Fri, May 15, 2020 at 05:02:28PM +0200, Stefan Sperling wrote: > This has been attempted before, but had to backed out because in some > cases firmware was failing to decrypt a subset of received frames, which > resulted in packet loss. > > That was before we updated all iwm(4) devices to newer

Re: ospf6d: remove IMSG_IFDELETE

2020-05-16 Thread Remi Locherer
On Thu, May 14, 2020 at 08:10:55PM +0200, Denis Fondras wrote: > Following https://marc.info/?l=openbsd-tech&m=158946552515632&w=2, when > IMSG_IFADD is removed, IMSG_IFDELETE becomes useless... OK remi@ > > Index: kroute.c > === >

Re: ospf6d: remove IMSG_IFADD

2020-05-16 Thread Remi Locherer
On Thu, May 14, 2020 at 04:10:42PM +0200, Denis Fondras wrote: > IMSG_IFADD is never used, wipe it. In ospfd we have IMSG_RECONF_IFACE for this. Once we start adding reload functionality we can bring that over to ospf6d. OK remi@ > > Index: ospf6d.h > ===

Re: scan_ffs prints negative size

2020-05-16 Thread Otto Moerbeek
On Sat, May 16, 2020 at 02:25:43PM +0200, Denis Fondras wrote: > Small diff to fix size printing. > > Before : > $ doas scan_ffs -v sd0 > block 55167 id 758d4818,f2894c98 size -859043093 > > After: > $ doas ./obj/scan_ffs -v sd0 > block 55167 id 758d4818,f2894c98 size 3435924203 I do not think

scan_ffs prints negative size

2020-05-16 Thread Denis Fondras
Small diff to fix size printing. Before : $ doas scan_ffs -v sd0 block 55167 id 758d4818,f2894c98 size -859043093 After: $ doas ./obj/scan_ffs -v sd0 block 55167 id 758d4818,f2894c98 size 3435924203 Index: scan_ffs.c === RCS file: /

Re: iked(8): AES_GCM ciphers for IKE

2020-05-16 Thread Christian Weisgerber
Tobias Heider: > currently iked(8) supports AES-GCM only for ESP. > The diff below adds the ENCR_AES_GCM_16 and ENCR_AES_GCM_12 variants for IKE. > (for more information see [1] and [2]). > Both variants support the 128, 196, and 256 bit key lengths. > > The new new ciphers can be configured with

Re: iwx: fix phy context command

2020-05-16 Thread Stefan Sperling
On Fri, May 15, 2020 at 02:21:48PM -0400, sven falempin wrote: > OK Fri May 15 13:37:31 EDT 2020 > OK Fri May 15 13:38:10 EDT 2020 > OK Fri May 15 13:38:49 EDT 2020 > OK Fri May 15 13:39:28 EDT 2020 > OK Fri May 15 13:40:07 EDT 2020 > FAILED Fri May 15 13:40:50 EDT 2020 > OK Fri May 15 13:41:29 EDT

Re: iked(8): AES_GCM ciphers for IKE

2020-05-16 Thread Stephan Mending
On Fri, May 15, 2020 at 01:59:35AM +0200, Tobias Heider wrote: > On Thu, May 14, 2020 at 10:47:52PM +0200, Tobias Heider wrote: > > On Thu, May 14, 2020 at 10:07:30PM +0200, Tobias Heider wrote: > > > Hi, > > > > > > currently iked(8) supports AES-GCM only for ESP. > > > The diff below adds the EN

Re: userland clock_gettime proof of concept

2020-05-16 Thread Paul Irofti
> Hopefully this version also fixes the init bug solene@ was seeing. No according to robert@, sorry. I'll look into it more and get back with a fix.