fix pppac(4) without pipex

2020-04-11 Thread YASUOKA Masahiko
Hi, The diff followings fixes panics when using pppac(4) with "pipex no". Index: sys/net/if_pppx.c === RCS file: /cvs/src/sys/net/if_pppx.c,v retrieving revision 1.83 diff -u -p -r1.83 if_pppx.c --- sys/net/if_pppx.c 10 Apr 2020 07

dwiic(4): add gemini lake

2020-04-11 Thread James Hastings
attach dwiic(4) to I2C controllers on intel gemini lake. tested on an acer spin SP111-33. Index: dev/pci/dwiic_pci.c === RCS file: /cvs/src/sys/dev/pci/dwiic_pci.c,v retrieving revision 1.10 diff -u -p -u -r1.10 dwiic_pci.c --- dev/p

Re: __hldtoa broken for ld128

2020-04-11 Thread Christos Zoulas
In article , enh wrote: >this was found by fuzzing the LLVM __cxa_demangle on an ld128 Android >system using hwasan, but it turns out no to simply be a buffer >overflow --- the results are just wrong. (which shows how much anyone >uses ld128 in conjunction with %a!) Thanks a lot for the heads up

brgphy(4) RGMII clock delays

2020-04-11 Thread Mark Kettenis
Apparently when hooking up an Ethernet PHY using an RGMII interface some signals need a to have a small clock delay applied to them. The delays can be applied at various points: by the PHY, by the lengt of the traces on the board or by the MAC. Linux has an explanation her: https://github.com

fix iwn(4) hardware encryption errors

2020-04-11 Thread Stefan Sperling
Since my recent commit to fix Tx reporting in iwn(4) I have observed a continously rising CCMP decryption error counter in 'netstat -W athn0' while running tcpbench from iwn(4) towards an athn(4) hostap. Eventually iwn(4) will send a frame which pushes the CCMP packet number (a nonce used to detec

Use full word for `machine ddbcpu` command in ddb.html

2020-04-11 Thread Mikolaj Kucharski
Hi, I was following this page in the middle of the night and misread `mach` as `match` and it took me a while to realize what I am doing wrong. I think using full word makes it easier to parse and is less likely to make a mistake. Index: ddb.html ==

Re: make patch: prefer standard behavior

2020-04-11 Thread Marc Espie
On Thu, Apr 09, 2020 at 06:33:25PM +0200, Marc Espie wrote: > Our make (bsd make) has "alternate" dependency operators :: and ! > > Twenty years ago, we made it so that ambiguous constructs like > File::Find.3p: File/Find.pm > > would no longer be ambiguous thanks to the added space. > > Now, I

Re: pppx(4): kill pppx_ifs_lk

2020-04-11 Thread Vitaliy Makkoveev
I missed explanation. All the code protected by this rwlock is KERNEL_LOCK()’ed. The context switches which can be caused by memory allocation or NET_LOCK() dances within pppx_add_session() and pppx_if_destroy() are not under acquired pppx_if_lk. So there is no concurrent access to structures it’s

pppx(4): kill pppx_ifs_lk

2020-04-11 Thread Vitaliy Makkoveev
It protects nothing. Index: sys/net/if_pppx.c === RCS file: /cvs/src/sys/net/if_pppx.c,v retrieving revision 1.83 diff -u -p -r1.83 if_pppx.c --- sys/net/if_pppx.c 10 Apr 2020 07:36:52 - 1.83 +++ sys/net/if_pppx.c 11 Apr

Re: pppx(4): kill useless rwlocks

2020-04-11 Thread Vitaliy Makkoveev
Drop this diff please.

Re: ntpd: prevent duplicate definitions of `conf` and `ibus_dns`

2020-04-11 Thread Otto Moerbeek
On Sat, Apr 04, 2020 at 04:00:50PM -0700, Michael Forney wrote: > This prevents a linking error with gcc 10, which enables -fno-common > by default. > > ISO C requires exactly one definition of objects with external > linkage throughout the entire program. > > `conf` is already defined in ntpd.c