Re: find(1) -exec + and ARG_MAX

2020-04-08 Thread Todd C . Miller
On Thu, 09 Apr 2020 03:47:45 +0200, Jeremie Courreges-Anglas wrote: > While having the kernel and userland out of sync is not a good idea, > making find(1) more robust by using sysconf(3) is easy. This is what > xargs(1) already does. OK millert@. - todd

find(1) -exec + and ARG_MAX

2020-04-08 Thread Jeremie Courreges-Anglas
find(1) uses ARG_MAX to compute the maximum space it can pass to execve(2). This doesn't fly if userland and the kernel don't agree, as noticed by some after the recent ARG_MAX bump. --8<-- ritchie /usr/src/usr.bin/find$ obj/find /usr/src/ -type f -exec true {} + find: true: Argument list too l

Re: iked(8): simplify data in sc_sock4 and sc_sock6

2020-04-08 Thread Wataru Ashihara
Hi Tobias, thank you for reviewing! First I correct a mistake I made: "-t" and "-T" were inversed in the table. Let me repost the correct table for those who see this email in future:

Re: smtpd: fix report event format

2020-04-08 Thread gilles
April 8, 2020 11:51 PM, gil...@poolp.org wrote: > April 8, 2020 6:15 PM, "Joerg Jung" wrote: > >>> On 8. Apr 2020, at 17:19, Eric Faurot wrote: >>> >>> Some users had issues with report events for MAIL FROM and RCPT TO >>> when "|" appear in the mail address (yes, it seems to happen), because

Re: smtpd: fix report event format

2020-04-08 Thread gilles
April 8, 2020 6:15 PM, "Joerg Jung" wrote: >> On 8. Apr 2020, at 17:19, Eric Faurot wrote: >> >> Some users had issues with report events for MAIL FROM and RCPT TO >> when "|" appear in the mail address (yes, it seems to happen), because >> that's also the field separator. To make parsing the r

Re: smtpd: fix report event format

2020-04-08 Thread Martijn van Duren
On 4/8/20 6:15 PM, Joerg Jung wrote: > >> On 8. Apr 2020, at 17:19, Eric Faurot wrote: >> >> Some users had issues with report events for MAIL FROM and RCPT TO >> when "|" appear in the mail address (yes, it seems to happen), because >> that's also the field separator. To make parsing the report

Re: smtpd: fix report event format

2020-04-08 Thread Joerg Jung
> On 8. Apr 2020, at 17:19, Eric Faurot wrote: > > Some users had issues with report events for MAIL FROM and RCPT TO > when "|" appear in the mail address (yes, it seems to happen), because > that's also the field separator. To make parsing the report lines a > bit more straightforward, it's

smtpd: fix report event format

2020-04-08 Thread Eric Faurot
Some users had issues with report events for MAIL FROM and RCPT TO when "|" appear in the mail address (yes, it seems to happen), because that's also the field separator. To make parsing the report lines a bit more straightforward, it's better to put the address as the last field. Note that this

pppx(4) remove context switch from pppx_if_find()

2020-04-08 Thread Vitaliy Makkoveev
As mpi@ noticed malloc() with M_WAITOK can cause context switch too. I wish to drop concurency while RBT pppx_ifs is accessed. So, remove malloc() from pppx_if_find(). Looks like original code should do search in the same way, but it didn't. Index: sys/net/if_pppx.c ===

Re: Include /var/www/tmp into base install

2020-04-08 Thread Otto Moerbeek
On Wed, Apr 08, 2020 at 11:08:41AM +0100, Kevin Chadwick wrote: > On 2020-04-07 17:12, Andrew Grillet wrote: > > For me, the "/var is full" problem can be adequately mitigated by mounting > > a separate partition as /var/tmp. > > Does FFS2 have the same disklabel limit on partitions? I guess they

Re: pppx(4): prevent concurency with pppx_if_destroy()

2020-04-08 Thread Vitaliy Makkoveev
On Wed, Apr 08, 2020 at 11:35:06AM +0200, Martin Pieuchot wrote: > On 08/04/20(Wed) 12:11, Vitaliy Makkoveev wrote: > > On Wed, Apr 08, 2020 at 09:51:45AM +0200, Martin Pieuchot wrote: > > [...] > > As I see (pseudo code): > > [...] > > So, I fixed this issue :) > > We fix what we see. Bugs are

Re: Include /var/www/tmp into base install

2020-04-08 Thread Kevin Chadwick
On 2020-04-07 17:12, Andrew Grillet wrote: > For me, the "/var is full" problem can be adequately mitigated by mounting > a separate partition as /var/tmp. Does FFS2 have the same disklabel limit on partitions? I guess they are unrelated. Sometimes users may decide which mount points to edit out

Re: pppx(4): prevent concurency with pppx_if_destroy()

2020-04-08 Thread Martin Pieuchot
On 08/04/20(Wed) 12:11, Vitaliy Makkoveev wrote: > On Wed, Apr 08, 2020 at 09:51:45AM +0200, Martin Pieuchot wrote: > [...] > As I see (pseudo code): > [...] > So, I fixed this issue :) We fix what we see. Bugs are always in the unseen :) This mess is clearly complicated. Mixing 3 different l

Re: pppx(4): prevent concurency with pppx_if_destroy()

2020-04-08 Thread Vitaliy Makkoveev
On Wed, Apr 08, 2020 at 09:51:45AM +0200, Martin Pieuchot wrote: > On 07/04/20(Tue) 19:58, Vitaliy Makkoveev wrote: > > > > > > > On 7 Apr 2020, at 17:43, Martin Pieuchot wrote: > > > > > > On 07/04/20(Tue) 17:14, Vitaliy Makkoveev wrote: > > >> As Claudio Jeker noticed, NET_LOCK() can release

Re: pppx(4): prevent concurency with pppx_if_destroy()

2020-04-08 Thread Martin Pieuchot
On 07/04/20(Tue) 19:58, Vitaliy Makkoveev wrote: > > > > On 7 Apr 2020, at 17:43, Martin Pieuchot wrote: > > > > On 07/04/20(Tue) 17:14, Vitaliy Makkoveev wrote: > >> As Claudio Jeker noticed, NET_LOCK() can release KERNEL_LOCK(). pppx(4) > >> code has some NET_LOCK() dances which make it unsaf

Re: Include /var/www/tmp into base install

2020-04-08 Thread Renaud Allard
On 4/7/20 6:05 PM, Stuart Henderson wrote: fwiw my usual approach is to put /var/www on a separate filesystem .. I do generally create a separate filesystem for /var/www/tmp (and /var/www). But I feel this is the responsibility of whoever installs stuff which will write in this directory t