Re: What have I broken that I can't make release?

2020-04-03 Thread Andrew Hewus Fresh
On Fri, Apr 03, 2020 at 10:24:28AM -0600, Theo de Raadt wrote: > I suspect your /etc/disktab file is broken. Sadly that was not it, but someone else suggested that my /usr/obj was mounted "async" and, as it was mfs, that was true and there's a known bug (from November, so I guess more than a coupl

Re: kdump futex fix

2020-04-03 Thread Philip Guenther
On Fri, 3 Apr 2020, Martin Pieuchot wrote: > Depending on the operation requested futex(2) might return the number of > woken threads or an error. That means the following... > > mpv CALL futex(0xa58935899b0,0x82,1,0,0) > mpv RET futex -1 errno 1 Operation not permitted > > ...is n

Re: EV_SET(2) shadows variable

2020-04-03 Thread Philip Guenther
On Fri, 3 Apr 2020, Martin Pieuchot wrote: > Thanks, here it is, ok? ok guenther@

'pfctl -L state.file' grabs state lock recursively

2020-04-03 Thread Alexandr Nedvedicky
Hello, The issue has been found by Chris Cappuccio. The good news is it can not be triggered by default. To trigger the bug one has to build kernel with 'WITH_PF_LOCK' option. PF_STATE_ENTER_WRITE(), which is no-op by default, becomes operational, when WITH_PF_LOCK is defined. the 'pfctl -L state

pf_state_key_link_reverse() needs atomic ops -- resending

2020-04-03 Thread Alexandr Nedvedicky
Hello, my apologize to resend the same diff [1]. I'm not sure I got OK or not. It can be the case the privately received OK got lost. The change is required to allow multiple instances of pf_test() running concurrently. Without this change in, PF trips 'KASSERT(sk->reverse == NULL);' thanks and

kdump futex fix

2020-04-03 Thread Martin Pieuchot
Depending on the operation requested futex(2) might return the number of woken threads or an error. That means the following... mpv CALL futex(0xa58935899b0,0x82,1,0,0) mpv RET futex -1 errno 1 Operation not permitted ...is not an error but it indicates that 1 thread has been awoken

Re: What have I broken that I can't make release?

2020-04-03 Thread Theo de Raadt
I suspect your /etc/disktab file is broken.

Constify pledgenames[]

2020-04-03 Thread Visa Hankala
This diff makes pledgenames[] const. OK? Index: sys/kern/kern_pledge.c === RCS file: src/sys/kern/kern_pledge.c,v retrieving revision 1.261 diff -u -p -r1.261 kern_pledge.c --- sys/kern/kern_pledge.c 15 Feb 2020 09:35:48 -

What have I broken that I can't make release?

2020-04-03 Thread Andrew Hewus Fresh
On my amd64 build machine, "a while ago" which is at least a month probably two, I stopped being able to make a release, I don't recall changing anything and I've re-read release(8), upgraded to a few new snapshots with sysupgrade, wiped out /usr/src and checked out a new one, cleared /usr/dest and

Re: iked(8): boolify

2020-04-03 Thread Wataru Ashihara
Hi, thank you for sharing your thoughts, Tobias. On 2020/04/03 21:31 Tobias Heider wrote: > On Fri, Apr 03, 2020 at 12:52:24AM +0900, Wataru Ashihara wrote: > > It would save our time of thinking and reading the source (i.e. > > eliminate the process of "what if the variable 'mobike' was 2 or mo

Re: [patch] mandoc: Remove argument names from function prototypes

2020-04-03 Thread Martin Vahlensieck
Hi Ingo On Fri, Apr 03, 2020 at 01:55:56PM +0200, Ingo Schwarze wrote: > Hi Martin, > > Martin Vahlensieck wrote on Thu, Apr 02, 2020 at 10:57:04AM +0200: > > > I think these are superfluous. > > Correct, and it is irritating to have a general style of not using > argument names in prototypes i

Re: iked(8): boolify

2020-04-03 Thread Tobias Heider
On Fri, Apr 03, 2020 at 12:52:24AM +0900, Wataru Ashihara wrote: > It would save our time of thinking and reading the source (i.e. > eliminate the process of "what if the variable 'mobike' was 2 or more? > ...aha it's just a bool"). > > This is still work in progress. I would continue if you maint

Re: Fix occasional signify regression test fail

2020-04-03 Thread Alexander Bluhm
On Thu, Apr 02, 2020 at 08:03:33AM +, Christian Ludwig wrote: > The signify regression test creates a tar archive from the test's > directory. Without a symlink to the obj directory, the output tarball is > part of the input file list. This makes tar complain that archive.tgz > was modified dur

Re: [patch] mandoc: Remove argument names from function prototypes

2020-04-03 Thread Ingo Schwarze
Hi Martin, Martin Vahlensieck wrote on Thu, Apr 02, 2020 at 10:57:04AM +0200: > I think these are superfluous. Correct, and it is irritating to have a general style of not using argument names in prototypes in mandoc, but then a few scattered names here and there, so i committed your patch. Than

Re: Fix pipex(4) pipex_ioctl() access to not owned sessions (kernel crash too)

2020-04-03 Thread Vitaliy Makkoveev
On Fri, Apr 03, 2020 at 11:07:48AM +0200, Martin Pieuchot wrote: > On 02/04/20(Thu) 13:44, Vitaliy Makkoveev wrote: > > pipex(4) has pipex_ioctl() interface for pipex_session related routines. > > pipex_ioctl() calls should be done with pipex_iface_contex, so any > > operations should be done with

Re: Kill cdev_mousewr_init()

2020-04-03 Thread Jonathan Gray
On Fri, Apr 03, 2020 at 10:56:32AM +0200, Martin Pieuchot wrote: > Unused macro, found while auditing d_poll() functions, ok? ok jsg@ > > Index: sys/conf.h > === > RCS file: /cvs/src/sys/sys/conf.h,v > retrieving revision 1.148 > di

Re: Kill cdev_mousewr_init()

2020-04-03 Thread Jeremie Courreges-Anglas
On Fri, Apr 03 2020, Martin Pieuchot wrote: > Unused macro, found while auditing d_poll() functions, ok? ok > Index: sys/conf.h > === > RCS file: /cvs/src/sys/sys/conf.h,v > retrieving revision 1.148 > diff -u -p -r1.148 conf.h > --

Re: Fix pipex(4) pipex_ioctl() access to not owned sessions (kernel crash too)

2020-04-03 Thread Martin Pieuchot
On 02/04/20(Thu) 13:44, Vitaliy Makkoveev wrote: > pipex(4) has pipex_ioctl() interface for pipex_session related routines. > pipex_ioctl() calls should be done with pipex_iface_contex, so any > operations should be done with pipex_sessions owned by passed > pipex_iface_contex. pipex_session check

Kill cdev_mousewr_init()

2020-04-03 Thread Martin Pieuchot
Unused macro, found while auditing d_poll() functions, ok? Index: sys/conf.h === RCS file: /cvs/src/sys/sys/conf.h,v retrieving revision 1.148 diff -u -p -r1.148 conf.h --- sys/conf.h 22 Jan 2020 23:06:05 - 1.148 +++ sys/con

Re: pipex(4) man page fix

2020-04-03 Thread Vitaliy Makkoveev
On Thu, Apr 02, 2020 at 05:06:30PM +0100, Iain R. Learmonth wrote: > Hi, > > On 02/04/2020 12:47, Vitaliy Makkoveev wrote: > > +.Xr pppax 4 , > > I guess you meant pppac here. > > Thanks, > Iain. > Thanks! Index: share/man/man4/pipex.4 ===

Re: EV_SET(2) shadows variable

2020-04-03 Thread Martin Pieuchot
On 02/04/20(Thu) 13:36, Philip Guenther wrote: > On Tue, Mar 31, 2020 at 11:24 PM Martin Pieuchot wrote: > > > The current form of EV_SET(2) declares a `kevp' variable. This can > > cause to subtle bugs hard to discover if one uses a variable of the > > same to retrieve events. > > > > Diff belo

Re: d_poll() inconsistencies

2020-04-03 Thread Martin Pieuchot
On 02/04/20(Thu) 20:25, Mark Kettenis wrote: > > Date: Thu, 2 Apr 2020 20:12:08 +0200 > > From: Martin Pieuchot > > Content-Type: text/plain; charset=utf-8 > > > > While reviewing the all current .d_poll() functions I found those two > > which are incoherent with the rest. > > > > - Most of the