Re: slaacd(8) improve movement between IPv6 & legacy-IP-only networks

2020-01-09 Thread Florian Obser
Hi Fernando, On Thu, Jan 09, 2020 at 08:49:15AM -0300, Fernando Gont wrote: > Hi, Pamela, > > On 27/8/19 15:31, Pamela Mosiejczuk wrote: > > Hi all, > > > > When slaacd(8) detects a link-state change, it sets the preferred > > lifetime (pltime) of all configured addresses to zero and tries to >

Re: man.cgi(8): turn off HTML5 autocomplete for the query input field

2020-01-09 Thread Landry Breuil
On Thu, Jan 09, 2020 at 09:18:25PM -0600, Tim Baumgard wrote: > This turns off HTML5 autocomplete for the query input field for > man.cgi(8). This essentially makes smartphones and tablets behave the > same as PCs since they otherwise would try to annoyingly capitalize the > first character and cha

Re: xlights(4): timeout_add(9) -> timeout_add_msec(9)

2020-01-09 Thread Jonathan Gray
On Wed, Dec 18, 2019 at 08:47:54PM -0600, Scott Cheloha wrote: > 250 ticks at macppc's 100hz is 2500 milliseconds. > > ok? ok jsg@ > > Index: xlights.c > === > RCS file: /cvs/src/sys/arch/macppc/dev/xlights.c,v > retrieving revisio

Re: pluart(4): timeout_add(9) -> timeout_add_sec(9)

2020-01-09 Thread Scott Cheloha
On Fri, Jan 10, 2020 at 02:57:41PM +1100, Jonathan Gray wrote: > On Sun, Dec 22, 2019 at 03:35:09PM -0600, Scott Cheloha wrote: > > ok? > > > > Index: pluart.c > > === > > RCS file: /cvs/src/sys/dev/ic/pluart.c,v > > retrieving revisi

ubsec(4): timeout_add(9) -> timeout_add_msec(9)

2020-01-09 Thread Scott Cheloha
The intent here is to poll no faster than 100 times a second, so change sc_rnghz to sc_rngms and set it to 10 milliseconds, then call timeout_add_msec() instead of timeout_add(). ok? Index: ubsec.c === RCS file: /cvs/src/sys/dev/pci/

Re: pluart(4): timeout_add(9) -> timeout_add_sec(9)

2020-01-09 Thread Jonathan Gray
On Sun, Dec 22, 2019 at 03:35:09PM -0600, Scott Cheloha wrote: > ok? > > Index: pluart.c > === > RCS file: /cvs/src/sys/dev/ic/pluart.c,v > retrieving revision 1.4 > diff -u -p -r1.4 pluart.c > --- pluart.c 11 Aug 2019 10:03:32 -

Re: pluart(4): timeout_add(9) -> timeout_add_sec(9)

2020-01-09 Thread Scott Cheloha
On Sun, Dec 22, 2019 at 03:35:09PM -0600, Scott Cheloha wrote: > ok? Bump. > Index: pluart.c > === > RCS file: /cvs/src/sys/dev/ic/pluart.c,v > retrieving revision 1.4 > diff -u -p -r1.4 pluart.c > --- pluart.c 11 Aug 2019 10:03:32

Re: xlights(4): timeout_add(9) -> timeout_add_msec(9)

2020-01-09 Thread Scott Cheloha
On Wed, Dec 18, 2019 at 08:47:54PM -0600, Scott Cheloha wrote: > 250 ticks at macppc's 100hz is 2500 milliseconds. > > ok? Bump. > Index: xlights.c > === > RCS file: /cvs/src/sys/arch/macppc/dev/xlights.c,v > retrieving revision 1.9

Re: fd(4): tsleep(9) -> tsleep_nsec(9), timeout_add(9) -> timeout_add_msec(9)

2020-01-09 Thread Scott Cheloha
On Tue, Jan 07, 2020 at 08:03:27AM -, Miod Vallat wrote: > > > Convert ticks to milliseconds. > > > > The 33 milliseconds in the timeout_add_msec(9) call will be truncated > > to 3 ticks, but that was already the case with the current (hz / 30) > > code so this is no worse. > > [...] > > >

man.cgi(8): turn off HTML5 autocomplete for the query input field

2020-01-09 Thread Tim Baumgard
This turns off HTML5 autocomplete for the query input field for man.cgi(8). This essentially makes smartphones and tablets behave the same as PCs since they otherwise would try to annoyingly capitalize the first character and change things like "mandoc" to "man doctor." Tim Index: cgi.c

Re: dangling vnode panic

2020-01-09 Thread Todd C . Miller
On Thu, 09 Jan 2020 23:03:37 +0100, Alexander Bluhm wrote: > That is why I have to keep the list alive while flushing it out. > So I came to the TAILQ solution. It seems like the best solution right now. > > The alternative would be to add another loop around the list processing. I > > think tha

Re: dangling vnode panic

2020-01-09 Thread Alexander Bluhm
On Thu, Jan 09, 2020 at 01:22:21PM -0500, Ted Unangst wrote: > Martin Pieuchot wrote: > > On 09/01/20(Thu) 10:46, Alexander Bluhm wrote: > > > Without this diff my regress machines became so unstable, that they > > > often do not finish the test run. > > > > > > With this diff, they run fine. No r

Re: small bgpd performance improvement

2020-01-09 Thread Sebastian Benoit
nice, ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.01.09 16:25:58 +0100: > The path_hash function is called reasonably often. Calling > SipHash24_Update() over and over for small data is not optimal. > Inspired by /sys/sys/proc.h add a aspath_hashstart and aspath_hashend to > the struct rde_

Re: bgpd sofreconfigure and export default

2020-01-09 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.01.09 16:05:06 +0100: > When using 'export default-route' you still need an output filter to allow > the default route out. I'm probably not the only one forgetting this fact > from time to time. Now to make things worse adding the filter rule to > al

Re: ldomctl: Fail on incomplete domain parameters

2020-01-09 Thread Mark Kettenis
> Date: Thu, 9 Jan 2020 21:53:09 +0100 > From: Klemens Nanni > > Each guest needs vcpu and memory, otherwise it's invalid. > Each guest also needs at least one of vdisk, vnet or iodevice, otherwise > it has nothing to boot from. > > Consider this example: > > # cat foo.conf > domain

ldomctl: Fail on incomplete domain parameters

2020-01-09 Thread Klemens Nanni
Each guest needs vcpu and memory, otherwise it's invalid. Each guest also needs at least one of vdisk, vnet or iodevice, otherwise it has nothing to boot from. Consider this example: # cat foo.conf domain no-boot { vcpu 1 memory 32G }

Re: dangling vnode panic

2020-01-09 Thread Ted Unangst
Martin Pieuchot wrote: > On 09/01/20(Thu) 10:46, Alexander Bluhm wrote: > > Without this diff my regress machines became so unstable, that they > > often do not finish the test run. > > > > With this diff, they run fine. No regressions. > > Sadly this is a workaround. What is the issue? We're

small bgpd performance improvement

2020-01-09 Thread Claudio Jeker
The path_hash function is called reasonably often. Calling SipHash24_Update() over and over for small data is not optimal. Inspired by /sys/sys/proc.h add a aspath_hashstart and aspath_hashend to the struct rde_aspath and use that for the hash. -- :wq Claudio Index: rde.h ===

bgpd sofreconfigure and export default

2020-01-09 Thread Claudio Jeker
When using 'export default-route' you still need an output filter to allow the default route out. I'm probably not the only one forgetting this fact from time to time. Now to make things worse adding the filter rule to allow the route plus config reload does not work since the softreconfigure code

Re: dangling vnode panic

2020-01-09 Thread Martin Pieuchot
On 09/01/20(Thu) 10:46, Alexander Bluhm wrote: > Without this diff my regress machines became so unstable, that they > often do not finish the test run. > > With this diff, they run fine. No regressions. Sadly this is a workaround. What is the issue? We're missing a barrier during umount? How

bgpd, remove getifaddrs call in RDE

2020-01-09 Thread Claudio Jeker
The RDE needs to know the local v4 and v6 address of a session so that nexthop self works. Until now the lookup for the other AF address was done in the RDE when the session got established. This diff moves this code over to the SE where it fits better. Especially this allows to remove the route pl

Re: slaacd(8) improve movement between IPv6 & legacy-IP-only networks

2020-01-09 Thread Fernando Gont
Hi, Pamela, On 27/8/19 15:31, Pamela Mosiejczuk wrote: > Hi all, > > When slaacd(8) detects a link-state change, it sets the preferred > lifetime (pltime) of all configured addresses to zero and tries to > obtain a new router advertisement. > > If none is received after some time, slaacd will gi

Re: amd64 SMEP SMAP trap panic print

2020-01-09 Thread Mark Kettenis
> Date: Thu, 9 Jan 2020 14:01:32 +0100 > From: Alexander Bluhm > > On Thu, Jan 09, 2020 at 12:01:07PM +0100, Mark Kettenis wrote: > > By splitting this out, the "retain the kernel lock" bit of the > > comment doesn't make a lot of sense anymore... > > Then move the comment to the return where we

Re: amd64 SMEP SMAP trap panic print

2020-01-09 Thread Alexander Bluhm
On Thu, Jan 09, 2020 at 12:01:07PM +0100, Mark Kettenis wrote: > By splitting this out, the "retain the kernel lock" bit of the > comment doesn't make a lot of sense anymore... Then move the comment to the return where we retain it. bluhm Index: arch/amd64/amd64/db_trace.c ==

Re: bgpd, move peer related functions to rde_peer.c

2020-01-09 Thread Sebastian Benoit
ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.01.09 13:03:13 +0100: > On Thu, Jan 09, 2020 at 09:42:39AM +0100, Claudio Jeker wrote: > > This diff just moves some of the code from rde.c to rde_peer.c where it > > should be. Apart from moving the code peer_down() was modified so that it > >

MAKE: redux patch

2020-01-09 Thread Marc Espie
So my development branch is getting a bit too far ahead compared to what's committed. Here's a big diff to test. Comments as to what's going on and the changes this contains: - buffer changes: add support for "permanent static buffers" that don't get reinit'd all the time (that's a mostly trivia

Re: bgpd, move peer related functions to rde_peer.c

2020-01-09 Thread Claudio Jeker
On Thu, Jan 09, 2020 at 09:42:39AM +0100, Claudio Jeker wrote: > This diff just moves some of the code from rde.c to rde_peer.c where it > should be. Apart from moving the code peer_down() was modified so that it > can be used as callback of peer_foreach(). Also peer_foreach() was changed > to just

Re: amd64 SMEP SMAP trap panic print

2020-01-09 Thread Mark Kettenis
> Date: Thu, 9 Jan 2020 10:42:55 +0100 > From: Alexander Bluhm > > On Thu, Dec 26, 2019 at 08:12:50PM +0100, Alexander Bluhm wrote: > > Any more concerns or can this be commited? > > Any ok? > > > Index: arch/amd64/amd64/db_trace.c > > ===

Re: bgpd and time stamps

2020-01-09 Thread Denis Fondras
On Tue, Dec 31, 2019 at 04:32:24PM +0100, Claudio Jeker wrote: > This changes bgpd to only use CLOCK_MONOTONIC via the getmonotime() > function. Additionally it changes the export of RIB entries to report the > last modified time relative to now. Other places also needed some fixup, > like the mrt

Re: dangling vnode panic

2020-01-09 Thread Alexander Bluhm
Without this diff my regress machines became so unstable, that they often do not finish the test run. With this diff, they run fine. No regressions. Any ok? bluhm On Sat, Jan 04, 2020 at 10:55:46PM +0100, Alexander Bluhm wrote: > On my amd64 test machine regress/sys/kern/mount run-regress-unmo

Re: amd64 SMEP SMAP trap panic print

2020-01-09 Thread Alexander Bluhm
On Thu, Dec 26, 2019 at 08:12:50PM +0100, Alexander Bluhm wrote: > Any more concerns or can this be commited? Any ok? > Index: arch/amd64/amd64/db_trace.c > === > RCS file: /data/mirror/openbsd/cvs/src/sys/arch/amd64/amd64/db_trace.c

bgpd, move peer related functions to rde_peer.c

2020-01-09 Thread Claudio Jeker
This diff just moves some of the code from rde.c to rde_peer.c where it should be. Apart from moving the code peer_down() was modified so that it can be used as callback of peer_foreach(). Also peer_foreach() was changed to just walk the peer list instead of traversing the peer hash table. OK? --