Re: mpii: attach Flash Accelerator F80 800G eMLC

2019-12-27 Thread Theo de Raadt
Jonathan Matthew wrote: > On Sat, Dec 28, 2019 at 03:23:51AM +0100, Klemens Nanni wrote: > > On Sat, Dec 28, 2019 at 01:14:17PM +1100, Jonathan Gray wrote: > > > drop the _PCIE and just have > > > > > > product SYMBIOS SSS6200 > > Sure enough. I added it in analogy to other devices. What is th

Re: mpii: attach Flash Accelerator F80 800G eMLC

2019-12-27 Thread Jonathan Matthew
On Sat, Dec 28, 2019 at 03:23:51AM +0100, Klemens Nanni wrote: > On Sat, Dec 28, 2019 at 01:14:17PM +1100, Jonathan Gray wrote: > > drop the _PCIE and just have > > > > product SYMBIOS SSS6200 > Sure enough. I added it in analogy to other devices. What is the rule > here for such suffix? Only w

Re: mpii: attach Flash Accelerator F80 800G eMLC

2019-12-27 Thread Klemens Nanni
On Sat, Dec 28, 2019 at 01:14:17PM +1100, Jonathan Gray wrote: > drop the _PCIE and just have > > product SYMBIOS SSS6200 Sure enough. I added it in analogy to other devices. What is the rule here for such suffix? Only when the same product/chip is available as PCI *and* PCIE model or so? Ind

Re: mpii: attach Flash Accelerator F80 800G eMLC

2019-12-27 Thread Jonathan Gray
On Sat, Dec 28, 2019 at 02:35:39AM +0100, Klemens Nanni wrote: > On Sat, Dec 28, 2019 at 11:10:28AM +1000, Jonathan Matthew wrote: > > It'd be better to use the LSI chip name for this, which is SSS6200. There > > are > > other devices with different flash configurations using the same > > vendor

Re: mpii: attach Flash Accelerator F80 800G eMLC

2019-12-27 Thread Klemens Nanni
On Sat, Dec 28, 2019 at 11:10:28AM +1000, Jonathan Matthew wrote: > It'd be better to use the LSI chip name for this, which is SSS6200. There are > other devices with different flash configurations using the same > vendor/product > ID. Searching ebay for 'lsi nytro' or 'lsi sss6200' will find a

Re: mpii: attach Flash Accelerator F80 800G eMLC

2019-12-27 Thread Jonathan Matthew
On Fri, Dec 27, 2019 at 05:54:56PM -0700, Theo de Raadt wrote: > > +product SYMBIOS F80_PCIE 0x007e Flash Accelerator F80 800GB eMLC > > Please keep it short, these strings land in every kernel. > > F80 eMLC > > That is probably enough, on top of SYMBIOS vendorID. It'd be better to use t

Re: mpii: attach Flash Accelerator F80 800G eMLC

2019-12-27 Thread Klemens Nanni
On Fri, Dec 27, 2019 at 05:54:56PM -0700, Theo de Raadt wrote: > Please keep it short, these strings land in every kernel. > > F80 eMLC > > That is probably enough, on top of SYMBIOS vendorID. Sure, OK like that or should the define's "_PCIE" suffix go as well? Index: mpii.c

Re: mpii: attach Flash Accelerator F80 800G eMLC

2019-12-27 Thread Theo de Raadt
> +product SYMBIOS F80_PCIE 0x007e Flash Accelerator F80 800GB eMLC Please keep it short, these strings land in every kernel. F80 eMLC That is probably enough, on top of SYMBIOS vendorID.

mpii: attach Flash Accelerator F80 800G eMLC

2019-12-27 Thread Klemens Nanni
vendor "Symbios Logic", unknown product 0x007e (class mass storage subclass SAS, rev 0x03) at pci19 dev 0 function 0 not configured Such devices can be found on SPARC T4 machines, they are eMLC flash accelerator cards. After looking into mpii(4) and jmatthew guessing that attaching them

Re: ospf6d: refactor link state ack/req

2019-12-27 Thread Remi Locherer
On Tue, Dec 24, 2019 at 10:02:37PM +0100, Denis Fondras wrote: > Refactor link state ack/req in ospf6d so it looks closer to ospfd. ok remi@ > Index: lsack.c > === > RCS file: /cvs/src/usr.sbin/ospf6d/lsack.c,v > retrieving revision

Re: sparc64: find root device on hardware RAID

2019-12-27 Thread Klemens Nanni
On Fri, Dec 27, 2019 at 09:46:56AM +0100, Mike Belopuhov wrote: > Looks like WWID for the RAID volume can be read from the RAID Volume > Page 1 (mpii_cfg_raid_vol_pg1). jmatthew also suggested that, thanks. I'm looking into now mpii(4) and already had a rather naive attempt at setting the SCSI tar

Re: ifconfig: fix maximum SSID length with WPA

2019-12-27 Thread Stefan Sperling
On Fri, Dec 27, 2019 at 08:42:20AM -0500, sven falempin wrote: > +1 on max Len , keep \0, use length - 1 for sum. SSIDs are not strings.

Re: ifconfig: fix maximum SSID length with WPA

2019-12-27 Thread sven falempin
+1 on max Len , keep \0, use length - 1 for sum. IMHO. Happy holidays all. On Fri, Dec 27, 2019 at 7:39 AM Claudio Jeker wrote: > On Fri, Dec 27, 2019 at 01:12:42PM +0100, Stefan Sperling wrote: > > If an SSID uses the maximum allowed length, ifconfig overwrites > > the last byte with \0 when

Re: ifconfig: fix maximum SSID length with WPA

2019-12-27 Thread Claudio Jeker
On Fri, Dec 27, 2019 at 01:12:42PM +0100, Stefan Sperling wrote: > If an SSID uses the maximum allowed length, ifconfig overwrites > the last byte with \0 when hashing the WPA key. > This leads to a wrong WPA key being installed in the kernel: > > iwm0: SCAN -> AUTH > iwm0: sending auth to xx:xx:x

ifconfig: fix maximum SSID length with WPA

2019-12-27 Thread Stefan Sperling
If an SSID uses the maximum allowed length, ifconfig overwrites the last byte with \0 when hashing the WPA key. This leads to a wrong WPA key being installed in the kernel: iwm0: SCAN -> AUTH iwm0: sending auth to xx:xx:xx:xx:xx:xx on channel 1 mode 11g iwm0: AUTH -> ASSOC iwm0: sending assoc_req

Re: sparc64: find root device on hardware RAID

2019-12-27 Thread Mike Belopuhov
Klemens Nanni writes: > On Thu, Dec 26, 2019 at 07:49:06PM +0100, Mark Kettenis wrote: >> Well, there's your problem. The mpii(4) doesn't fill in the WWNs for >> the logical volume so there is nothing that can be matched to the WWN >> from the bootpath. > Obvious now that you mention it. > >> >