Re: sparc64: iommu: unbreak DEBUG build: %lx and time_t

On Mon, Dec 23, 2019 at 04:33:04PM -0800, Philip Guenther wrote: > On Mon, Dec 23, 2019 at 12:42 PM Klemens Nanni wrote: > > > `option DEBUG' builds are broken on sparc64, here's the first step in > > fixing it. > > > > /sys/arch/sparc64/dev/iommu.c: In function 'iommu_strbuf_flush_done': > > /sy

Re: sparc64: iommu: unbreak DEBUG build: %lx and time_t

On Mon, Dec 23, 2019 at 12:42 PM Klemens Nanni wrote: > `option DEBUG' builds are broken on sparc64, here's the first step in > fixing it. > > /sys/arch/sparc64/dev/iommu.c: In function 'iommu_strbuf_flush_done': > /sys/arch/sparc64/dev/iommu.c:582: warning: format '%lx' expects type > 'long unsi

Re: dmesg alloc

On Mon, 23 Dec 2019, Alexander Bluhm wrote: > dmesg(8) allocates a bit too much memory. > > sysctl KERN_MSGBUFSIZE returns msg_bufs. > sysctl KERN_MSGBUF copies out msg_bufs + offsetof(struct msgbuf, > msg_bufc) bytes. > dmesg allocates msg_bufs + sizeof(struct msgbuf) - 1 bytes. > > This is not

dmesg alloc

Hi, dmesg(8) allocates a bit too much memory. sysctl KERN_MSGBUFSIZE returns msg_bufs. sysctl KERN_MSGBUF copies out msg_bufs + offsetof(struct msgbuf, msg_bufc) bytes. dmesg allocates msg_bufs + sizeof(struct msgbuf) - 1 bytes. This is not the same value as struct msgbuf is padded. struct msgbu

ospf6d: type p2p

Hi, this brings support for interface "type p2p" to ospf6d (ospfd got it a few weeks ago). The configuration looks like this: area 0.0.0.0 { interface em0 { type p2p } } OK? Remi Index: ospf6d.conf.5

consbuf cleanup

Hi, The console buffer is allocated during startup. initconsbuf() is only called from main(). There allocation must not fail, better use M_WAITOK and remove error handling. It is not a temporary buffer, M_TTYS looks more appropriate. KERN_CONSBUF has no name and result in strange ktrace output

sparc64: iommu: unbreak DEBUG build: use %lx not %llx for bus_{addr,size}_t

The last diff to fix the build: /sys/arch/sparc64/dev/iommu.c:1389: warning: format '%llx' expects type 'long long unsigned int', but argument 2 has type 'bus_addr_t' /sys/arch/sparc64/dev/iommu.c:1394: warning: format '%llx' expects type 'long long unsigned int', but argument 2 has type 'bus_si

sparc64: iommu: unbreak DEBUG build: do not use undefined pa

Another `option DEBUG' fix for /sys/arch/sparc64/dev/iommu.c: In function 'iommu_dvmamap_insert': /sys/arch/sparc64/dev/iommu.c:1136: error: 'pa' undeclared (first use in this function) /sys/arch/sparc64/dev/iommu.c:1136: error: (Each undeclared identifier is reported only once /sys/arch/sparc64

Re: sparc64: iommu: unbreak DEBUG build: use %x not %lx with int

On Mon, Dec 23, 2019 at 09:43:20PM +0100, Klemens Nanni wrote: > Second fix for `option DEBUG': len, seg_len and left are all of type int. Jumping the gun: seg_len is bus_size_t, only len and left are int.

sparc64: iommu: unbreak DEBUG build: use %x not %lx with int

Second fix for `option DEBUG': len, seg_len and left are all of type int. /sys/arch/sparc64/dev/iommu.c: In function 'iommu_dvmamap_load_raw': /sys/arch/sparc64/dev/iommu.c:1063: warning: format '%ld' expects type 'long int', but argument 5 has type 'int' /sys/arch/sparc64/dev/iommu.c:1063: warni

sparc64: iommu: unbreak DEBUG build: %lx and time_t

`option DEBUG' builds are broken on sparc64, here's the first step in fixing it. /sys/arch/sparc64/dev/iommu.c: In function 'iommu_strbuf_flush_done': /sys/arch/sparc64/dev/iommu.c:582: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'time_t' /sys/arch/sparc64/dev/

wbsd(4): timeout_add(9) -> timeout_add_msec(9)

hz/4 -> 250ms. ok? Index: w83l518d_sdmmc.c === RCS file: /cvs/src/sys/dev/ic/w83l518d_sdmmc.c,v retrieving revision 1.4 diff -u -p -r1.4 w83l518d_sdmmc.c --- w83l518d_sdmmc.c5 May 2016 11:01:08 - 1.4 +++ w83l518d_sdmmc.

hppa: heartbeat: timeout_add(9) -> timeout_add_usec(9)

1/16 seconds is exactly 62500 microseconds. ok? Index: arch/hppa/hppa/autoconf.c === RCS file: /cvs/src/sys/arch/hppa/hppa/autoconf.c,v retrieving revision 1.62 diff -u -p -r1.62 autoconf.c --- arch/hppa/hppa/autoconf.c 27 Jan 2018

Re: ospf6d: add basic regress tests

On Mon, Dec 23, 2019 at 03:53:23PM +0100, Claudio Jeker wrote: > On Mon, Dec 23, 2019 at 03:24:31PM +0100, Remi Locherer wrote: > > On Sun, Dec 22, 2019 at 08:36:41PM +0100, Denis Fondras wrote: > > > Add basic regress test to ospf6d. > > > > Works for me. OK remi@ > > > > The tests also succeed

Re: ospf6d: add basic regress tests

On Mon, Dec 23, 2019 at 03:24:31PM +0100, Remi Locherer wrote: > On Sun, Dec 22, 2019 at 08:36:41PM +0100, Denis Fondras wrote: > > Add basic regress test to ospf6d. > > Works for me. OK remi@ > > The tests also succeed when I reduce the sleep from 120 to 60. > A few lines end with a space. I mar

Re: ospf6d: add basic regress tests

On Sun, Dec 22, 2019 at 08:36:41PM +0100, Denis Fondras wrote: > Add basic regress test to ospf6d. Works for me. OK remi@ The tests also succeed when I reduce the sleep from 120 to 60. A few lines end with a space. I marked them below. Remi > > Index: ospf6d/Makefile >

Re: attention please: host's IP stack behavior got changed slightly

On Mon, Dec 23, 2019 at 12:10:36AM +0100, Alexandr Nedvedicky wrote: > diff --git a/sys/netinet/ip_input.c b/sys/netinet/ip_input.c > index 058b2f038fa..f4114f45045 100644 > --- a/sys/netinet/ip_input.c > +++ b/sys/netinet/ip_input.c > @@ -753,7 +753,8 @@ in_ouraddr(struct mbuf *m, struct ifnet *if

Re: ospf6d: warn when a neighbor changes its source address

On Sun, Dec 22, 2019 at 10:32:12PM +0100, Denis Fondras wrote: > On Sun, Dec 22, 2019 at 10:06:40PM +0100, Remi Locherer wrote: > > this is similar to ospfd's hello.c rev 1.23. > > > > OK? > > > > Remi > > > > > > Index: hello.c > > ==