Re: sysupgrade: Allow to use another directory for the sets

2019-11-20 Thread Renaud Allard
On 11/20/19 12:06 PM, Solene Rapenne wrote: On Tue, Nov 12, 2019 at 07:02:56PM +0100, Renaud Allard wrote: On 12/11/2019 08:29, Theo de Raadt wrote: Renaud, please test it for me like this: sysupgrade -d / This interface is dangerously incorrect. What about this one? Index:

Re: XHCI support for bulk xfers >64k

2019-11-20 Thread sc . dying
Hi, On 2019/11/18 20:34, Marcus Glocker wrote: > On Sun, Nov 17, 2019 at 12:36:49PM +0100, Marcus Glocker wrote: > >> While recently testing UDL on XHCI I faced a lot of USB timeouts, and >> therefore screen rendering issues. >> The reason is that XHCI currently only supports single bulk transfer

Re: un-boolean_t ANSIfy ddb(4) for hppa & sparc64

2019-11-20 Thread Andras Farkas
On Wed, Nov 20, 2019 at 9:38 AM Theo de Raadt wrote: > Kernel environment cannot use userland includes. On Wed, Nov 20, 2019 at 12:18 PM Todd C. Miller wrote: > Changing from int -> bool is error prone since you inevitably have > code that use true, false and -1. Finding those outliers that are

Re: un-boolean_t ANSIfy ddb(4) for hppa & sparc64

2019-11-20 Thread Jonathan Gray
On Wed, Nov 20, 2019 at 10:25:59AM -0700, Theo de Raadt wrote: > Todd C. Miller wrote: > > > On Wed, 20 Nov 2019 10:17:09 -0700, "Theo de Raadt" wrote: > > > > > Todd C. Miller wrote: > > > > > > > On Wed, 20 Nov 2019 07:38:46 -0700, "Theo de Raadt" wrote: > > > > > > > > > Kernel environment

Re: panic: unmount: dangling vnode

2019-11-20 Thread Theo de Raadt
Alexander Bluhm wrote: > Quite often I see "panic: unmount: dangling vnode". My test > regress/sys/kern/mount triggers it, but it also happens when rebooting > virtual machines. > > The problem is, when dirty buffers are flushed to disk, the unmount > process sleeps. If the file system is busy

panic: unmount: dangling vnode

2019-11-20 Thread Alexander Bluhm
Hi, Quite often I see "panic: unmount: dangling vnode". My test regress/sys/kern/mount triggers it, but it also happens when rebooting virtual machines. The problem is, when dirty buffers are flushed to disk, the unmount process sleeps. If the file system is busy, other processes can create new

Re: Consistent use of RW_PROC().

2019-11-20 Thread Alexandr Nedvedicky
Hello, On Wed, Nov 20, 2019 at 12:21:04PM +0100, Martin Pieuchot wrote: > As pointed out by sashan@ in a previous diff, unify all checks to have > the same idiom. > > Ok? looks OK to me. thanks and regards sashan

Re: OpenSSH U2F/FIDO support in base

2019-11-20 Thread Daniel Jakots
On Fri, 15 Nov 2019 08:45:23 +1100 (AEDT), Damien Miller wrote: > Please test this thoroughly - it's a big change that we want to have > stable before the next release. Tested with a Solo key. Initially it had the firmware 2.0.0 and it didn't work but updating to 3.0.0 made it work. Cheers, Dan

Re: un-boolean_t ANSIfy ddb(4) for hppa & sparc64

2019-11-20 Thread Theo de Raadt
Todd C. Miller wrote: > On Wed, 20 Nov 2019 10:17:09 -0700, "Theo de Raadt" wrote: > > > Todd C. Miller wrote: > > > > > On Wed, 20 Nov 2019 07:38:46 -0700, "Theo de Raadt" wrote: > > > > > > > Kernel environment cannot use userland includes. > > > > > > Some other systems have sys/stdbool.h,

Re: un-boolean_t ANSIfy ddb(4) for hppa & sparc64

2019-11-20 Thread Todd C . Miller
On Wed, 20 Nov 2019 10:17:09 -0700, "Theo de Raadt" wrote: > Todd C. Miller wrote: > > > On Wed, 20 Nov 2019 07:38:46 -0700, "Theo de Raadt" wrote: > > > > > Kernel environment cannot use userland includes. > > > > Some other systems have sys/stdbool.h, we could as well if we wanted > > to. Th

Re: un-boolean_t ANSIfy ddb(4) for hppa & sparc64

2019-11-20 Thread Todd C . Miller
On Wed, 20 Nov 2019 05:42:39 -0500, Andras Farkas wrote: > Out of curiosity, why not just use stdbool.h if these are actually > meant to be booleans? Wouldn't that be more readable? > I wonder if there's something I'm not understanding. Changing from int -> bool is error prone since you inevitab

Re: un-boolean_t ANSIfy ddb(4) for hppa & sparc64

2019-11-20 Thread Theo de Raadt
Todd C. Miller wrote: > On Wed, 20 Nov 2019 07:38:46 -0700, "Theo de Raadt" wrote: > > > Kernel environment cannot use userland includes. > > Some other systems have sys/stdbool.h, we could as well if we wanted > to. The simplest approach is to move include/stdbool.h -> > sys/sys/stdbool.h and

Re: un-boolean_t ANSIfy ddb(4) for hppa & sparc64

2019-11-20 Thread Todd C . Miller
On Wed, 20 Nov 2019 07:38:46 -0700, "Theo de Raadt" wrote: > Kernel environment cannot use userland includes. Some other systems have sys/stdbool.h, we could as well if we wanted to. The simplest approach is to move include/stdbool.h -> sys/sys/stdbool.h and make /usr/include/stdbool.h a link to

Re: ptrace(2) errnos

2019-11-20 Thread Theo de Raadt
sure Martin Pieuchot wrote: > Two fixes to reduce difference with other BSDs and make NetBSD's > t_ptrace.c regress pass: > > - Return EBUSY when calling PT_TRACE_ME more than once, both FreeBSD and > NetBSD do that. > > - Return EPERM instead of EINVAL when trying to trace a parent, this is

Re: acpivout(4): fix brightness not going up

2019-11-20 Thread Patrick Wildt
On Sat, Nov 02, 2019 at 10:09:43PM -0400, James Hastings wrote: > Hi, > > Backlight on multiple laptops will go down but not up when using brightness > keys. > Compare new brightness level to min/max values in sc_bcl[] instead. > Diff below restores backlight up function. Since (n)level is based

Re: pci_sdhc: Intel eMMC controller fix

2019-11-20 Thread Patrick Wildt
On Fri, Mar 29, 2019 at 05:22:13AM -0400, James Hastings wrote: > Index: dev/pci/pcidevs > === > RCS file: /cvs/src/sys/dev/pci/pcidevs,v > retrieving revision 1.1881 > diff -u -p -r1.1881 pcidevs > --- dev/pci/pcidevs 20 Mar 2019 10

Re: iwm(4): support for MSI-X

2019-11-20 Thread joshua stein
On Wed, 20 Nov 2019 at 14:59:41 +0100, Patrick Wildt wrote: > Hi, > > on my Intel NUC 8i5BEHs that has a 9560 chip the current in-tree > support for the 9000 series does not work. The issue seems to be > the interrupt delivery. The first interrupt we wait for, which is > loading the firmware chu

Re: iwm: support 9260 devices

2019-11-20 Thread Patrick Wildt
On Wed, Nov 20, 2019 at 08:06:25AM -0800, Bryan Vyhmeister wrote: > On Sat, Nov 16, 2019 at 10:01:44PM -0800, Philip Guenther wrote: > > Looking good so far on my X1 extreme once I > > added PCI_PRODUCT_INTEL_WL_9560_2 next to the _1 lines in if_iwm.c. > > Awesome! > > Could this change be committ

Re: iwm: support 9260 devices

2019-11-20 Thread Bryan Vyhmeister
On Sat, Nov 16, 2019 at 10:01:44PM -0800, Philip Guenther wrote: > Looking good so far on my X1 extreme once I > added PCI_PRODUCT_INTEL_WL_9560_2 next to the _1 lines in if_iwm.c. > Awesome! Could this change be committed as well? This allows the 9560 on my ThinkPad P1 to work as well. Thank you!

Re: ldomctl, ldomd: Honour DEBUG in Makefile

2019-11-20 Thread Klemens Nanni
On Tue, Nov 19, 2019 at 10:32:39PM -0700, Theo de Raadt wrote: > Seems accidentally left over from development. As a rule we don't > ship with -g. I'm also happy to remove DEBUG as usual. OK? Index: ldomctl/Makefile === RCS file: /

Re: un-boolean_t ANSIfy ddb(4) for hppa & sparc64

2019-11-20 Thread Theo de Raadt
Kernel environment cannot use userland includes. Andras Farkas wrote: > Out of curiosity, why not just use stdbool.h if these are actually > meant to be booleans? Wouldn't that be more readable? > I wonder if there's something I'm not understanding. > > On Tue, Nov 5, 2019 at 8:05 AM Martin Pi

Re: infinite tsleep -> tsleep_nsec

2019-11-20 Thread Alexander Bluhm
On Wed, Nov 20, 2019 at 12:30:47PM +0100, Martin Pieuchot wrote: > Convert infinite tsleep(9) to tsleep_nsec(9) in sys/dev/usb, ok? OK bluhm@ > Index: if_wi_usb.c > === > RCS file: /cvs/src/sys/dev/usb/if_wi_usb.c,v > retrieving revi

Re: INFSLP in sys/ufs

2019-11-20 Thread Alexander Bluhm
On Wed, Nov 20, 2019 at 12:48:40PM +0100, Martin Pieuchot wrote: > Convert tsleep(9) -> tsleep_nsec(9) for infinite sleeps in sys/ufs, ok? OK bluhm@ > Index: ufs/ffs/ffs_softdep.c > === > RCS file: /cvs/src/sys/ufs/ffs/ffs_softdep.c,

Re: ptrace(2) errnos

2019-11-20 Thread Alexander Bluhm
On Wed, Nov 20, 2019 at 01:49:33PM +0100, Martin Pieuchot wrote: > Two fixes to reduce difference with other BSDs and make NetBSD's > t_ptrace.c regress pass: > > - Return EBUSY when calling PT_TRACE_ME more than once, both FreeBSD and > NetBSD do that. > > - Return EPERM instead of EINVAL when t

iwm(4): support for MSI-X

2019-11-20 Thread Patrick Wildt
Hi, on my Intel NUC 8i5BEHs that has a 9560 chip the current in-tree support for the 9000 series does not work. The issue seems to be the interrupt delivery. The first interrupt we wait for, which is loading the firmware chunks, never appears. Even disabling MSI and relying on legacy interrupts

ptrace(2) errnos

2019-11-20 Thread Martin Pieuchot
Two fixes to reduce difference with other BSDs and make NetBSD's t_ptrace.c regress pass: - Return EBUSY when calling PT_TRACE_ME more than once, both FreeBSD and NetBSD do that. - Return EPERM instead of EINVAL when trying to trace a parent, this is what NetBSD does. Alternatively I could k

INFSLP in sys/ufs

2019-11-20 Thread Martin Pieuchot
Convert tsleep(9) -> tsleep_nsec(9) for infinite sleeps in sys/ufs, ok? Index: ufs/ffs/ffs_softdep.c === RCS file: /cvs/src/sys/ufs/ffs/ffs_softdep.c,v retrieving revision 1.144 diff -u -p -r1.144 ffs_softdep.c --- ufs/ffs/ffs_softdep

infinite tsleep -> tsleep_nsec

2019-11-20 Thread Martin Pieuchot
Convert infinite tsleep(9) to tsleep_nsec(9) in sys/dev/usb, ok? Index: if_wi_usb.c === RCS file: /cvs/src/sys/dev/usb/if_wi_usb.c,v retrieving revision 1.70 diff -u -p -r1.70 if_wi_usb.c --- if_wi_usb.c 12 Nov 2019 07:47:30 -

Consistent use of RW_PROC().

2019-11-20 Thread Martin Pieuchot
As pointed out by sashan@ in a previous diff, unify all checks to have the same idiom. Ok? Index: kern/kern_rwlock.c === RCS file: /cvs/src/sys/kern/kern_rwlock.c,v retrieving revision 1.42 diff -u -p -r1.42 kern_rwlock.c --- kern/ke

Re: sysupgrade: Allow to use another directory for the sets

2019-11-20 Thread Solene Rapenne
On Tue, Nov 12, 2019 at 07:02:56PM +0100, Renaud Allard wrote: > > > On 12/11/2019 08:29, Theo de Raadt wrote: > > > > Renaud, please test it for me like this: > > > > sysupgrade -d / > > > > This interface is dangerously incorrect. > > > > What about this one? > Index: sysupgrade.8 >

Re: un-boolean_t ANSIfy ddb(4) for hppa & sparc64

2019-11-20 Thread Andras Farkas
Out of curiosity, why not just use stdbool.h if these are actually meant to be booleans? Wouldn't that be more readable? I wonder if there's something I'm not understanding. On Tue, Nov 5, 2019 at 8:05 AM Martin Pieuchot wrote: > > ok? > > Index: arch/hppa/hppa/db_disasm.c >

Re: sysupgrade: Allow to use another directory for the sets

2019-11-20 Thread Renaud Allard
On 11/20/19 10:59 AM, Solene Rapenne wrote: no, this script makes /home/_sysupgrade a symbolic link to the real location where you want to store the sets. So /home doesn't require more space than the requirement for an additional symlink. sysupgrade has a check to ensure the directory is n

Re: sysupgrade: Allow to use another directory for the sets

2019-11-20 Thread Solene Rapenne
On Wed, Nov 20, 2019 at 10:55:28AM +0100, Renaud Allard wrote: > Hi Solene, > > On 11/20/19 10:46 AM, Solene Rapenne wrote: > > wouldn't be easier for people using non standard locations to write a > > small wrapper script like this (not tested, written in the mail) > > > > #!/bin/sh > > > > MYD

Re: sysupgrade: Allow to use another directory for the sets

2019-11-20 Thread Renaud Allard
Hi Solene, On 11/20/19 10:46 AM, Solene Rapenne wrote: wouldn't be easier for people using non standard locations to write a small wrapper script like this (not tested, written in the mail) #!/bin/sh MYDEST=/var/sysupgrade install -d -o root -g wheel $MYDEST rm -fr /home/_sysupgrade ln -s $MY

Re: sysupgrade: Allow to use another directory for the sets

2019-11-20 Thread Solene Rapenne
On Wed, Nov 20, 2019 at 10:37:02AM +0100, Raimo Niskanen wrote: > On Tue, Nov 19, 2019 at 09:00:33AM +, Stuart Henderson wrote: > > On 2019/11/18 14:45, Raimo Niskanen wrote: > > > On Mon, Nov 18, 2019 at 01:23:27PM +0100, Renaud Allard wrote: > > > > > > > > > > > > On 11/18/19 10:08 AM, Rai

Re: sysupgrade: Allow to use another directory for the sets

2019-11-20 Thread Raimo Niskanen
On Tue, Nov 19, 2019 at 09:00:33AM +, Stuart Henderson wrote: > On 2019/11/18 14:45, Raimo Niskanen wrote: > > On Mon, Nov 18, 2019 at 01:23:27PM +0100, Renaud Allard wrote: > > > > > > > > > On 11/18/19 10:08 AM, Raimo Niskanen wrote: > > > > > > > A configuration parameter could be accompl