Re: rpki-client: validate.c, roa.c, main.c docs

2019-11-17 Thread Claudio Jeker
On Sun, Nov 17, 2019 at 10:25:02PM +0100, Kristaps Dzonsons wrote: > This causes validate.c's valid_cert() doc not to lie, makes the language > consistent with other functions, and cleans a typo. > > In main.c, this documents tal_load_default() (which it marks static), > moves a #define to the top

Re: rpki-client: remove unused variables

2019-11-17 Thread Claudio Jeker
On Sun, Nov 17, 2019 at 10:12:15PM +0100, Kristaps Dzonsons wrote: > This removes some unused variables from the output files. Indeed, OK claudio@ > ? remove-unused-variables.patch > Index: output-bird.c > === > RCS file: /cvs/src/us

Re: rpki-client: check empty TAL file

2019-11-17 Thread Claudio Jeker
On Sun, Nov 17, 2019 at 10:05:11PM +0100, Kristaps Dzonsons wrote: > If tal_read_file() returns a NULL buffer, which can happen with an empty > file or one containing only comments, the NULL value eventually > propogates to tal_parse_buffer() where it crashes on strchr(). > > This patch also adds/

Re: ospfd: type p2p

2019-11-17 Thread Claudio Jeker
On Sun, Nov 17, 2019 at 12:44:44PM +0100, Remi Locherer wrote: > On Sat, Nov 16, 2019 at 06:58:35AM +0100, Claudio Jeker wrote: > > On Fri, Nov 15, 2019 at 06:06:42PM +0100, Remi Locherer wrote: > > > On Mon, Nov 04, 2019 at 02:01:57PM +0200, Kapetanakis Giannis wrote: > > > > On 25/10/2019 13:57,

re(4): set isr to the correct value

2019-11-17 Thread Kevin Lo
Hi, This diff sets isr to the correct value (sc->rl_intrs). While here don't assign ifp twice in the same function. Tested with: re0 at pci2 dev 0 function 0 "Realtek 8168" rev 0x15: RTL8168H/8111H (0x5400), msi, address d8:cb:8a:xx:xx:xx re0 at pci3 dev 0 function 0 "Realtek 8168" rev 0x0c: RT

[PATCH] src/libexec/ftpd: fix nlist with -option does not work

2019-11-17 Thread SASANO Takayoshi
Hello, At least OpenBSD-6.5 and 6.6's ftpd does not work NLIST command with any -option like this. ftp> nlist 150 Opening ASCII mode data connection for 'file list'. uaa _sysupgrade 226 Transfer complete. ftp> nlist -LF 550 -LF: No such file or directory. ftp> Here is the remedy, ok?

Re: Support for Realtek RTL8125 2.5Gb Ethernet controller

2019-11-17 Thread Kevin Lo
On Mon, Nov 18, 2019 at 07:08:33AM +1000, Jonathan Matthew wrote: > > On Fri, Nov 15, 2019 at 03:44:24PM +0800, Kevin Lo wrote: > > Hi, > > > > The following diff adds support for Realtek RTL8125 chip. > > Tested with Syba SD-PEX24065. > > > > Test reports and OKs are welcome. > > I don't have

Re: iwm: support 9260 devices

2019-11-17 Thread Mark Kettenis
> Date: Sat, 16 Nov 2019 19:08:05 +0100 > From: Stefan Sperling > > On Sat, Nov 16, 2019 at 11:44:03AM -0600, joshua stein wrote: > > Awesome, thanks guys. It's working great on the 9560 on my ThinkPad > > X1C7. A speed test showed 44/18 Mbps and it continues to work fine > > after an S3 cycl

Re: iwm: support 9260 devices

2019-11-17 Thread Kevin Lo
On Sat, Nov 16, 2019 at 10:01:44PM -0800, Philip Guenther wrote: > > On Sat, Nov 16, 2019 at 8:19 AM Stefan Sperling wrote: > > > On Sat, Nov 16, 2019 at 04:51:44PM +0100, Stefan Sperling wrote: > > > This diff adds support for iwm(4) 9260 devices and hopefully 9560 > > > devices as well but I h

Re: ix(4) need support for X553

2019-11-17 Thread Hrvoje Popovski
On 14.11.2019. 1:06, Stuart Henderson wrote: > Apart from the obvious style(9) problems, can anyone give me guidance on > how to approach this diff? I'm quite uneasy at the amount of changes but these > nics are quite important, they're all over the place on Atom C3xxx boards > which are pretty muc

rpki-client: validate.c, roa.c, main.c docs

2019-11-17 Thread Kristaps Dzonsons
This causes validate.c's valid_cert() doc not to lie, makes the language consistent with other functions, and cleans a typo. In main.c, this documents tal_load_default() (which it marks static), moves a #define to the top of the page, and documents it too. In roa.c, this adds documentation. Index

rpki-client: remove unused variables

2019-11-17 Thread Kristaps Dzonsons
This removes some unused variables from the output files. ? remove-unused-variables.patch Index: output-bird.c === RCS file: /cvs/src/usr.sbin/rpki-client/output-bird.c,v retrieving revision 1.1 diff -u -p -u -r1.1 output-bird.c --- ou

Re: Support for Realtek RTL8125 2.5Gb Ethernet controller

2019-11-17 Thread Jonathan Matthew
On Fri, Nov 15, 2019 at 03:44:24PM +0800, Kevin Lo wrote: > Hi, > > The following diff adds support for Realtek RTL8125 chip. > Tested with Syba SD-PEX24065. > > Test reports and OKs are welcome. I don't have hardware to test with, but I've read through this and it looks good to me. One thing I

rpki-client: check empty TAL file

2019-11-17 Thread Kristaps Dzonsons
If tal_read_file() returns a NULL buffer, which can happen with an empty file or one containing only comments, the NULL value eventually propogates to tal_parse_buffer() where it crashes on strchr(). This patch also adds/fixes documentation to the some functions, specifies a NUL terminator instead

Re: ospfd: type p2p

2019-11-17 Thread Remi Locherer
On Sat, Nov 16, 2019 at 06:58:35AM +0100, Claudio Jeker wrote: > On Fri, Nov 15, 2019 at 06:06:42PM +0100, Remi Locherer wrote: > > On Mon, Nov 04, 2019 at 02:01:57PM +0200, Kapetanakis Giannis wrote: > > > On 25/10/2019 13:57, Remi Locherer wrote: > > > > Hi tech@, > > > > > > > > earlier this yea

XHCI support for bulk xfers >64k

2019-11-17 Thread Marcus Glocker
While recently testing UDL on XHCI I faced a lot of USB timeouts, and therefore screen rendering issues. The reason is that XHCI currently only supports single bulk transfers up to 64k, while UDL can schedule a bulk transfer up to 1m. The following diff adds XHCI bulk transfer support >64k and mak

Re: [PATCH] [src] bin/ed/README - fix quote/comma

2019-11-17 Thread Raf Czlonka
On Sun, Nov 17, 2019 at 10:23:38AM GMT, Otto Moerbeek wrote: > On Sun, Nov 17, 2019 at 08:31:00AM +, Raf Czlonka wrote: > > > Hi all, > > > > Pretty straightforward - comma snuck in inside the quoted book title. > > This is how I learned it. Myabe a bit old-fashinoed, but not wrong. > >

Re: [PATCH] [src] bin/ed/README - fix quote/comma

2019-11-17 Thread Otto Moerbeek
On Sun, Nov 17, 2019 at 08:31:00AM +, Raf Czlonka wrote: > Hi all, > > Pretty straightforward - comma snuck in inside the quoted book title. This is how I learned it. Myabe a bit old-fashinoed, but not wrong. -Otto > > Regards, > > Raf > > Index: bin/ed/README > ===

[PATCH] [src] bin/ed/README - fix quote/comma

2019-11-17 Thread Raf Czlonka
Hi all, Pretty straightforward - comma snuck in inside the quoted book title. Regards, Raf Index: bin/ed/README === RCS file: /cvs/src/bin/ed/README,v retrieving revision 1.5 diff -u -p -r1.5 README --- bin/ed/README 15 Jun 2