Re: probable error in 66.html regarding rpki-client

Ross L Richardson wrote: > 66.html claims that rpki-client is included, but: > - gives no result. > - The test system I just sysupgraded doesn't have it. > > It's not actually linked to the build (in src/usr.sbin/Makefile), is it? It isn't. It wasn't rea

probable error in 66.html regarding rpki-client

66.html claims that rpki-client is included, but: - gives no result. - The test system I just sysupgraded doesn't have it. It's not actually linked to the build (in src/usr.sbin/Makefile), is it? Ross

Re: in6_setsockaddr and in6_setpeeraddr can return void, like their v4 counterparts

On Wed, Oct 16, 2019 at 08:19:28PM +1000, David Gwynne wrote: > the ipv4 ones return void, and these can't fail, so make them return > nothing too. > > ok? OK bluhm@ > Index: netinet/in_pcb.h > === > RCS file: /cvs/src/sys/netinet/in

Re: struct proc: track process starting time as an uptime

On Wed, Oct 16, 2019 at 10:23:52AM -0500, Scott Cheloha wrote: > Hi, > > Tracking the process starting time as an uptime fixes the classic > "init(8) started in 1969" bug in ps(1) when your CMOS battery dies. > > In general it lets us track how long a process has been running > correctly regardless

Re: kill scheduler_fork_hook()

On Tue, Oct 15, 2019 at 05:19:15PM +0200, Martin Pieuchot wrote: > The only raison d'etre of scheduler_fork_hook() is because `p_estcpu' is > not at the right place in "struct proc". Diff below fixes that. I > reordered the fields to not have implicit padding increase the size of > the structure.

ifconfig ioctl input validation

Hi, syszcaller shows that we lack kernel input validation when setting addresses. https://syzkaller.appspot.com/bug?id=4196491189556b467eafcc8daf3f9a051b4123a0 Althogh this is not exactly the ioctl(2) syzcaller found, I would like to start fixing SIOCAIFADDR and SIOCDIFADDR. Others will be fixe

Re: rpki-client patch submission

On Wed, Oct 16, 2019 at 07:26:25AM -0300, Alexandre Hamada wrote: > Hi Tech, > I would like to suggest to use UTC functions on all date/time convertions, > to avoid some clock drift errors. > > Kind regards, > Alexandre Hamada > > https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-clien

struct proc: track process starting time as an uptime

Hi, Tracking the process starting time as an uptime fixes the classic "init(8) started in 1969" bug in ps(1) when your CMOS battery dies. In general it lets us track how long a process has been running correctly regardless of whether or not the kernel UTC clock has jumped. NetBSD and FreeBSD hav

Re: rpki-client patch submission

On Wed, Oct 16, 2019 at 07:26:25AM -0300, Alexandre Hamada wrote: > Hi Tech, > I would like to suggest to use UTC functions on all date/time convertions, > to avoid some clock drift errors. I came to the conclusion that more is needed in this function. Converting time using ASN1_GENERALIZEDTIME_pr

rpki-client patch submission

Hi Tech, I would like to suggest to use UTC functions on all date/time convertions, to avoid some clock drift errors. Kind regards, Alexandre Hamada https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-client/pull/9.patch From a463f8cb23375f15b74eff49a06e8934423e3dbf Mon Sep 17 00:00:

in6_setsockaddr and in6_setpeeraddr can return void, like their v4 counterparts

the ipv4 ones return void, and these can't fail, so make them return nothing too. ok? Index: netinet/in_pcb.h === RCS file: /cvs/src/sys/netinet/in_pcb.h,v retrieving revision 1.116 diff -u -p -r1.116 in_pcb.h --- netinet/in_pcb.h