Re: route, arp, ndp padding

2019-08-30 Thread Claudio Jeker
On Sat, Aug 31, 2019 at 12:07:21AM +0200, Alexander Bluhm wrote: > On Fri, Aug 30, 2019 at 09:54:49PM +0200, Claudio Jeker wrote: > > Just throw a struct sockaddr_storage in that union. It will make sure > > there is enough space for everything and then you can skip the MAXIMUM > > dance you do now

Re: route, arp, ndp padding

2019-08-30 Thread Theo de Raadt
Alexander Bluhm wrote: > On Fri, Aug 30, 2019 at 09:54:49PM +0200, Claudio Jeker wrote: > > Just throw a struct sockaddr_storage in that union. It will make sure > > there is enough space for everything and then you can skip the MAXIMUM > > dance you do now. > > Yes, that is much nicer. Althoug

Re: route, arp, ndp padding

2019-08-30 Thread Alexander Bluhm
On Fri, Aug 30, 2019 at 09:54:49PM +0200, Claudio Jeker wrote: > Just throw a struct sockaddr_storage in that union. It will make sure > there is enough space for everything and then you can skip the MAXIMUM > dance you do now. Yes, that is much nicer. Although I have to work around this compiler

Re: route, arp, ndp padding

2019-08-30 Thread Theo de Raadt
Claudio Jeker wrote: > > union sockunion { > > struct sockaddr sa; > > struct sockaddr_in sin; > > @@ -26,6 +38,7 @@ union sockunion { > > struct sockaddr_dl sdl; > > struct sockaddr_rtlabel rtlabel; > > struct sockaddr_mplssmpls; > > + char

Re: route, arp, ndp padding

2019-08-30 Thread Claudio Jeker
On Fri, Aug 30, 2019 at 04:44:56PM +0200, Alexander Bluhm wrote: > Hi, > > The algorithm in route(8) and arp(6) is still not correct. While > the values written to the kernel are fine, the bytes for padding > are taken from memory after the sockaddr structs. > > In route(8) the union of sockaddr

Re: relayd: remove unveil to unbreak "check script"

2019-08-30 Thread Theo de Raadt
Well the first step is to back the commit out. Stuart Henderson wrote: > - > Date: 2019/04/24 20:13:49 > Author: mestre > Branch: HEAD > Tag: (none) > Log: > restrict filesystem access to read only on main process via unveil(2) > > ok benno@ deraadt@ > > Members: >

relayd: remove unveil to unbreak "check script"

2019-08-30 Thread Stuart Henderson
- Date: 2019/04/24 20:13:49 Author: mestre Branch: HEAD Tag: (none) Log: restrict filesystem access to read only on main process via unveil(2) ok benno@ deraadt@ Members: relayd.c:1.174->1.175 - This breaks "check script". OK, or any better idea

Re: msdosfs: remove timezone support

2019-08-30 Thread Ted Unangst
Scott Cheloha wrote: > The FAT file system hails from Redmond and so it tracks a timezone. > OpenBSD implicitly uses the kernel timezone when selecting which > timezone to use when mounting a FAT file system. > > This support is undocumented. > > This patch removes that support. > > The upshot i

route, arp, ndp padding

2019-08-30 Thread Alexander Bluhm
Hi, The algorithm in route(8) and arp(6) is still not correct. While the values written to the kernel are fine, the bytes for padding are taken from memory after the sockaddr structs. In route(8) the union of sockaddr can be made larger so that the padding is taken from there. In arp(8) we know

unbound 1.9.3

2019-08-30 Thread Stuart Henderson
Has a few fixes. The new "IPSet" code is linux only. Diff below is in order: changelog, code changes, build scaffolding. Any comments/concerns/OKs? Index: doc/Changelog === RCS file: /cvs/src/usr.sbin/unbound/doc/Changelog,v retrie

once again: iwm(4) multi-frame rx + monitor mode

2019-08-30 Thread Stefan Sperling
I would like to try this again: In iwm(4), process more than one frame per Rx interrupt, and enable monitor mode. Monitor mode triggers "unhandled fimware response" errors without multi-Rx support. We have seen these infamous errors in other contexts as well. It is possible that the firmware decid

less(1): utility function to step one multibyte character to the left

2019-08-30 Thread Ingo Schwarze
Hi, the file less/line.c currently contains three copies of code to step one multibyte character to the left in a char * buffer, and cleaning up the file less/cmdbuf.c will require similar functionality in the future. So let's introduce a new function for that purpose. Keep it as similar as possi

msdosfs: remove timezone support

2019-08-30 Thread Scott Cheloha
The FAT file system hails from Redmond and so it tracks a timezone. OpenBSD implicitly uses the kernel timezone when selecting which timezone to use when mounting a FAT file system. This support is undocumented. This patch removes that support. The upshot is that your timestamps will be off if (

Re: roaming fix for iwm(4) and iwn(4)

2019-08-30 Thread Stefan Sperling
On Sun, Aug 25, 2019 at 03:42:53PM +0200, Stefan Sperling wrote: > On Sun, Aug 25, 2019 at 02:53:58PM +0200, Stefan Sperling wrote: > > I've seen iwm(4) get stuck trying to associate to 2 GHz APs only and > > never trying available 5 GHz ones. This happens because net80211 sets > > a fixed mode dur