Re: bridge(4)+pf(4) fix incoming interface

2019-07-17 Thread Alexander Bluhm
On Wed, Jul 17, 2019 at 04:35:22PM -0300, Martin Pieuchot wrote: > Diff below is a rework of Eygene's submission to avoid duplicating the > logic leading to the re-enqueue of a packet based on a matching MAC > address. > > The bug first explained by Eygene [0] happens when multiple members of > a b

Re: mbuf cluster limit pool wakeup

2019-07-17 Thread Alexander Bluhm
On Tue, Jul 16, 2019 at 08:58:43PM -0300, Martin Pieuchot wrote: > On 16/07/19(Tue) 21:35, Alexander Bluhm wrote: > > Hi, > > > > When the kernel reaches the sysclt kern.maxclusters limit, operations > > get stuck while holding the net lock. Increasing the limit does > > not help as there is no wa

iked(8): add transport mode for childsas

2019-07-17 Thread Tobias Heider
This diff allows iked(8) to optionally negotiate Child SAs with IPsec transport mode instead of tunnel mode. Ok? Index: iked.conf.5 === RCS file: /cvs/src/sbin/iked/iked.conf.5,v retrieving revision 1.55 diff -u -p -u -r1.55 iked.con

bridge(4)+pf(4) fix incoming interface

2019-07-17 Thread Martin Pieuchot
Diff below is a rework of Eygene's submission to avoid duplicating the logic leading to the re-enqueue of a packet based on a matching MAC address. The bug first explained by Eygene [0] happens when multiple members of a bridge(4) share the same MAC address. In that particular case the order of t

pool for routing pcb

2019-07-17 Thread Alexander Bluhm
Hi, Same thing for routing socket as for IPsec pfkey PCB. Convert struct rtpcb malloc(9) to pool_get(9). ok? bluhm Index: net/rtsock.c === RCS file: /data/mirror/openbsd/cvs/src/sys/net/rtsock.c,v retrieving revision 1.288 diff -u

Re: vxlan(4) regression

2019-07-17 Thread Martin Pieuchot
Hello Michael, On 17/07/19(Wed) 08:59, Michael Graves wrote: > I think I have found a possible regression introduced in if_bridge.c at > version 1.323. So the bug is not present at revision 1.322? > Using the following setup > > C1 - R1 -+ > (em1 - br

Re: pool for pfkey pcb

2019-07-17 Thread Martin Pieuchot
On 17/07/19(Wed) 17:34, Alexander Bluhm wrote: > On Tue, Jul 16, 2019 at 09:01:24PM -0300, Martin Pieuchot wrote: > > On 16/07/19(Tue) 22:45, Alexander Bluhm wrote: > > > Hi, > > > > > > Convert struct pkpcb malloc(9) to pool_get(9). PCB for pfkey is > > > only used in process context, so pass PR_

Re: make msgsnd(2) more posix

2019-07-17 Thread Alexander Bluhm
On Sun, Jul 14, 2019 at 02:57:54PM +0200, Klemens Nanni wrote: > We also fail to mention that condition in the ERRORS section. Moritz, can you create a man page ERRORS diff? > > - if (msg->msg_type < 0) { > > + if (msg->msg_type <= 0) { > OK kn, although I'd go with `< 1' as that matches the

Re: pool for pfkey pcb

2019-07-17 Thread Alexander Bluhm
On Tue, Jul 16, 2019 at 09:01:24PM -0300, Martin Pieuchot wrote: > On 16/07/19(Tue) 22:45, Alexander Bluhm wrote: > > Hi, > > > > Convert struct pkpcb malloc(9) to pool_get(9). PCB for pfkey is > > only used in process context, so pass PR_WAITOK to pool_init(9). > > The possible sleep in pool_put(

vxlan(4) regression

2019-07-17 Thread Michael Graves
Hello I think I have found a possible regression introduced in if_bridge.c at version 1.323. Using the following setup C1 - R1 -+ (em1 - bridge0 - vxlan0 - em0 )| LAN