missing splnet in network drivers

The recent mii_tick diff made me ponder whether the mii tick timeout could be put in the mii_data struct rather than each driver softc (not that a good idea, actually). While looking at this, I noticed that two drivers may end up invoking mii_tick() while not being at IPL_NET. bnx: bnx_tick() can

Make dwge(4) call mii_tick(9)

Such that it detects link status changes. ok? Index: dev/ic/dwc_gmac.c === RCS file: /cvs/src/sys/dev/ic/dwc_gmac.c,v retrieving revision 1.11 diff -u -p -r1.11 dwc_gmac.c --- dev/ic/dwc_gmac.c 30 Dec 2018 20:11:59 - 1.11

Re: ldomctl: improve usage

Andrew Grillet wrote: > I assumed "usage" is printed in response to a failure to give the correct > combination of command and argument > and that -h (or help) would give more detail. well you assumed wrong --- I don't believe we have a single utility in the tree which behaves that way. The usa

Re: ldomctl: improve usage

I assumed "usage" is printed in response to a failure to give the correct combination of command and argument and that -h (or help) would give more detail. I would like the usage (response to incorrect combination) to be the "synopsis" while the grouped commands and their valid arguments is supplie

Re: ospfd: point-to-point on ethernet interfaces

ping On Mon, Jun 24, 2019 at 12:33:16AM +0200, Remi Locherer wrote: > Diff below adds to ospfd point to point support for Ethernet interfaces. > I successfully tested this against Junos and FastIron. > > I first made the key word in the config "point-to-point". But then I > changed to "type p2p".

Re: ldomctl: improve usage

Thanks for the input; I won't persue such verbose usages any longer. Another attempt was to continue grouping the commands by their arguments: $ ldomctl -h usage: ldomctl command [argument ...] ldomctl delete|select configuration ldomctl download

cwm.1: describe applications

I tested cwm(1) as daily driver and it took me a few reads to understand what "applications". They're predefined commands you put into cwmrc(5) but cwm(1) does not mention that, plus the option for it is `command` not `application`, so searching a tag "application" did not find it; only the comme

mg(1) self-insert-char

In order to test certain aspects of mg, I use the eval-current-buffer function. However, that doesn't let me insert a character like 'a' unless mg is getting that character from another file or previously existing text, somewhere on disk, or in RAM. This diff allows eval-current-buffer (or an

Re: libc: getgrnam: save errno before calling `access`

On Tue, 02 Jul 2019 09:43:13 -0600, "Theo de Raadt" wrote: > Yes, that is a problem. Same problem applies to two other files; > here are the diffs I propose. Looks good. OK millert@ - todd

Re: libc: getgrnam: save errno before calling `access`

Richard Ipsum wrote: > I was working on an implementation of chown and got an error when > running it on OpenBSD. It looks like a change[1] might have > introduced unintended side-effects to getgrnam. > > Without the patch supplied below some chown implementations > may fail with ENOENT when the

libc: getgrnam: save errno before calling `access`

Hi, I was working on an implementation of chown and got an error when running it on OpenBSD. It looks like a change[1] might have introduced unintended side-effects to getgrnam. Without the patch supplied below some chown implementations may fail with ENOENT when they should succeed. I've tested

Re: smtpd replace mkstemp+fdopen with tmpfile

On Mon, Jul 01, 2019 at 08:25:02PM +0200, Martijn van Duren wrote: > No functional change intended, just simplify the code. > > OK? > yes, ok gilles@ > Index: enqueue.c > === > RCS file: /cvs/src/usr.sbin/smtpd/enqueue.c,v > retrie