armv7: bus_space_map corner case fix

2019-03-07 Thread Greg Czerniak
The bus_space_map() function on armv7 fails in the corner case where you want to allocate the last memory page. Consider a case where bpa = 0xfc00 and size=0x120. startpa becomes 0xf000 while endpa becomes startpa + PAGE_SIZE which is 0x. The following for-loop is currently condit

Re: radeon driver argb cursor fixes (was Re: X segmentation fault by chromium)

2019-03-07 Thread Jonathan Gray
On Tue, Mar 05, 2019 at 10:24:10PM +0100, Matthieu Herrb wrote: > On Mon, Mar 04, 2019 at 09:14:45AM +0100, Matthieu Herrb wrote: > > On Sat, Mar 02, 2019 at 10:24:22PM +0200, Mihai Popescu wrote: > > > Hello, > > > > > > I am able to generate a segmentation fault on X with chromium help. > > > Th

Re: vmd/vmctl: improve VM name checks/error handling

2019-03-07 Thread Klemens Nanni
On Thu, Mar 07, 2019 at 09:00:55PM +0100, Theo Buehler wrote: > On Thu, Mar 07, 2019 at 08:52:45PM +0100, Klemens Nanni wrote: > > vmd(8) does not support numerical names with `start' and `receive'. > > It never worked, the manuals are now clearer about this, but error > > handling can still be imp

Re: vmd/vmctl: improve VM name checks/error handling

2019-03-07 Thread Mike Larkin
On Thu, Mar 07, 2019 at 08:52:45PM +0100, Klemens Nanni wrote: > vmd(8) does not support numerical names with `start' and `receive'. > It never worked, the manuals are now clearer about this, but error > handling can still be improved: > > $ vmctl start 60 -t test -d 60.qcow2 > vmctl:

Re: Spleen kernel fonts improvements

2019-03-07 Thread Mark Kettenis
> Date: Thu, 7 Mar 2019 21:22:09 +0100 > From: Frederic Cambus > > Hi tech@, > > Here is a diff to sync kernel fonts with the latest released Spleen > version, bringing the following improvements: > > - Remove strain pixels on the inner upper part of parentheses for the > 16x32 version > - Ha

Spleen kernel fonts improvements

2019-03-07 Thread Frederic Cambus
Hi tech@, Here is a diff to sync kernel fonts with the latest released Spleen version, bringing the following improvements: - Remove strain pixels on the inner upper part of parentheses for the 16x32 version - Harmonize the 'v' and 'V' characters across all sizes - Remove artefacts from the 'c'

Re: vmd/vmctl: improve VM name checks/error handling

2019-03-07 Thread Theo Buehler
On Thu, Mar 07, 2019 at 08:52:45PM +0100, Klemens Nanni wrote: > vmd(8) does not support numerical names with `start' and `receive'. > It never worked, the manuals are now clearer about this, but error > handling can still be improved: I'm not sure I understand. This works fine for me with -curren

vmd/vmctl: improve VM name checks/error handling

2019-03-07 Thread Klemens Nanni
vmd(8) does not support numerical names with `start' and `receive'. It never worked, the manuals are now clearer about this, but error handling can still be improved: $ vmctl start 60 -t test -d 60.qcow2 vmctl: start vm command failed: No such file or directory That's from vm_star

Re: acpithinkpad: a fix for the x260

2019-03-07 Thread James Turner
On Thu, Mar 07, 2019 at 01:31:59PM +, Stuart Henderson wrote: > On 2019/03/06 20:55, joshua stein wrote: > > sthen found that the HKEY version metric failed on the x260 where it > > reports version 1 but requires the new ACPI method of changing > > backlight. > > > > This diff tries to do th

Re: acpithinkpad: a fix for the x260

2019-03-07 Thread Tracey Emery
No problems here. Tracey On Wed, Mar 06, 2019 at 08:55:15PM -0600, joshua stein wrote: > sthen found that the HKEY version metric failed on the x260 where it > reports version 1 but requires the new ACPI method of changing > backlight. > > This diff tries to do the ACPI method on all machines a

Re: Avoid system(3) in ikectl

2019-03-07 Thread Matthew Martin
On Thu, Mar 7, 2019 at 4:53 AM Stuart Henderson wrote: > > On 2019/03/06 22:20, Theo de Raadt wrote: > > I'm not sure why this matters. > > > > Fundamentally system is fork+exec via a shell. So you write it as > > minimal fork+exec. > > > > What is the particular benefit you see here, is it secur

Re: acpithinkpad: a fix for the x260

2019-03-07 Thread Stuart Henderson
On 2019/03/06 20:55, joshua stein wrote: > sthen found that the HKEY version metric failed on the x260 where it > reports version 1 but requires the new ACPI method of changing > backlight. > > This diff tries to do the ACPI method on all machines and falls back > to the CMOS method if that fai

Re: Avoid system(3) in ikectl

2019-03-07 Thread Stuart Henderson
On 2019/03/06 22:20, Theo de Raadt wrote: > I'm not sure why this matters. > > Fundamentally system is fork+exec via a shell. So you write it as > minimal fork+exec. > > What is the particular benefit you see here, is it security -- and if > so, what is the security benefit? Have you identified