Re: once rules fix

2019-03-05 Thread petr . hoffmann
Klemens Nanni writes: > Thanks! Diff makes sense, see comments inline. I confirm that this > restores intended behaviour and regress is fine as well. > > With those addressed OK kn; or I take care of it after getting an OK. > sashan? Thanks for pointing to the details. Fixed now: diff --git a

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-05 Thread Renato Aguiar
Hi Joshua, I just tried your patch on T470p and X230. On T470p, display brightness keys are now working and keyboard backlight is reported correctly by wsconsctl. On X230, display brightness keys are still working fine. Regards, On Tue, Mar 05 2019, joshua stein wrote: Here we go again...

Re: libcrypto: INTEGER_cmp vs. STRING_cmp

2019-03-05 Thread Theo Buehler
On Tue, Mar 05, 2019 at 11:39:02PM +0100, Holger Mikolon wrote: > Hi, > > while debugging an unusual openssl use case, I tried reading and > understanding libcrypto x509 code and came across the comparison > of serialNumbers (of type ASN1_INTEGER*) with a string comparison > function. Below patch

libcrypto: typo in comment

2019-03-05 Thread Holger Mikolon
Index: x509_vfy.c === RCS file: /cvs/src/lib/libcrypto/x509/x509_vfy.c,v retrieving revision 1.71 diff -u -p -u -r1.71 x509_vfy.c --- x509_vfy.c 19 Aug 2018 20:19:31 - 1.71 +++ x509_vfy.c 5 Mar 2019 22:19:46 - @@ -159,

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-05 Thread Tracey Emery
On Tue, Mar 05, 2019 at 02:03:13PM -0600, joshua stein wrote: > Here we go again... > > On at least the ThinkPad X1C6, the screen brightness keys (F5 and > F6) do not work and "wsconsctl keyboard.backlight" doesn't report > the correct value when the keyboard backlight is adjusted with > Fn+Spa

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-05 Thread Sebastian Benoit
joshua stein(j...@openbsd.org) on 2019.03.05 14:03:13 -0600: > Here we go again... > > On at least the ThinkPad X1C6, the screen brightness keys (F5 and > F6) do not work and "wsconsctl keyboard.backlight" doesn't report > the correct value when the keyboard backlight is adjusted with > Fn+Spac

Re: relayd websocket

2019-03-05 Thread Rivo Nurges
Hi! On 3/5/19 10:36 PM, Claudio Jeker wrote: > I guess that this would need strcasestr() instead of strcasecmp(), since you > are looking for the substring "Upgrade" in value. Maybe more is needed if > we want to be sure that 'Connection: Upgrade-maybe' does not match. You are correct about strca

libcrypto: INTEGER_cmp vs. STRING_cmp

2019-03-05 Thread Holger Mikolon
Hi, while debugging an unusual openssl use case, I tried reading and understanding libcrypto x509 code and came across the comparison of serialNumbers (of type ASN1_INTEGER*) with a string comparison function. Below patch fixes the comparison to use ASN1_INTEGER_cmp. The man page (ASN1_STRING_cmp

radeon driver argb cursor fixes (was Re: X segmentation fault by chromium)

2019-03-05 Thread Matthieu Herrb
On Mon, Mar 04, 2019 at 09:14:45AM +0100, Matthieu Herrb wrote: > On Sat, Mar 02, 2019 at 10:24:22PM +0200, Mihai Popescu wrote: > > Hello, > > > > I am able to generate a segmentation fault on X with chromium help. > > This is happening each time I visit the web page at [1]. Basically, > > there

Re: reverse scroll direction wstpad

2019-03-05 Thread Ulf Brosziewski
On 3/5/19 7:40 PM, Ted Unangst wrote: > Ulf Brosziewski wrote: >> BTW, reverting the scroll direction is also possible by configuring >> a "ZAxisMapping" in ws(4), with an xorg.conf like this one: >> >> Section "InputClass" >> Identifier "touchpad_scroll_buttons" >> MatchIsTouchPad "true" >

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-05 Thread James Turner
On Tue, Mar 05, 2019 at 02:03:13PM -0600, joshua stein wrote: > Here we go again... > > On at least the ThinkPad X1C6, the screen brightness keys (F5 and > F6) do not work and "wsconsctl keyboard.backlight" doesn't report > the correct value when the keyboard backlight is adjusted with > Fn+Spa

Re: relayd websocket

2019-03-05 Thread Claudio Jeker
On Tue, Mar 05, 2019 at 04:21:30PM +, Rivo Nurges wrote: > Hi! > > RFC 6455 4.2.1 states: > 4. A |Connection| header field that *includes* the token "Upgrade", > treated as an ASCII case-insensitive value. > > In my test case Firefox sends: Connection: keep-alive, Upgrade > > Relayd

Re: once rules fix

2019-03-05 Thread Alexandr Nedvedicky
Hello Klemens, On Tue, Mar 05, 2019 at 04:47:33PM +0100, Klemens Nanni wrote: > Thanks! Diff makes sense, see comments inline. I confirm that this > restores intended behaviour and regress is fine as well. > > With those addressed OK kn; or I take care of it after getting an OK. > sashan?

acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-05 Thread joshua stein
Here we go again... On at least the ThinkPad X1C6, the screen brightness keys (F5 and F6) do not work and "wsconsctl keyboard.backlight" doesn't report the correct value when the keyboard backlight is adjusted with Fn+Space. These are both caused by the default event mask not including these

Re: reverse scroll direction wstpad

2019-03-05 Thread Ted Unangst
Ulf Brosziewski wrote: > BTW, reverting the scroll direction is also possible by configuring > a "ZAxisMapping" in ws(4), with an xorg.conf like this one: > > Section "InputClass" > Identifier "touchpad_scroll_buttons" > MatchIsTouchPad "true" > Option "ZAxisMapping" "5 4" > EndSection

relayd websocket

2019-03-05 Thread Rivo Nurges
Hi! RFC 6455 4.2.1 states: 4. A |Connection| header field that *includes* the token "Upgrade", treated as an ASCII case-insensitive value. In my test case Firefox sends: Connection: keep-alive, Upgrade Relayd currently expects Connection to equal Upgrade, not include Upgrade. I haven't

Re: once rules fix

2019-03-05 Thread Klemens Nanni
Thanks! Diff makes sense, see comments inline. I confirm that this restores intended behaviour and regress is fine as well. With those addressed OK kn; or I take care of it after getting an OK. sashan? On Tue, Mar 05, 2019 at 04:31:40AM -0800, petr.hoffm...@oracle.com wrote: > @@ -913,7 +913,33

Re: ssh man pages: PKCS#11 no longer limited to RSA

2019-03-05 Thread Klemens Nanni
On Tue, Mar 05, 2019 at 04:27:22PM +0100, Christian Weisgerber wrote: > Minor man page tweaks to reflect the fact that PKCS#11 support is > no longer limited to RSA. OK, I've been using ECDSA on a PIV smartcard just fine.

Re: ssh man pages: PKCS#11 no longer limited to RSA

2019-03-05 Thread Sebastian Benoit
ok! Christian Weisgerber(na...@mips.inka.de) on 2019.03.05 16:27:22 +0100: > Minor man page tweaks to reflect the fact that PKCS#11 support is > no longer limited to RSA. > > Index: ssh-keygen.1 > === > RCS file: /cvs/src/usr.bin/ssh

ssh man pages: PKCS#11 no longer limited to RSA

2019-03-05 Thread Christian Weisgerber
Minor man page tweaks to reflect the fact that PKCS#11 support is no longer limited to RSA. Index: ssh-keygen.1 === RCS file: /cvs/src/usr.bin/ssh/ssh-keygen.1,v retrieving revision 1.156 diff -u -p -r1.156 ssh-keygen.1 --- ssh-keygen

Re: once rules fix

2019-03-05 Thread petr . hoffmann
Sorry, my MUA replaced tabs with spaces in the patch I sent previously. Find the correct one below: diff --git a/sbin/pfctl/parse.y b/sbin/pfctl/parse.y index e8dd97f6222..e55b2893069 100644 --- a/sbin/pfctl/parse.y +++ b/sbin/pfctl/parse.y @@ -354,7 +354,7 @@ struct pfctl_watermarks syncooki

Re: reverse scroll direction wstpad

2019-03-05 Thread Ulf Brosziewski
Adding these options - switching the scroll direction and a customizable button map for tapping - to wsmouse and wstpad would not be a big deal. If there is interest, I could prepare a patch. I doubt, however, that both should be included in the named and visible wsmouse options of wsconsctl. Whi