Re: unwind: clean up list of includes

2019-01-26 Thread Florian Obser
On Sat, Jan 26, 2019 at 09:50:41PM +0100, Caspar Schutijser wrote: > Below is a diff that (attempts to) clean up the list of includes in > unwind. I added some missing includes, too. The hashes of the relevant > object files (control.o, frontend.o, printconf.o, resolver.o and > unwind.o) did not ch

Re: Unobfuscate thread stealing algorithm

2019-01-26 Thread Mark Kettenis
> Date: Sat, 26 Jan 2019 14:46:41 -0200 > From: Martin Pieuchot > > On MP machines, when a CPU executes mi_switch() and doesn't have any > thread on its runqueue it will try to steal one from another CPU's > runqueue. If it fails to steal a thread from another runqueue it > will pick its own Idl

unwind: clean up list of includes

2019-01-26 Thread Caspar Schutijser
Below is a diff that (attempts to) clean up the list of includes in unwind. I added some missing includes, too. The hashes of the relevant object files (control.o, frontend.o, printconf.o, resolver.o and unwind.o) did not change. I'm not sure if I'm supposed to touch control.c but I did it anyway.

Silent error in pfkeyv2_send()

2019-01-26 Thread Martin Pieuchot
If pfkeyv2_send() tries to send a message without a required extension or with a non-allowed extension it will silently fail. I spent many hours debugging the code exporting counters because of this. I'd like to return an error code instead. Ok? Index: /sys/net/pfkeyv2.c ===

Export per-TDB counters

2019-01-26 Thread Martin Pieuchot
Last time I enabled this code, I forgot to whitelist the extension for SADB_GET. Thanks to the help from Mark Patruck, who originally reported the regression with iked(8) via bugs@, I came up with the diff below. ok to enable it again? Index: net/pfkeyv2.c ===

Re: fsync(2) and I/O errors

2019-01-26 Thread Ted Unangst
Maximilian Lorlacks wrote: > Good day, > > It seems that fsync(2) may data after returning EIO once[1]. This > behaviour seems to cause problems with databases such as PostgreSQL > and goes contrary to the man page's description, which says that > "fsync() and fdatasync() should be used by progra

Unobfuscate thread stealing algorithm

2019-01-26 Thread Martin Pieuchot
On MP machines, when a CPU executes mi_switch() and doesn't have any thread on its runqueue it will try to steal one from another CPU's runqueue. If it fails to steal a thread from another runqueue it will pick its own Idle thread. To decide which thread should be picked, the scheduler evaluate t

Re: unwind: trust anchor path in unwind.8

2019-01-26 Thread Florian Obser
committed, thanks! On Sat, Jan 26, 2019 at 03:00:43PM +0100, Caspar Schutijser wrote: > The diff below fixes the path of the trust anchor in unwind.8. > > Thanks, > Caspar Schutijser > > > Index: unwind.8 > === > RCS file: /cvs/src

unwind: trust anchor path in unwind.8

2019-01-26 Thread Caspar Schutijser
The diff below fixes the path of the trust anchor in unwind.8. Thanks, Caspar Schutijser Index: unwind.8 === RCS file: /cvs/src/sbin/unwind/unwind.8,v retrieving revision 1.2 diff -u -p -r1.2 unwind.8 --- unwind.825 Jan 2019 09:

fsync(2) and I/O errors

2019-01-26 Thread Maximilian Lorlacks
Good day, It seems that fsync(2) may data after returning EIO once[1]. This behaviour seems to cause problems with databases such as PostgreSQL and goes contrary to the man page's description, which says that "fsync() and fdatasync() should be used by programs that require a file to be in a known

[PATCH] Double free in ldapclient.c

2019-01-26 Thread Ville Valkonen
Hello, a pointer p is freed twice in ldapclient.c. diff --git usr.bin/ldap/ldapclient.c usr.bin/ldap/ldapclient.c index 02b15e0669b..336b9430325 100644 --- usr.bin/ldap/ldapclient.c +++ usr.bin/ldap/ldapclient.c @@ -477,7 +477,6 @@ ldapc_printattr(struct ldapc *ldap, const char *key, }

[PATCH] Remove an obsolete function tty_cmd_linefeed in tmux

2019-01-26 Thread Ville Valkonen
Hello, this patch removes an obsolete tty_cmd_linefeed function in tmux. It seems tty_cmd_linefeed function was used last time in: Author: nicm Date: Wed Feb 8 17:31:09 2017 + Add support for scroll up escape sequence (CSI S) and use it when possible instead of sending individual

pms(4) diff

2019-01-26 Thread Marcus Glocker
On my Lenovo ThinkPad X1 Gen6 the pms(4) mouse driver regularly fails after initialization stating: pms0: not in sync yet, discard input (state = 0, data = 0) The reason seems to be that the set mode command hasn't finished while we already enable the device. >From the Synaptics document