remove 2 duplicate functions in uvm anon

2019-01-15 Thread Amit Kulkarni
uao_reference() vs uao_reference_locked() uao_detach() vs uao_detach_locked() When you read the code, you can see that both are calling the same function, so fold them into the one function which is used by external callers, and remove the internal function call, but preserve its comments. Teste

Re: bwfm(4): show media mode, TX rate, and RSSI

2019-01-15 Thread Mike Larkin
On Tue, Jan 15, 2019 at 10:01:42PM +0100, Stefan Sperling wrote: > This diff makes 'ifconfig bwfm0' display whether 11n is active or not, > what the current Tx rate is, and show up-to-date RSSI measurements. > I'm leaving display of 11ac Tx rates for future work because that will > require a change

Regression on dhclient and automatisation

2019-01-15 Thread sven falempin
Dear courageous Reader, The 6.0 to 6.4 diff show the go_daemon ( why not https://man.openbsd.org/daemon ??? ) function changed a lot, before it was working through automation software now it creates zombie, that NEVER dies. do_daemon Diff Below. One way to produce this would be : perl unless (

bwfm(4): show media mode, TX rate, and RSSI

2019-01-15 Thread Stefan Sperling
This diff makes 'ifconfig bwfm0' display whether 11n is active or not, what the current Tx rate is, and show up-to-date RSSI measurements. I'm leaving display of 11ac Tx rates for future work because that will require a change in struct ieet80211_node. Tested with 'bwfm0 at pci1 dev 0 function 0 "

Re: otus(4) magic number

2019-01-15 Thread Mark Kettenis
> Date: Tue, 15 Jan 2019 16:18:17 +0100 > From: Stefan Sperling > > There's a lot of magic numbers in otus(4). Here is one which was > easy to fix based on information from the Linux driver. OK? ok kettenis@ > Index: if_otus.c > =

otus(4) magic number

2019-01-15 Thread Stefan Sperling
There's a lot of magic numbers in otus(4). Here is one which was easy to fix based on information from the Linux driver. OK? Index: if_otus.c === RCS file: /cvs/src/sys/dev/usb/if_otus.c,v retrieving revision 1.62 diff -u -p -r1.62 i

Re: net80211: don't drop unencrypted data frames with no data

2019-01-15 Thread Stefan Sperling
On Tue, Jan 15, 2019 at 11:40:28AM +0200, Lauri Tirkkonen wrote: > On Tue, Jan 15 2019 10:30:47 +0100, Stefan Sperling wrote: > > Turns out we need to allow "no data" frames to pass a bit further into > > ieee80211_input() because they carry sequence numbers and because they > > are used to toggle

Re: file(1) better ideas to recognize rust language code?

2019-01-15 Thread Nicholas Marriott
I would really like it if file(1) could use the upstream magic files, but they now use a lot of regex. Even if I just add the c-lang file, the difference is dramatic, especially on large files: $ time file magdir/* /etc/* /bin/* >/dev/null 0m01.05s real 0m00.87s user 0m00.16s system $

Re: net80211: don't drop unencrypted data frames with no data

2019-01-15 Thread Lauri Tirkkonen
On Tue, Jan 15 2019 10:30:47 +0100, Stefan Sperling wrote: > Turns out we need to allow "no data" frames to pass a bit further into > ieee80211_input() because they carry sequence numbers and because they > are used to toggle power-saving state via IEEE80211_FC1_PWR_MGT in the > frame header. > >

Re: net80211: don't drop unencrypted data frames with no data

2019-01-15 Thread Stefan Sperling
On Tue, Jan 15, 2019 at 12:50:33AM +0200, Lauri Tirkkonen wrote: > On Mon, Jan 14 2019 16:41:13 +0200, Lauri Tirkkonen wrote: > > > Indeed, my diff was bad as well. Thanks for spotting these issues. > > > I hadn't run this diff yet cause I was still building a new snapshot > > > to test it. Could y

Re: file(1) better ideas to recognize rust language code?

2019-01-15 Thread Ted Unangst
Nicholas Marriott wrote: > I think I would avoid adding more of these at the moment, especially > ones that aren't very specific (why is "package" Go and not Java?) and Because I've never written a java package. :)