Re: Virtio 1.0 for the kernel

2019-01-11 Thread Jonathan Gray
On Fri, Jan 11, 2019 at 03:21:11PM -0800, William Ahern wrote: > On Fri, Jan 11, 2019 at 10:43:25AM +0100, Stefan Fritsch wrote: > > > /* only used for sizeof, not actually allocated */ > > extern struct virtio_pci_common_cfg ccfg; > > > #define CREAD(sc, memb) _cread(sc, \ > > offsetof(st

Re: Virtio 1.0 for the kernel

2019-01-11 Thread William Ahern
On Fri, Jan 11, 2019 at 10:43:25AM +0100, Stefan Fritsch wrote: > /* only used for sizeof, not actually allocated */ > extern struct virtio_pci_common_cfg ccfg; > #define CREAD(sc, memb) _cread(sc, \ > offsetof(struct virtio_pci_common_cfg, memb), sizeof(ccfg.memb)) > > The compiler shoul

zic(8) unneeded header

2019-01-11 Thread Jan Stary
zic.c does not need to include Jan Index: zic.c === RCS file: /cvs/src/usr.sbin/zic/zic.c,v retrieving revision 1.22 diff -u -p -r1.22 zic.c --- zic.c 15 Mar 2016 19:50:47 - 1.22 +++ zic.c 11 Jan 2019 2

Re: new USB audio class v2.0 driver

2019-01-11 Thread Martijn Rijkeboer
On 31-12-18 16:58, Alexandre Ratchov wrote: Hi, Here's a new driver for both USB audio class (UAC) v1.0 and v2.0 devices, it would replace the current one. It focuses on reliability and proper synchronization, including in low-latency configurations. Our current USB sub-system has limitations t

Re: LC_NUMERIC in wprintf(3)

2019-01-11 Thread Todd C . Miller
Don't we have the same issue with printf(3) and scanf(3)? For example, in src/lib/libc/stdio/vfprintf.c:1022 decimal_point = nl_langinfo(RADIXCHAR); Also, anything using strtod(3), including scanf(3), is likewise affected by gdtoa's use of localeconv()->decimal_point. - todd

Re: LC_NUMERIC in wprintf(3)

2019-01-11 Thread Ingo Schwarze
Hi, Jan Stary wrote on Thu, Jan 10, 2019 at 03:15:38PM +0100: > same for wscanf(3): Fixed, but in a way similar to wprintf(3). Yours, Ingo $ man wscanf | col -b | grep -A 6 ^CAVEATS CAVEATS On systems other than OpenBSD, the LC_NUMERIC locale(1) category can cause parsing failure

Re: LC_NUMERIC in wprintf(3)

2019-01-11 Thread Ingo Schwarze
Hi Ted & Scott, Ted Unangst wrote on Fri, Jan 11, 2019 at 04:03:32AM -0500: > Ingo Schwarze wrote: >> That stuff is a very serious trap not only for the unwary, but also >> for experienced programmers. Less than a month ago, i discussed >> the matter with a senior programmer from the GNU project

Re: Virtio 1.0 for the kernel

2019-01-11 Thread Ted Unangst
Stefan Fritsch wrote: > On Fri, 11 Jan 2019, Ted Unangst wrote: > A simple inline function does not work because memb is the name of a > member of a struct. But combined with a macro it would work. Like this: yeah, that looks pretty normal.

Re: Virtio 1.0 for the kernel

2019-01-11 Thread Stefan Fritsch
On Fri, 11 Jan 2019, Ted Unangst wrote: > Stefan Fritsch wrote: > > +#define CREAD(sc, memb) > > \ > > + ({ > > \ > > + struct virtio_pci_common_cfg c;

Re: Virtio 1.0 for the kernel

2019-01-11 Thread Ted Unangst
Stefan Fritsch wrote: > +#define CREAD(sc, memb) > \ > + ({ > \ > + struct virtio_pci_common_cfg c; > \ > +

Re: LC_NUMERIC in wprintf(3)

2019-01-11 Thread Ted Unangst
Ingo Schwarze wrote: > That stuff is a very serious trap not only for the unwary, but also > for experienced programmers. Less than a month ago, i discussed > the matter with a senior programmer from the GNU project who has > been maintaining important software over there for a long time and > gue

Re: Virtio 1.0 for the kernel

2019-01-11 Thread Stefan Fritsch
Hi Carlos, > > I'm getting ramped back up from being AWOL for several months, so > apologies in advance for the delay of going through your diff (and the > virtio header re-order one that you fixed). It'll be over the weekend > at the earliest before I can review/test it out. There is no hurry,

Re: Virtio 1.0 for the kernel

2019-01-11 Thread Stefan Fritsch
On Fri, 11 Jan 2019, Jonathan Gray wrote: > Assuming a qcow2 image created by something along the lines of > 'qemu-img create -f qcow2 root.qcow2 2g' miniroot64.fs from an arm64 > snapshot and u-boot for qemu_arm64 from the u-boot-aarch64 package: > > doas sh -c "qemu-system-aarch64 -runas $USER \

Re: Virtio 1.0 for the kernel

2019-01-11 Thread Stefan Fritsch
On Thu, 10 Jan 2019, Theo de Raadt wrote: > arm64 also uses this subsystem, and as a result this diff breaks > all those kernels. The diff also breaks vmd. Even if it compiles it will still be broken. As I wrote, it's not ready for commit yet. > > You ask how to run arm64 Uhm, you didn't e