Re: sbin/wsconsctl: show more data

2019-01-07 Thread Artturi Alm
On Sat, Jan 05, 2019 at 10:39:46PM +0200, li...@wrant.com wrote: > Just need a manual page and a tunable at some point, didn't much before. > Still needed more text lines on the console and utf8 options previously. > > Got less chars now, so console is a regression in data thus readability. > Also

Re: install(1) could fail due to race

2019-01-07 Thread Theo de Raadt
Ted Unangst wrote: > Todd C. Miller wrote: > > On Mon, 07 Jan 2019 22:55:54 +, Christian Weisgerber wrote: > > > > > Oooh, that short period can be the time between disk flushes (30s?) > > > with softupdates. I think that's one of the scenarios where you > > > can run out of disk space if y

Re: install(1) could fail due to race

2019-01-07 Thread Ted Unangst
Todd C. Miller wrote: > On Mon, 07 Jan 2019 22:55:54 +, Christian Weisgerber wrote: > > > Oooh, that short period can be the time between disk flushes (30s?) > > with softupdates. I think that's one of the scenarios where you > > can run out of disk space if you have softupdates enabled. > >

Re: install(1) could fail due to race

2019-01-07 Thread Todd C . Miller
On Mon, 07 Jan 2019 22:55:54 +, Christian Weisgerber wrote: > Oooh, that short period can be the time between disk flushes (30s?) > with softupdates. I think that's one of the scenarios where you > can run out of disk space if you have softupdates enabled. Yes, I think I've had that happen i

Re: sbin/wsconsctl: show more data

2019-01-07 Thread lists
Mon, 07 Jan 2019 16:27:46 -0700 "Theo de Raadt" > > use stty -a > Also, probably complementary methods could be considered: $ tput co li $ wsfontload -l

snmpd: dup open ttys to /dev/null in demons mode

2019-01-07 Thread Jan Klemkow
Hi, This diff is similar to bluhm@'s fix for httpd and relayd, but for snmpd. > During the fork+exec implementation, daemon(3) was moved after > proc_init(). As a consequence httpd(8) and relayd(8) child processes > do not detach from the terminal anymore. Dup /dev/null to the stdio > file desc

Re: sbin/wsconsctl: show more data

2019-01-07 Thread Theo de Raadt
Ted Unangst wrote: > Artturi Alm wrote: > > display.width=1920 > > display.height=1200 > > display.depth=32 > > display.emulations=vt100 > > display.col_x_row=120x37 > > display.font_wxh=16x32 > > now that we've all had a chance to weigh in on the font, why are you adding > this weird x format?

Re: install(1) could fail due to race

2019-01-07 Thread Christian Weisgerber
On 2019-01-07, "Todd C. Miller" wrote: > The main difference with -S is that you end up with two copies of > the target file on disk for a short period of time. Oooh, that short period can be the time between disk flushes (30s?) with softupdates. I think that's one of the scenarios where you ca

Re: install(1) could fail due to race

2019-01-07 Thread Lauri Tirkkonen
On Mon, Jan 07 2019 16:32:31 -0500, Ted Unangst wrote: > > > This doubles the number of synchronous > > > file operations. > > > > Does it? Without safecopy, the operations performed are: > > > > unlink(targetfile); > > open(targetfile, O_CREAT|O_EXCL); > > write(); > > fchmod();

diff: new PCI Vendor and Product ID for RocketPort serial card

2019-01-07 Thread Jan Klemkow
Hi, the following diff adds the PCI vendor and product ID for a PCI multiport serial card. dmesg shows the device as: "Comtrol Corporation RocketPort PCI 16-port Serial" rev 0x01 at pci1 dev 1 function 0 not configured bye, Jan Index: pci/pcidevs

Re: install(1) could fail due to race

2019-01-07 Thread Ted Unangst
Lauri Tirkkonen wrote: > On Mon, Jan 07 2019 15:48:25 -0500, Ted Unangst wrote: > > Lauri Tirkkonen wrote: > > > Hi, it seems install(1) has a race condition: in create_newfile, it > > > first unlinks the target file and then tries to open it with > > > O_CREAT|O_EXCL. > > > > > The below diff ess

Re: sbin/wsconsctl: show more data

2019-01-07 Thread Ted Unangst
Artturi Alm wrote: > display.width=1920 > display.height=1200 > display.depth=32 > display.emulations=vt100 > display.col_x_row=120x37 > display.font_wxh=16x32 now that we've all had a chance to weigh in on the font, why are you adding this weird x format? speaking of ugly... it should print colum

Re: install(1) could fail due to race

2019-01-07 Thread Todd C . Miller
The main difference with -S is that you end up with two copies of the target file on disk for a short period of time. That was a bigger deal back when -S was added. Today, it probably doesn't matter. - todd

Re: install(1) could fail due to race

2019-01-07 Thread Lauri Tirkkonen
On Mon, Jan 07 2019 15:48:25 -0500, Ted Unangst wrote: > Lauri Tirkkonen wrote: > > Hi, it seems install(1) has a race condition: in create_newfile, it > > first unlinks the target file and then tries to open it with > > O_CREAT|O_EXCL. > > > The below diff essentially removes the -S option and ma

Re: grep: convert fgetln to getline

2019-01-07 Thread Lauri Tirkkonen
On Mon, Jan 07 2019 15:41:53 -0500, Ted Unangst wrote: > Lauri Tirkkonen wrote: > > On Sun, Jan 06 2019 14:02:16 -0500, Ted Unangst wrote: > > > Lauri Tirkkonen wrote: > > > > Hi, another simple diff converting fgetln usage to getline. > > > > > > > > I also considered converting grep_fgetln to gr

Re: install(1) could fail due to race

2019-01-07 Thread Ted Unangst
Lauri Tirkkonen wrote: > Hi, it seems install(1) has a race condition: in create_newfile, it > first unlinks the target file and then tries to open it with > O_CREAT|O_EXCL. > The below diff essentially removes the -S option and makes install > always use temp files (ie. -S is always on), eliminat

Re: grep: convert fgetln to getline

2019-01-07 Thread Ted Unangst
Lauri Tirkkonen wrote: > On Sun, Jan 06 2019 14:02:16 -0500, Ted Unangst wrote: > > Lauri Tirkkonen wrote: > > > Hi, another simple diff converting fgetln usage to getline. > > > > > > I also considered converting grep_fgetln to grep_getline, but that would > > > mean that for FILE_MMAP we'd have

Re: kcov: enable retguard

2019-01-07 Thread Theo de Raadt
That's great! > Hi, > The problems caused by enabling both kcov and retguard was due to the > increased kernel size. Now that NKL2_KIMG_ENTRIES has been bumped on > amd64, it's no longer a problem. > > Comments? OK? > > Index: arch/amd64/conf/Makefile.amd64 >

kcov: enable retguard

2019-01-07 Thread Anton Lindqvist
Hi, The problems caused by enabling both kcov and retguard was due to the increased kernel size. Now that NKL2_KIMG_ENTRIES has been bumped on amd64, it's no longer a problem. Comments? OK? Index: arch/amd64/conf/Makefile.amd64 === R

Re: grep: convert fgetln to getline

2019-01-07 Thread Lauri Tirkkonen
On Sun, Jan 06 2019 14:02:16 -0500, Ted Unangst wrote: > Lauri Tirkkonen wrote: > > Hi, another simple diff converting fgetln usage to getline. > > > > I also considered converting grep_fgetln to grep_getline, but that would > > mean that for FILE_MMAP we'd have to copy the string. So this diff ke

Re: install(1) could fail due to race

2019-01-07 Thread Lauri Tirkkonen
On Mon, Jan 07 2019 20:13:09 +0200, Lauri Tirkkonen wrote: > @@ -128,9 +127,6 @@ main(int argc, char *argv[]) > case 'p': > docompare = dopreserve = 1; > break; > - case 'S': > - safecopy = 1; > -

install(1) could fail due to race

2019-01-07 Thread Lauri Tirkkonen
Hi, it seems install(1) has a race condition: in create_newfile, it first unlinks the target file and then tries to open it with O_CREAT|O_EXCL. Normally this would not be a problem, but I actually ran into this when parallel building gcc 6.4.0 (on another OS, but we use OpenBSD install(1)): they

Re: pci/i386: Fix typo

2019-01-07 Thread Christian Ludwig
On Thursday, 13. December 2018, 19:52:13 Mark Kettenis wrote: > > From: Christian Ludwig > > Cc: Christian Ludwig > > Date: Thu, 13 Dec 2018 17:44:47 +0100 > > > > Extents code has its own set of flags and does not use malloc's. > > The current code passes in EX_FAST by accident, which does no h

Re: http://cvshome.org no longer related to CVS version control.

2019-01-07 Thread Matteo Niccoli
Sorry, not man page. I mean running just cvs command: The Concurrent Versions System (CVS) is a tool for version control. For CVS updates and additional information, see the CVS home page at http://www.cvshome.org/ or Pascal Molli's CVS site at http://www.loria.fr/~molli/cvs-index.html O

http://cvshome.org no longer related to CVS version control.

2019-01-07 Thread Matteo Niccoli
Hello, reading the cvs man page I realized that there are a lot of references to the cvshome.org site , but it is not the cvs home page anymore. Maybe it should be changed to https://www.nongnu.org/cvs/?

Re: replacing timeout_add() with timeout_add_msec()

2019-01-07 Thread Mark Kettenis
> Date: Sun, 6 Jan 2019 21:46:01 -0600 > From: Amit Kulkarni > > > > Even on amd64, I won't be able to test, because of missing hardware. > > > If you think something is wrong, please will you let me have your > > > feedback? > > > > I'm a bit stunned at the zeal to push untested diffs into the