Re: athn(4) hostap: mem leak

2018-12-05 Thread Stefan Sperling
On Wed, Dec 05, 2018 at 07:55:07PM +0100, Benjamin Baier wrote: > Finally got a usb athn device. I can confirm that this codepath is hit > in hostap mode and the device still works with the patch. > > athn0 at uhub4 port 2 configuration 1 interface 0 "ATHEROS USB2.0 WLAN" rev > 2.00/1.08 addr 3 >

sed(1) Add support for "-" file

2018-12-05 Thread Martijn van Duren
According to POSIX[0]: The standard input shall be used if no file operands are specified, and shall be used if a file operand is '-' and the implementation treats the '-' as meaning standard input. Otherwise, the standard input shall not be used. See the INPUT FILES section. Which we currently

Re: relayd and TLS client cert verification

2018-12-05 Thread Ashe Connor
It's been a week or so, so bumping. (Benno was kind enough to offer a review but was time-poor recently.) Here's a diff for the manpage too. Ashe Index: usr.sbin/relayd/relayd.conf.5 === RCS file: /home/kivikakk/cvsync/root/src/us

find -not

2018-12-05 Thread Ted Unangst
Seen in the wild. Alias for ! that's friendlier to the shell. Index: find.1 === RCS file: /cvs/src/usr.bin/find/find.1,v retrieving revision 1.95 diff -u -p -r1.95 find.1 --- find.1 1 Aug 2018 07:09:15 - 1.95 +++ find.1

Re: be more strict when parsing netmasks for IPv6

2018-12-05 Thread Remi Locherer
On Wed, Dec 05, 2018 at 09:22:22AM +0100, Claudio Jeker wrote: > When parsing a network mask into prefixlen be more paranoid and make sure > no value bigger then 128 is returned. In general this should never happen > but if it does the result can be bad. > > This is for bgpd but there are other us

Re: option kcov + GENERIC.MP -> silent crash

2018-12-05 Thread Anton Lindqvist
On Sat, Dec 01, 2018 at 04:34:57PM +0100, Anton Lindqvist wrote: > On Tue, Nov 27, 2018 at 05:52:15PM -0800, Greg Steuck wrote: > > I booted the patched kernel and it seems to have gone farther and I believe > > reached init before crashing. > > By performing a semi-automated bisect I was able to

bridge cleanup

2018-12-05 Thread Martin Pieuchot
Stop passing `sc' when it is not necessary. Also prefer passing the brigde's ifp rather than `sc' when it's enough. This makes auditing easier. Different structures need different locking. As a bonus is removes an horrible cast in net/if_switch.c. ok? Index: net/if_bridge.c ==

Re: athn(4) hostap: mem leak

2018-12-05 Thread Benjamin Baier
Finally got a usb athn device. I can confirm that this codepath is hit in hostap mode and the device still works with the patch. athn0 at uhub4 port 2 configuration 1 interface 0 "ATHEROS USB2.0 WLAN" rev 2.00/1.08 addr 3 athn0: AR9271 rev 1 (1T1R), ROM rev 13, address c4:e9:84:dc:27:11 Full dme

Useless splnet()

2018-12-05 Thread Martin Pieuchot
bstp_create() is called on by bridge/switch_clone_create(). Nothing it touches is reachable, so there's no need for splnet(). ok? Index: net/bridgestp.c === RCS file: /cvs/src/sys/net/bridgestp.c,v retrieving revision 1.66 diff -u -

Re: malloc.3: remove left-over from malloc_usable_size commit

2018-12-05 Thread Ingo Schwarze
Hi Hiltjo, Hiltjo Posthuma wrote on Wed, Dec 05, 2018 at 05:46:53PM +0100: > In the malloc_usable_size() revert commit it was forgotten > to remove one line. > > The below patch fixes this: Committed, thanks. Ingo > diff --git a/lib/libc/stdlib/malloc.3 b/lib/libc/stdlib/malloc.3 > index 49

Re: traceroute6 and ospf6d (icmp6 source addresses and link-locals)

2018-12-05 Thread Arnaud BRAND
Le 2018-12-05 13:03, Stuart Henderson a écrit : On 2018/12/05 12:40, Arnaud BRAND wrote: Or is there something else I missed ? > > + if (ifa != NULL) src = &(ifa->ia_addr.sin6_addr); > > + if (src == NULL) src = &ifatoia6(rt->rt_ifa)->ia_addr.sin6_addr;

malloc.3: remove left-over from malloc_usable_size commit

2018-12-05 Thread Hiltjo Posthuma
Hi, In the malloc_usable_size() revert commit it was forgotten to remove one line. The below patch fixes this: diff --git a/lib/libc/stdlib/malloc.3 b/lib/libc/stdlib/malloc.3 index 49a5b993f44..cc71560739a 100644 --- a/lib/libc/stdlib/malloc.3 +++ b/lib/libc/stdlib/malloc.3 @@ -63,7 +63,6 @@

netcred free(9) sizes

2018-12-05 Thread Martin Pieuchot
Keep track of the allocated size and use it later :) ok? Index: kern/vfs_subr.c === RCS file: /cvs/src/sys/kern/vfs_subr.c,v retrieving revision 1.282 diff -u -p -r1.282 vfs_subr.c --- kern/vfs_subr.c 29 Sep 2018 04:29:48 -

Re: cvsintro.7: patch to fix .Bx invocation

2018-12-05 Thread Ingo Schwarze
Hi, Fabio Scotoni wrote on Wed, Dec 05, 2018 at 02:23:58PM +0100: > The cvsintro(7) man page uses ".Bx -licensed", > which is rendered as "-licensedBSD". You are right, that is incorrect usage. > This patch fixes this to correctly read "BSD-licensed" > in both mandoc and groff. > I'm not entire

cvsintro.7: patch to fix .Bx invocation

2018-12-05 Thread Fabio Scotoni
The cvsintro(7) man page uses ".Bx -licensed", which is rendered as "-licensedBSD". This patch fixes this to correctly read "BSD-licensed" in both mandoc and groff. I'm not entirely sure if .Bx should even be used here, though apparently that decision has been made deliberately. Index: cvsintro.7

Re: traceroute6 and ospf6d (icmp6 source addresses and link-locals)

2018-12-05 Thread Stuart Henderson
On 2018/12/05 12:40, Arnaud BRAND wrote: > Or is there something else I missed ? > > > + if (ifa != NULL) src = &(ifa->ia_addr.sin6_addr); > > > + if (src == NULL) src = > > > &ifatoia6(rt->rt_ifa)->ia_addr.sin6_addr; if (ifa != NULL)

Re: traceroute6 and ospf6d (icmp6 source addresses and link-locals)

2018-12-05 Thread Arnaud BRAND
Le 2018-12-05 12:02, Denis Fondras a écrit : On Wed, Dec 05, 2018 at 11:36:14AM +0100, Arnaud BRAND wrote: Any feedback on this patch ? I'm running it without problems since the 30th November. Index: netinet6/icmp6.c === RCS file:

Re: traceroute6 and ospf6d (icmp6 source addresses and link-locals)

2018-12-05 Thread Claudio Jeker
On Wed, Dec 05, 2018 at 12:02:25PM +0100, Denis Fondras wrote: > On Wed, Dec 05, 2018 at 11:36:14AM +0100, Arnaud BRAND wrote: > > Any feedback on this patch ? > > I'm running it without problems since the 30th November. > > > > > > Index: netinet6/icmp6.c > >

Re: traceroute6 and ospf6d (icmp6 source addresses and link-locals)

2018-12-05 Thread Denis Fondras
On Wed, Dec 05, 2018 at 11:36:14AM +0100, Arnaud BRAND wrote: > Any feedback on this patch ? > I'm running it without problems since the 30th November. > > > Index: netinet6/icmp6.c > === > RCS file: /cvs/src/sys/netinet6/icmp6.c,v >

Bogus assertwaitok() in usb_block_allocmem()

2018-12-05 Thread Gerhard Roth
usb_block_allocmem() does not sleep and is careful to always use the BUS_DMA_NOWAIT flag. So why the assertwaitok()? Gerhard Index: sys/dev/usb/usb_mem.c === RCS file: /cvs/src/sys/dev/usb/usb_mem.c,v retrieving revision 1.31 diff

Re: traceroute6 and ospf6d (icmp6 source addresses and link-locals)

2018-12-05 Thread Arnaud BRAND
Any feedback on this patch ? I'm running it without problems since the 30th November. Index: netinet6/icmp6.c === RCS file: /cvs/src/sys/netinet6/icmp6.c,v retrieving revision 1.227 diff -u -p -u -p -r1.227 icmp6.c --- netinet6/icmp

Re: pvclock(4)

2018-12-05 Thread Peter Hessler
On 2018 Dec 04 (Tue) at 15:14:51 +0100 (+0100), Reyk Floeter wrote: :On Tue, Dec 04, 2018 at 05:43:48AM -0800, Chris Cappuccio wrote: :> Of course printf instead of panic for testers :> : :Oh, right, thanks! : :@john: Does this "slightly less simple" diff work for you? : :@phessler, Chris: Maybe

be more strict when parsing netmasks for IPv6

2018-12-05 Thread Claudio Jeker
When parsing a network mask into prefixlen be more paranoid and make sure no value bigger then 128 is returned. In general this should never happen but if it does the result can be bad. This is for bgpd but there are other users in the tree. I will adjust them if we dicide to go this way. -- :wq