bgpd: replace some more walkers with rib_dump

2018-10-24 Thread Claudio Jeker
Next step on my quest to make the RIB code better. This changes the following things: - network_flush is now using rib_dump_new to walk the Adj-RIB-In and remove all dynamically added announcements - peer_flush got generalized and is now used also in peer_down. It also uses a rib_dump_new call

Re: Fix descriptions of smtps vs smtp+tls in smtpd.conf.5

2018-10-24 Thread Gilles Chehade
On Thu, Oct 25, 2018 at 07:24:33AM +0100, Raf Czlonka wrote: > On Thu, Oct 25, 2018 at 07:11:47AM BST, Gilles Chehade wrote: > > > > smtpd will _always_ display a 'starttls' log line when the TLS channel > > starts, > > disregarding if TLS was started at connect time (smtps) or within the > > pr

Re: Fix descriptions of smtps vs smtp+tls in smtpd.conf.5

2018-10-24 Thread Raf Czlonka
On Thu, Oct 25, 2018 at 07:11:47AM BST, Gilles Chehade wrote: > > smtpd will _always_ display a 'starttls' log line when the TLS channel starts, > disregarding if TLS was started at connect time (smtps) or within the protocol > (smtp+tls, or even smtp since it does opportunistic tls). > I guess

Re: Fix descriptions of smtps vs smtp+tls in smtpd.conf.5

2018-10-24 Thread Gilles Chehade
On Mon, Oct 22, 2018 at 08:37:25PM -0400, trondd wrote: > Unless I'm confused, it seems the description of the smarthosts smtps and > smtp+tls are revered in the smtpd.conf man page. > You are confused ;-) > My log seemed to back this up. When using smtp+tls, which the man page said > uses STAR

Re: bridge(4) ioctl & MP

2018-10-24 Thread Alexander Bluhm
On Wed, Oct 24, 2018 at 04:34:43PM -0300, Martin Pieuchot wrote: > I'd like to take brigde_input() & bridge_output() outside of the > KERNEL_LOCK(). My previous approach relying on the NET_LOCK() didn't > work because wireless drivers might call bridge_output() from their > interrupt handler. > >

bridge(4) ioctl & MP

2018-10-24 Thread Martin Pieuchot
I'd like to take brigde_input() & bridge_output() outside of the KERNEL_LOCK(). My previous approach relying on the NET_LOCK() didn't work because wireless drivers might call bridge_output() from their interrupt handler. So we'll need another mechanism. The first step would be to use a mutex. O

Re: Regression in "Add support to create and convert disk images from existing images"

2018-10-24 Thread Greg Steuck
Thanks Anton. I confirm that applying this on top of the most recent tree fixed the problem for me. I wonder if a regression test of some sort is in order. The peanut gallery also observes that config_getvm is could use some light refactoring into smaller units. On Wed, Oct 24, 2018 at 8:51 AM An

Re: unveil bdftopcf

2018-10-24 Thread Theo de Raadt
Matthieu Herrb wrote: > Generally, I'm not too found of pledging/unveiling random X client > programs. There are a lot of "hidden" features in X libraries that > will probably break with too strict pledges and/or unveils. Well eventually we want to see if something can be done about xterm. Espec

Re: Regression in "Add support to create and convert disk images from existing images"

2018-10-24 Thread Anton Lindqvist
On Mon, Oct 22, 2018 at 11:05:13AM -0700, Greg Steuck wrote: > Hi Reyk & Anton, > > I upgraded the syzkaller machine from Oct 11 to Oct 21 snapshot and started > seeing: > Oct 22 10:00:21 ci-openbsd vmd[15707]: qc2_open: missing base image > /syzkaller/managers/main/current/image > Oct 22 10:00:21

bgplg: allow neighbors with space in name

2018-10-24 Thread Denis Fondras
I have peers with description containing spaces but bgplg won't accept that by default. I'd like some comments on that diff. It is OK for bgplgsh (show ip bgp in "Peer 1" feels OK) but not for bgplg as I have to quote the peer description in the input box (feels rather unnatural). Index: bgplg.c

Re: unveil spamlogd

2018-10-24 Thread Bob Beck
ok beck@ as well On Wed, Oct 24, 2018 at 06:13 Todd C. Miller wrote: > On Wed, 24 Oct 2018 08:05:11 +0100, Ricardo Mestre wrote: > > > The only file that spamlogd needs to access after calling pledge is > > PATH_SPAMD_DB, so unveil it with O_RDWR permissions. > > Looks good. OK millert@ > > -

Re: readelf: fix out-of-bounds error

2018-10-24 Thread Mark Kettenis
> Date: Tue, 23 Oct 2018 23:45:55 +0200 > From: Christian Weisgerber > > I ran across this: > > $ readelf -h /usr/local/bin/w3m > ... > readelf(71968) in free(): bogus pointer (double free?) 0x1 > Abort trap (core dumped) > > In readelf.c there's a static arrary: > > static bfd_vma d

Re: diff: split ctloutput into getopt/setopt

2018-10-24 Thread Martin Pieuchot
On 18/10/18(Thu) 11:34, David Hill wrote: > Hello - > > This diff splits the ctloutput functions into getopt/setopt, which could > offer more fine-grained locking. It also removes some indentation and > imo is easier to read. > > Thoughts? Splitting the read and write path makes sense, it will

Re: igmp_slowtimo: drop NETLOCK

2018-10-24 Thread Martin Pieuchot
On 19/10/18(Fri) 12:15, Scott Cheloha wrote: > Hi, > > If we introduce a mutex for the igmp module we can drop the NETLOCK > from igmp_slowtimo(). The router_info list, rti_head, and its entries > are only ever accessed within the igmp module. The mutex also needs > to protect igmp_timers_are_ru

Re: unveil bdftopcf

2018-10-24 Thread Matthieu Herrb
On Wed, Oct 24, 2018 at 11:24:59AM +0100, Ricardo Mestre wrote: > Hi, > > If input_name is provided we can unveil it with read permissions, if > output_name is provided we need to unveil this one with rwc. Additionally > depending on the different combinations of if these files are passed via args

Re: Reuse VM ids.

2018-10-24 Thread Carlos Cardenas
On Tue, Oct 23, 2018 at 10:21:08PM -0700, Ori Bernstein wrote: > On Mon, 8 Oct 2018 07:59:15 -0700, Bob Beck wrote: > > > works here and I like it. but probably for after unlock > > > > It's after unlock -- pinging for OKs. > > -- > Ori Bernstein > ok ccardenas@ +--+ Carlos

Re: unveil xserver's priv proc

2018-10-24 Thread Matthieu Herrb
On Wed, Oct 24, 2018 at 10:36:58AM +0100, Ricardo Mestre wrote: > Hello, > > semarie@ already gave positive feedback for unveiling xserver, did > anyone tested it yet and comment on it or OK? Sorry I almost forgot I was running with this patch for some days now. ok matthieu@ > > Index: privsep

Re: unveil bdftopcf

2018-10-24 Thread Theo de Raadt
bdftopcf is intended to be portable code. I don't think it is right to start using functions in here. They are within an unveil-block which we'll carry as a diff, but still.. it doesn't feel right. I think you should use fprintf to stderr and exit as the existing code does. > If input_name is

Re: unveil spamlogd

2018-10-24 Thread Todd C. Miller
On Wed, 24 Oct 2018 08:05:11 +0100, Ricardo Mestre wrote: > The only file that spamlogd needs to access after calling pledge is > PATH_SPAMD_DB, so unveil it with O_RDWR permissions. Looks good. OK millert@ - todd

Re: Add acpipci(4) on amd64

2018-10-24 Thread Jeremie Courreges-Anglas
On Mon, Oct 22 2018, Mark Kettenis wrote: > Diff below adds an acpipci(4) driver on amd64. For now the main > purpose of this driver is to make the PCI-specific _OSC calls to > advertise the functionality we support. Most notably this advertises > support for PCIE native hotplug as we have some

bgplg: add missing commands

2018-10-24 Thread Denis Fondras
This diff adds 2 missing commands : - show ip bgp ovs - show ip bgp ext-community Index: bgplg.h === RCS file: /cvs/src/usr.bin/bgplg/bgplg.h,v retrieving revision 1.15 diff -u -p -r1.15 bgplg.h --- bgplg.h 24 Oct 2018 09:02:48 -0

unveil bdftopcf

2018-10-24 Thread Ricardo Mestre
Hi, If input_name is provided we can unveil it with read permissions, if output_name is provided we need to unveil this one with rwc. Additionally depending on the different combinations of if these files are passed via args or from stdin/to stdout we can also pledge accordingly to the code path.

Re: unveil xserver's priv proc

2018-10-24 Thread Ricardo Mestre
Hello, semarie@ already gave positive feedback for unveiling xserver, did anyone tested it yet and comment on it or OK? Index: privsep.c === RCS file: /cvs/xenocara/xserver/os/privsep.c,v retrieving revision 1.29 diff -u -p -u -r1.29

join(1) add UTF-8 support

2018-10-24 Thread Martijn van Duren
This adds UTF-8 support for join(1). Since we don't support collation we can skip that part of POSIX. This patch does add support for splitting columns on UTF-8 characters. Using schwarze@'s favorite UTF-8 character: $ cat /tmp/z1 aßbßc $ cat /tmp/z2 aßdße $ ./join -tß /tmp/z1 /tmp/z2 aßbßcßdß

unveil passwd

2018-10-24 Thread Ricardo Mestre
Hi, The diff below unveils passwd with exactly the same ones used on vipw, the only difference is that in this case _PATH_BSHELL is used to spawn an external passwordcheck program (if defined in /etc/login.conf) instead of an EDITOR. Tested by changing my users' passwords back and forth several t

Re: bgplg: fix show ip bgp out/in

2018-10-24 Thread Sebastian Benoit
ok benno@ Denis Fondras(de...@openbsd.org) on 2018.10.24 08:26:59 +0200: > This may have been broken for quite some time... > > Fix usage message for "show ip bgp in/out" and add missing "neighbor" > argument. > > Index: bgplg.h >

ldap(1) add SAFE-INIT-CHAR

2018-10-24 Thread Martijn van Duren
In my previous ldap mail I proclaimed that we should encode whitespace. Reading rfc2849 a bit further, encoding a string with leading space is mandatory by SAFE-INIT-CHAR. This is needed because of the definition of value-spec, which allows additional space, colon, and less-than after the colon

Re: Qcow2: Clean up logging/error handling

2018-10-24 Thread Michael Mikonos
On Tue, Oct 23, 2018 at 09:44:24PM -0700, Ori Bernstein wrote: > This patch turns most warnings into errors, and uses the > appropriate fatal/fatalx so that we don't print bogus error > strings. It also adds checks for unsupported refcount sizes > and writes that clobber the header. > > Ok? Hello

Re: Add acpipci(4) on amd64

2018-10-24 Thread Paul de Weerd
1019.dmesg Wed Oct 24 08:52:07 2018 +++ /home/weerd/taco.20181024.dmesg Wed Oct 24 08:52:07 2018 @@ -1,7 +1,7 @@ -OpenBSD 6.4-current (GENERIC.MP) #370: Fri Oct 19 13:09:31 MDT 2018 -dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP +OpenBSD 6.4-current (GENERIC.MP) #7: Wed

unveil spamlogd

2018-10-24 Thread Ricardo Mestre
Hi, The only file that spamlogd needs to access after calling pledge is PATH_SPAMD_DB, so unveil it with O_RDWR permissions. OK? Index: spamlogd.c === RCS file: /cvs/src/libexec/spamlogd/spamlogd.c,v retrieving revision 1.27 diff -u