Re: [vi] moving by sentences is inconsistent

2018-10-08 Thread Jonathan Thornburg
Two comments about this: Comment #1: An excellent (although secondary) source from the precambrian era, Morris I Bolsky "The /vi/ User's Hanbdbook" (c) 1984 by Bell Telephone Laboratories, Incorporated (c) 1985 by AT&T Technologies, Inc published by Prentice-Hall, ISBN 0-13-941733-

Re: vmd losing VMs

2018-10-08 Thread Greg Steuck
All my vmds are stuck after syzkaller was running for some 5 days (and found a couple of bugs!). I'll reinstall the system to get a fresh baseline. > 1. Are you getting any vmd cores? > * sysctl kern.nosuidcoredump=3 && mkdir /var/crash/vmd > * kill all vmd and restart the test. Not sure if that

Re: copy and paste error in rb tree code

2018-10-08 Thread Philip Guenther
On Mon, Oct 8, 2018 at 6:03 PM David Gwynne wrote: > According to https://github.com/FRRouting/frr/pull/3106, Coverity thinks > I made a copy and paste error regarding one of the augment calls in > RBT_REMOVE. I'm inclined to agree. > > The augment code is only used by uvm_map.c, and it seems to

Re: copy and paste error in rb tree code

2018-10-08 Thread Theo de Raadt
> The augment code is only used by uvm_map.c, There have been occasional problems in pmem_range below where it is used...

Re: [vi] moving by sentences is inconsistent

2018-10-08 Thread Anthony J. Bentley
Andras Farkas writes: > On Mon, Oct 8, 2018 at 11:04 AM Theo de Raadt wrote: > > You only checked the clones? You need to compare to the past. > What you're implying is right: a comment (the one with the AB CD example) in > https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/usr.bin/vi/vi/v_

copy and paste error in rb tree code

2018-10-08 Thread David Gwynne
According to https://github.com/FRRouting/frr/pull/3106, Coverity thinks I made a copy and paste error regarding one of the augment calls in RBT_REMOVE. I'm inclined to agree. The augment code is only used by uvm_map.c, and it seems to be fine with this change. I believe it coped because the augme

Re: [vi] moving by sentences is inconsistent

2018-10-08 Thread Andras Farkas
On Mon, Oct 8, 2018 at 11:04 AM Theo de Raadt wrote: > You only checked the clones? You need to compare to the past. What you're implying is right: a comment (the one with the AB CD example) in https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/usr.bin/vi/vi/v_sentence.c implies that this u

Re: locate.mklocatedb broken with LC_ALL!=C

2018-10-08 Thread Giovanni Bechis
On Sun, Oct 07, 2018 at 08:35:28PM -0600, Todd C. Miller wrote: > On Sun, 07 Oct 2018 17:08:06 +0200, Marc Espie wrote: > > > Specifically, the only part that cares about > > locale is sort, and it's definitely correct in fixing > > it's not run on an utf-8 file. > > Agreed. How about the follow

user land system spinning time

2018-10-08 Thread Alexander Bluhm
Hi, On May 14 we did split kernel spinning time from system time. Goal was to see what the kernel is doing. I just realized that user land time accounting has also changed. The commit changed system time of a process that is spinning. But the user land process still uses CPU time in the kernel

vmctl "convert": create new disk images from an input file

2018-10-08 Thread Reyk Floeter
Hi tech@, there is one more diff in our qcow2 queue which lets you convert disk images into anoter format. You create a new image from an input file: - The "standard" use case: vmctl create foo.qcow2 -i foo.raw - The other way around: vmctl create foo.raw -i foo.qcow2 - Using

Re: vmd: servicing virtio devices from separate processes

2018-10-08 Thread Mike Larkin
On Fri, Oct 05, 2018 at 01:50:10PM +0200, Sergio Lopez wrote: > Hi, > > I have an idea in mind that I'd like to share to ask you if you think > it's worth giving it a try. > > Right now, vmd already features an excellent privsep model to ensure > the process servicing the VM requests to the outsi

Re: Reuse VM ids.

2018-10-08 Thread Reyk Floeter
On Sun, Oct 07, 2018 at 07:31:45PM -0700, Ori Bernstein wrote: > Keep a list of known vms, and reuse the VM IDs. This means that when using > '-L', the IP addresses of the VMs are stable. > After you conviced me about its use case, 3 comments: 1. it has to wait until after release 2. please follo

Re: [vi] moving by sentences is inconsistent

2018-10-08 Thread Theo de Raadt
Nils Reuße wrote: > > Theo de Raadt hat am 4. Oktober 2018 um 19:35 > > geschrieben: > > > > > > Could be defacto standardized. You need to compare the past. > > > > Your finger memory has surely discovered this fairly recently. Messing > > with older people's finger memory is a very dange

Re: vmd: rate-limit to avoid reboot loops

2018-10-08 Thread Pratik Vyas
* Reyk Floeter [2018-10-05 23:32:44 +0200]: Hi, it sometimes happens that a VM is stuck in a reboot loop. This isn't very pleasent for vmd, so this diff attempts to introduce a hard rate-limit: if the VM rebooted after less than VM_START_RATE_SEC (6) seconds, increment a counter. If this hap

Re: Reuse VM ids.

2018-10-08 Thread Bob Beck
works here and I like it. but probably for after unlock On Sun, Oct 7, 2018 at 22:11 Mischa Peters wrote: > No idea if the code works yet. > Hopefully I can try later. But love the idea. > > Mischa > > > On 8 Oct 2018, at 04:31, Ori Bernstein wrote: > > > > Keep a list of known vms, and reuse

Re: pf: honor quick on anchor rules

2018-10-08 Thread Sebastian Benoit
Henning Brauer(hb-openbsdt...@ml.bsws.de) on 2018.10.08 13:56:20 +0200: > * Sebastian Benoit [2018-10-08 10:50]: > > The quick in the anchor does not do anything by itself, it should just > > "behave like all the rules inside the anchor had the quick keyword". > > no, that is *not* the intended s

Re: pf: honor quick on anchor rules

2018-10-08 Thread Henning Brauer
* Sebastian Benoit [2018-10-08 10:50]: > The quick in the anchor does not do anything by itself, it should just > "behave like all the rules inside the anchor had the quick keyword". no, that is *not* the intended semantic. the intent is that ruleset evaluation is aborted if any rule inside the a

Re: [vi] moving by sentences is inconsistent

2018-10-08 Thread Nils Reuße
> Theo de Raadt hat am 4. Oktober 2018 um 19:35 > geschrieben: > > > Could be defacto standardized. You need to compare the past. > > Your finger memory has surely discovered this fairly recently. Messing > with older people's finger memory is a very dangerous proposition. > > So go do the

Re: pf: honor quick on anchor rules

2018-10-08 Thread Sebastian Benoit
Klemens Nanni(k...@openbsd.org) on 2018.10.07 19:41:22 +0200: > On Fri, Oct 05, 2018 at 11:53:08PM +0200, Klemens Nanni wrote: > > On Fri, Oct 05, 2018 at 10:38:48PM +0200, Fabian Mueller-Knapp wrote: > > > If i read man correctly it means "evaluate the rules inside and stop if > > > any rule withi