Re: ssh: use getservbyname(3) for port numbers

Darren Tucker wrote: > On Sun, 2 Sep 2018 at 03:16, Theo de Raadt wrote: > > > > > Is there a reason ssh doesn't consult services(5) for port numbers? > > > > I think I know why but I'm not going to speak about those dark days. > > I would be fine with adding this. I am not sure what the reaso

Re: ssh: use getservbyname(3) for port numbers

On Sun, 2 Sep 2018 at 03:16, Theo de Raadt wrote: > > > Is there a reason ssh doesn't consult services(5) for port numbers? > > I think I know why but I'm not going to speak about those dark days. I would be fine with adding this. I am not sure what the reasoning behind it was (reduce NIS lookup

odd condition/test in PF lexer

Hello, a static analyzer we use for Oracle Solaris recently discovered odd if () test/condition in yylex() here sbin/pfctl/parse.y: 5279 } else if (c == '\\') { 5280 if ((next = lgetc(quotec)) == EOF) 5281 return (0); 5282

Re: Garbage-collect the __statement() macro

It is API/ABI. But I approve of removing the poison. Christian Weisgerber wrote: > The sys/arch/*/include/endian.h headers were the only place in the > whole source tree that used __statement(), and they did so to mark > statement expressions, which are a GNU extension. > > With this single co

Re: do not join node information multicast group

OK kn

Re: do not join node information multicast group

On Thu, Oct 04, 2018 at 08:13:03PM +0200, Florian Obser wrote: > Benno removed code to answer ICMP queries over 4 years ago. > Aham Brahmasmi (aham.brahmasmi AT gmx.com) points out > that we still joine the group though. > > OK? OK bluhm@ > diff --git in6.c in6.c > index c09ab1dcd0a..5297c0a1249

Re: pf: honor quick on anchor rules

I just committed the fix, thanks.

Garbage-collect the __statement() macro

The sys/arch/*/include/endian.h headers were the only place in the whole source tree that used __statement(), and they did so to mark statement expressions, which are a GNU extension. With this single consumer gone, we can garbage-collect the __statement() macro itself. I don't think this usage w

do not join node information multicast group

Benno removed code to answer ICMP queries over 4 years ago. Aham Brahmasmi (aham.brahmasmi AT gmx.com) points out that we still joine the group though. OK? diff --git in6.c in6.c index c09ab1dcd0a..5297c0a1249 100644 --- in6.c +++ in6.c @@ -808,19 +808,6 @@ in6_update_ifa(struct ifnet *ifp, struc

Re: [vi] moving by sentences is inconsistent

Could be defacto standardized. You need to compare the past. Your finger memory has surely discovered this fairly recently. Messing with older people's finger memory is a very dangerous proposition. So go do the work of discovering where there are divergences, and where/ when they occured. Nil

Re: pf: honor quick on anchor rules

Hi Klemens, > > > Do i misread the manpage somehow? > > No, this is a bug. > Allow me a bit of rubber ducking to explain this bug and ease review: > > The kernel evaluates the ruleset pretty much like we read it: Down to > bottom until quick appears or an error occurs in which case we stop > e

Re: lldb: build and install

> Date: Wed, 3 Oct 2018 15:34:44 +0200 (CEST) > From: Mark Kettenis > > > So I'd go ahead and commit tomorrow or so if there are no further > > objections. > > Building on armv7 and arm64 right now. Will take a while... Builds fine on armv7 and arm64. I can inspect core dumps on armv7, but on

patch for PPPoE peers sending MPLS config

Hi, I have a 6.3-STABLE connecting to an ISP using PPPoE. ISP replaced the router on their end with some latest MikroTik, and things stopped working. Problem appeared to be that the other end sent both an IPCP Conf.Request and an MPLSCP Conf.Request, when OpenBSD saw the MPLSCP it did not re

wdc polling lead to unclean fs and panics

Hi, when rebooting a PowerBook G4, the kernel sometimes paniced while detaching the disk. Additionallly, during boot it was noted that / is not clean. The following patch special cases polling to not return early anymore and adds polling to all previous elements in the queue. Please tell me if thi

Re: update magic file for qcow

This looks OK and is probably the easiest thing to do. Note that string/b does not have the same meaning for us because in original file some eejit decided to change "b" to "w" and then use "b" to mean something else, but I think it is harmless here. They have split this out into a "virtual" file

Re: csh: memory leak in setDolp()

BTW the leak happens when a pattern in variable modifier s/// is not found. $ set a="test" $ echo $a:s/badpattern// test Any objections if I commit this? On Thu, Sep 20, 2018 at 12:30:05PM +0800, Michael Mikonos wrote: > Hello, > > In setDolp() pointers cp and dp initially point to the same