Re: vmd: add some NULL checks after {c,m}alloc()

2018-09-13 Thread Michael Mikonos
On Thu, Sep 13, 2018 at 11:10:50PM -0700, Ori Bernstein wrote: > On Fri, 14 Sep 2018 13:50:40 +0800, Michael Mikonos wrote: > > > On Thu, Sep 13, 2018 at 10:08:16PM -0700, Ori Bernstein wrote: > > > On Thu, 13 Sep 2018 10:30:54 +0800, Michael Mikonos wrote: > > > > > I think a check for !disk->

Re: vmd: add some NULL checks after {c,m}alloc()

2018-09-13 Thread Ori Bernstein
On Fri, 14 Sep 2018 13:50:40 +0800, Michael Mikonos wrote: > On Thu, Sep 13, 2018 at 10:08:16PM -0700, Ori Bernstein wrote: > > On Thu, 13 Sep 2018 10:30:54 +0800, Michael Mikonos wrote: > > > I think a check for !disk->base belongs here as done above for disk->l1. > I think that co --- usr

Re: vmd: add some NULL checks after {c,m}alloc()

2018-09-13 Thread Michael Mikonos
On Thu, Sep 13, 2018 at 10:08:16PM -0700, Ori Bernstein wrote: > On Thu, 13 Sep 2018 10:30:54 +0800, Michael Mikonos wrote: > > > Thanks for the explanation. Overall it seems better having the > > clean-up code localised in qc2_close() so I'm happy to OK the > > patch with the close() call put ba

Re: [patch] Fix an error in chmod.1

2018-09-13 Thread Philip Guenther
On Thu, Sep 13, 2018 at 8:17 PM Nan Xiao wrote: > The following patch fixes an error in chmod.1, and very sorry if I am > wrong, thanks! > ... > --- chmod.1 7 Jun 2017 09:41:57 - 1.42 > +++ chmod.1 14 Sep 2018 05:10:44 - > @@ -243,7 +243,7 @@ If no value is supplied for >

[patch] Fix an error in chmod.1

2018-09-13 Thread Nan Xiao
Hi tech@, The following patch fixes an error in chmod.1, and very sorry if I am wrong, thanks! Index: chmod.1 === RCS file: /cvs/src/bin/chmod/chmod.1,v retrieving revision 1.42 diff -u -p -r1.42 chmod.1 --- chmod.1 7 Jun 2017 09

Re: vmd: add some NULL checks after {c,m}alloc()

2018-09-13 Thread Ori Bernstein
On Thu, 13 Sep 2018 10:30:54 +0800, Michael Mikonos wrote: > Thanks for the explanation. Overall it seems better having the > clean-up code localised in qc2_close() so I'm happy to OK the > patch with the close() call put back in (could you please forward > the updated patch to the list in case s

c++ headers with latest lib{c++,c++abi,unwind} update / out-of-sync sets

2018-09-13 Thread Sebastien Marie
Hi, I noticed the following new headers are installed: /usr/include/c++/v1/__refstring /usr/include/c++/v1/__undef___deallocate /usr/include/c++/v1/__undef_min_max but they aren't present in sets. The following diff should resync them. Thanks. -- Sebastien Marie Index: clang.amd64 =

Re: Allow building amd64/i386 kernel with lld

2018-09-13 Thread Mike Larkin
On Fri, Sep 14, 2018 at 12:25:42AM +0200, Christian Weisgerber wrote: > Currently, building an amd64 or i386 kernel with lld breaks in > makegap.sh. It turns out that we already have the missing pieces > (gapdummy) on some other archs, so we can just copy them. > > With this, I can successfully b

Allow building amd64/i386 kernel with lld

2018-09-13 Thread Christian Weisgerber
Currently, building an amd64 or i386 kernel with lld breaks in makegap.sh. It turns out that we already have the missing pieces (gapdummy) on some other archs, so we can just copy them. With this, I can successfully build and run * amd64 kernel with ld.bfd * i386 kernel with ld.bfd * amd64 kerne

Kernel build: clean up gapdummy.c

2018-09-13 Thread Christian Weisgerber
Some architectures generate a gapdummy.c file for kernel builds. Add this to the "clean" target. OK? Index: arch/arm64/conf/Makefile.arm64 === RCS file: /cvs/src/sys/arch/arm64/conf/Makefile.arm64,v retrieving revision 1.28 diff -u -

Re: pcb sip hash keys

2018-09-13 Thread Daniel Gracia
+ LIST_ENTRY(inpcb) inp_lhash;/* locol port hash */ Shouldn't this read 'local'? Regards! El jue., 13 sept. 2018 a las 23:12, Alexander Bluhm (< alexander.bl...@gmx.net>) escribió: > Hi, > > In general it is a bad idea to use one random secret for two things. > The inet PCB us

pcb sip hash keys

2018-09-13 Thread Alexander Bluhm
Hi, In general it is a bad idea to use one random secret for two things. The inet PCB uses one hash with local and foreign addresses, and one with local port numbers. Give both hashes separate keys. Also document the struct fields. ok? bluhm Index: netinet/in_pcb.c ===

Makefile.bsd-wrapper: don't use gcc for configure

2018-09-13 Thread Christian Weisgerber
There are some instances under src/gnu of Makefile.bsd-wrapper failing to pass variables like CC to a configure script. As a result, the configure tests are actually run with gcc (!) on amd64 and i386. The patch below fixes lib/libiberty usr.bin/binutils usr.bin/binutils-2.17 usr.bin/cvs

Re: mtree(8): use passwd/group caches

2018-09-13 Thread Todd C. Miller
On Thu, 13 Sep 2018 10:47:35 -0600, "Todd C. Miller" wrote: > Use the passwd/group cache functions in mtree(1) to avoid repeatedly > looking up the same user/group. The passwd and group files are > kept open too. I sent out and older version of the diff that was missing some includes in mtree.c.

Re: add uid_from_user/gid_from_group [3/3]

2018-09-13 Thread Todd C. Miller
On Mon, 10 Sep 2018 12:32:01 -0600, "Todd C. Miller" wrote: > This diff replaces calls to getpwuid/getgrgid with > uid_from_user/gid_from_group and fixes warnings caused by the > user_from_uid/group_from_gid return value change to const char *. > > I've also changed some getpwnam/getgrnam to user_

rdist: use passwd/group caches

2018-09-13 Thread Todd C. Miller
Use password/group cache functions and avoid stashing a pointer to the return value of getgrgid(3) or getgrnam(3) which relies on undefined behavior. When run as non-root, rdistd now uses the group list from getgroups(2) for group membership checks instead of looking up the group by name. This le

More user_from_uid(3) and group_from_gid(3)

2018-09-13 Thread Todd C. Miller
Use user_from_uid(3) and group_from_gid(3) in a few more places that do repeated lookups. - todd Index: sbin/fsck_ext2fs/inode.c === RCS file: /cvs/src/sbin/fsck_ext2fs/inode.c,v retrieving revision 1.27 diff -u -p -u -r1.27 inode.c

stat(1): use passwd/group caches

2018-09-13 Thread Todd C. Miller
Use user_from_uid(3) and group_from_gid(3) to avoid extra passwd and group file lookups. This required a bit of reordering of the file mode handling bits to deal with the const char *. - todd Index: usr.bin/stat/stat.c === RCS file

mtree(8): use passwd/group caches

2018-09-13 Thread Todd C. Miller
Use the passwd/group cache functions in mtree(1) to avoid repeatedly looking up the same user/group. The passwd and group files are kept open too. Index: usr.sbin/mtree/create.c === RCS file: /cvs/src/usr.sbin/mtree/create.c,v retrie

mail(1): use user_from_uid(3) and uid_from_user(3)

2018-09-13 Thread Todd C. Miller
Replace the local getname() and getuserid() functions with calls to user_from_uid(3) and uid_from_user(3). This requires sprinkling const in a few places but is otherwise mechanical. - todd Index: usr.bin/mail/Makefile === RCS file

Dereference of uninitialized TDB in IPSEC stack

2018-09-13 Thread Ricardo Mestre
Hi, There are 3 cases in IPSEC stack (both in input and output paths) where when we have a bogus mbuf (NULL), and the packet needs to be quickly dropped, we may have the TDB not initialized and we will try to dereference it to increase the drops there. Found by Coverity IDs 1473312/1473313/1473317

bgpd, introduce maxlen to specify a prefixlen

2018-09-13 Thread Claudio Jeker
ROA entires are allowing to define a prefix with a maxlen. In the end this is just another way to specify a prefixlen range and mostly an or-longer case with an upper limit. So these two prefix statements are equivalent: prefix 10.0.0.0/8 prefixlen 8 - 24 prefix 10.0.0.0/8 maxlen 24

bgpd parse.y mini-refactor

2018-09-13 Thread Claudio Jeker
Similar to as-set factor out the code to create a prefix-set into a function. Makes all a bit nicer and as an added bonus fixes a memory leak. -- :wq Claudio Index: parse.y === RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v retrieving r

bgpd, preparation work for ROA validation

2018-09-13 Thread Claudio Jeker
After prefix-set and as-set I'm looking at adding roa-set. roa-sets are kind of a mix of a prefix-set and a as-set and therefor this diff extends as-set code to allow for this. Extend as_set to allow for different sized objects to be added. The only requirement is that the first value of the struc