On Mon, Sep 10, 2018 at 01:25:24AM +0200, Alexander Bluhm wrote:
> Hi,
>
> vmd(8) may close file descriptor 0 as not all fd fields are properly
> initialized with -1. While there avoid closing -1.
>
> ok?
>
ok mlarkin
> bluhm
>
> Index: usr.sbin/vmd/vmd.c
> ==
Hello,
On Sun, Sep 09, 2018 at 10:50:08AM +0200, Alexander Bluhm wrote:
> On Sun, Sep 09, 2018 at 08:41:07AM +0200, Alexandr Nedvedicky wrote:
> > void
> > if_clone_attach(struct if_clone *ifc)
> > {
> > - rw_enter_write(&if_cloners_lock);
> > LIST_INSERT_HEAD(&if_cloners, ifc, ifc_list);
Hi,
vmd(8) may close file descriptor 0 as not all fd fields are properly
initialized with -1. While there avoid closing -1.
ok?
bluhm
Index: usr.sbin/vmd/vmd.c
===
RCS file: /data/mirror/openbsd/cvs/src/usr.sbin/vmd/vmd.c,v
retrie
Reduce duplicate code, make similar paths such as the memcpy() calls
more uniform to simplify upcoming diffs and tidy up a bit.
Feedback? OK?
Index: pfctl_parser.c
===
RCS file: /cvs/src/sbin/pfctl/pfctl_parser.c,v
retrieving revisio
On Sun, Sep 09, 2018 at 11:45:07PM +0200, Alexander Bluhm wrote:
> Hi,
>
> Like the other proc.c daemons, vmd(8) children do not detach from
> the terminal properly.
>
> ok?
>
Reads ok to me but reyk@ should approve.
> bluhm
>
> Index: src/usr.sbin/vmd/proc.c
> ===
Hi,
Like the other proc.c daemons, vmd(8) children do not detach from
the terminal properly.
ok?
bluhm
Index: src/usr.sbin/vmd/proc.c
===
RCS file: /data/mirror/openbsd/cvs/src/usr.sbin/vmd/proc.c,v
retrieving revision 1.17
diff -u
Hi,
My goal is to get in6_pcb and in_pcb in sync.
Let's make both inetctlerrmap and inet6ctlerrmap u_char. That is
what FreeBSD does. There it is also in in6?_input.c.
FreeBSD and NetBSD have the declaration in in6?_var.h, we have it
in in6?.h, but I don't bother enough to move it.
ok?
bluhm
On Sun, Sep 09, 2018 at 03:17:19AM -0700, Ayaka Koshibe wrote:
> Hi,
>
> This is a new version of a previous diff that I had for making switchd(8)
> ignore PACKET_IN messages generated from looped traffic. Currently, it will
> respond to the PACKET_IN with an invalid PACKET_OUT onto OFP*_PORT_ANY,
Hi,
This is a new version of a previous diff that I had for making switchd(8)
ignore PACKET_IN messages generated from looped traffic. Currently, it will
respond to the PACKET_IN with an invalid PACKET_OUT onto OFP*_PORT_ANY,
resulting in the switch responding with an error that makes switchd disc
Your bug report which ought to go to bugs@ is incomplete, please see
https://www.openbsd.org/report.html.
On Sat, Sep 08, 2018 at 11:35:47PM -0700, Jungle Boogie wrote:
> The backtrace is pretty uneventful, there's no debugging:
/usr/bin/smtp lacks debug symbols. Rebuild from source:
$ cd
On Sun, Sep 09, 2018 at 10:50:08AM +0200, Alexander Bluhm wrote:
> Could you put comment here, that the function is only called during
> boot so no lock is needed? I would prefer an assert to enforce
> that, but I don't know any that is suited.
>
> With comment, OK bluhm@
OK kn
On Sun, Sep 09, 2018 at 08:41:07AM +0200, Alexandr Nedvedicky wrote:
> void
> if_clone_attach(struct if_clone *ifc)
> {
> - rw_enter_write(&if_cloners_lock);
> LIST_INSERT_HEAD(&if_cloners, ifc, ifc_list);
> if_cloners_count++;
> - rw_exit_write(&if_cloners_lock);
> -}
Could
On Sun, Sep 09, 2018 at 08:41:07AM +0200, Alexandr Nedvedicky wrote:
> Hello,
>
> while poking around 'XXXSMP' comments in net/if.c, I've noticed
> the 'if_cloners_lock' can be removed. The thing is the list of
> cloners gets populated/modified at system boot only, while kernel
> attaches device d
13 matches
Mail list logo
