kcov: trace threads

2018-08-22 Thread Anton Lindqvist
Hi. Currently kcov is enabled on a per process (pid) basis. A process with multiple threads therefore share the same coverage buffer which leads to non-deterministic results. Instead, kcov should be enabled on a per thread basis; just like how kcov behaves on Linux and FreeBSD. The decision to trac

Re: Using shift on external keyboards in softraid passphrases from efiboot

2018-08-22 Thread YASUOKA Masahiko
On Mon, 20 Aug 2018 13:50:13 +0200 Theo Buehler wrote: > On Thu, Aug 16, 2018 at 09:51:32PM +0200, Frank Groeneveld wrote: >> I haven't been able to type the passphrase of my softraid device on >> boot when using an external keyboard on my Thinkpad X260. Finally I >> had some time to debug this pr

openssl s_time: check for SSL_write failure

2018-08-22 Thread Scott Cheloha
Check for failure. Also reuse retval for the buffer length in lieu of strlen. ok? Index: s_time.c === RCS file: /cvs/src/usr.bin/openssl/s_time.c,v retrieving revision 1.29 diff -u -p -r1.29 s_time.c --- s_time.c22 Aug 2018 20:3

Re: vmd/vmctl: allow to boot cdrom-only VMs

2018-08-22 Thread Carlos Cardenas
On Wed, Aug 22, 2018 at 08:35:23PM +0200, Reyk Floeter wrote: > Hi, > > vmctl doesn't allow to boot VMs with only a CDROM. I see no reason > for it and vmd already allows CDROM-only. > > OK? ok ccardenas

Re: vmd/vmctl: allow to boot cdrom-only VMs

2018-08-22 Thread Klemens Nanni
On Wed, Aug 22, 2018 at 08:35:23PM +0200, Reyk Floeter wrote: > vmctl doesn't allow to boot VMs with only a CDROM. I see no reason > for it and vmd already allows CDROM-only. I don't see a reason not to support this - wanted to test boot some linux CD myself already but failed without disk. OK kn

Re: vmd/vmctl: allow to boot cdrom-only VMs

2018-08-22 Thread Mike Larkin
On Wed, Aug 22, 2018 at 08:35:23PM +0200, Reyk Floeter wrote: > Hi, > > vmctl doesn't allow to boot VMs with only a CDROM. I see no reason > for it and vmd already allows CDROM-only. > > OK? No objection, ok mlarkin. -ml > > Via https://twitter.com/wizardishungry/status/1032327323125727232 >

re-enable -Wshadow for openssl(1)?

2018-08-22 Thread Theo Buehler
The -Wshadow warning was briefly enabled, but it turned out to break vax builds with gcc3. Among other things, this warning helps catching stupid mistakes in refactoring early, so I was wondering whether we could re-enable it. The commit that disabled it also mentions gcc3, so I'm unsure whether lu

vmd/vmctl: allow to boot cdrom-only VMs

2018-08-22 Thread Reyk Floeter
Hi, vmctl doesn't allow to boot VMs with only a CDROM. I see no reason for it and vmd already allows CDROM-only. OK? Via https://twitter.com/wizardishungry/status/1032327323125727232 "Jon Williams @wizardishungry @reykfloeter Could you consider allowing booting ISO-only vms in 6.4? This is help

Re: lo(4) automatic ::1 setting and multiple loopbacks

2018-08-22 Thread Martin Pieuchot
On 09/08/18(Thu) 22:14, Stuart Henderson wrote: > While looking into something unrelated I found a strange extra ::1 > address on lo1 (I usually hang my loopback addresses for IBGP off lo1). > > lo1: flags=8049 mtu 32768 > index 12 priority 0 llprio 3 > groups: lo > inet xx

Re: vmctl: add unveil

2018-08-22 Thread Theo de Raadt
This is not actually using unveil for security. Only for some subset of safety. Why? Well, the unveil is not locked in. Another unveil is possible. Even unveil("/", "rwxc") to deactive the unveil. There is a pledge which locks the unveil in some code paths, but not in all code paths. So this

Re: vmctl: add unveil

2018-08-22 Thread Reyk Floeter
On Tue, Aug 21, 2018 at 09:51:52PM -0700, Carlos Cardenas wrote: > Patch to unveil vmctl. > > Comments/OK? > OK reyk btw. paths[0] is an artifact from the old pledge paths argument. semarie@ removed it in -r1.13 of main.c but we both overlooked that paths[2] is not needed anymore and could just