Re: [PATCH] Pluggable disk formats for vmd (qcow2 preparation)

2018-08-21 Thread Carlos Cardenas
On Sun, Aug 19, 2018 at 11:46:12PM -0700, Ori Bernstein wrote: > One more minor update to this patch: > > - Remove unused enum > - Remove unused function prototype > - Move some qcow2-specific headers into the qcow2 patch. Ori, it's nice seeing good progress on this. I have a c

Re: vmctl: add unveil

2018-08-21 Thread Mike Larkin
On Tue, Aug 21, 2018 at 09:51:52PM -0700, Carlos Cardenas wrote: > Patch to unveil vmctl. > > Comments/OK? > > +--+ > Carlos reads ok to me > Index: main.c > === > RCS file: /home/los/cvs/src/usr.sbin/vmctl/main.c,v > retrieving re

vmctl: add unveil

2018-08-21 Thread Carlos Cardenas
Patch to unveil vmctl. Comments/OK? +--+ Carlos Index: main.c === RCS file: /home/los/cvs/src/usr.sbin/vmctl/main.c,v retrieving revision 1.39 diff -u -p -r1.39 main.c --- main.c 12 Jul 2018 14:53:37 - 1.39 +++ main.c

Re: ospfd: prevent additional ospfd from starting

2018-08-21 Thread Remi Locherer
On Tue, Aug 21, 2018 at 05:54:18PM +0100, Stuart Henderson wrote: > On 2018/08/21 17:16, Remi Locherer wrote: > > Hi tech, > > > > recently we had a short outage in our network. A script started an > > additional > > ospfd instance because the -n flag for config test was missing. > > This is a p

Allocate PCI BAR for radeondrm(4)

2018-08-21 Thread Mark Kettenis
If firmware doesn't initialize the device, the BAR will be zero and mapping that address leads to "interesting" issues on many machines. This BAR is a bit special since we don't want to immediately map it. So we have to explicitly allocate the address space for the BAR. Bail out if we fail. Don't

Re: ospfd: prevent additional ospfd from starting

2018-08-21 Thread Denis Fondras
On Tue, Aug 21, 2018 at 05:16:47PM +0200, Remi Locherer wrote: > Hi tech, > > recently we had a short outage in our network. A script started an additional > ospfd instance because the -n flag for config test was missing. > > What then happend was not nice: > - The new ospfd unlinked the control

Re: rasops(9) cursor drawing code

2018-08-21 Thread Mark Kettenis
> Date: Mon, 20 Aug 2018 20:55:16 +0200 (CEST) > From: Mark Kettenis > > > Date: Mon, 20 Aug 2018 15:46:57 +0200 > > From: Frederic Cambus > > > > There is an issue when moving the cursor backwards with the left arrow > > key, characters disappear and only reappear when moving back forward > >

Re: ospfd: prevent additional ospfd from starting

2018-08-21 Thread Stuart Henderson
On 2018/08/21 17:16, Remi Locherer wrote: > Hi tech, > > recently we had a short outage in our network. A script started an additional > ospfd instance because the -n flag for config test was missing. This is a problem with bgpd as well, last time I did this it killed one of the *other* routers o

openssl s_time: use monotonic timer for test timeout

2018-08-21 Thread Scott Cheloha
The timeout should be based on a monotonic clock. The wrapper function for the app_timer_* interfaces obfuscates things, so delete it. totalTimer should be set, not added to: the code doesn't increment it every iteration. ok? P.S. huh, there's an FPE if nConn == 0. Index: s_time.c

Re: [patch] uvm_mmap / little change proposal

2018-08-21 Thread David CARLIER
I knew it was not documented for a reason but why is it ? Just curious ... but it s ok if we drop this change ... On Tue, 21 Aug 2018 at 16:38, Mark Kettenis wrote: > > > From: "Todd C. Miller" > > Date: Tue, 21 Aug 2018 09:19:05 -0600 > > > > On Tue, 21 Aug 2018 08:57:06 +0100, David CARLIER wro

Re: [patch] uvm_mmap / little change proposal

2018-08-21 Thread Mark Kettenis
> From: "Todd C. Miller" > Date: Tue, 21 Aug 2018 09:19:05 -0600 > > On Tue, 21 Aug 2018 08:57:06 +0100, David CARLIER wrote: > > > For portability sake and to make it more "visible" I changed the > > __MAP_NOREPLACE to MAP_EXCL, documented it in the man page and also > > changed the errno to EE

Re: [patch] uvm_mmap / little change proposal

2018-08-21 Thread David CARLIER
No one else .. Linux has MAP_FIXED_NOREPLACE which is MAP_FIXED|MAP_EXCL equivalent... On Tue, 21 Aug 2018 at 16:19, Todd C. Miller wrote: > > On Tue, 21 Aug 2018 08:57:06 +0100, David CARLIER wrote: > > > For portability sake and to make it more "visible" I changed the > > __MAP_NOREPLACE to MAP_

Re: [patch] uvm_mmap / little change proposal

2018-08-21 Thread Todd C. Miller
On Tue, 21 Aug 2018 08:57:06 +0100, David CARLIER wrote: > For portability sake and to make it more "visible" I changed the > __MAP_NOREPLACE to MAP_EXCL, documented it in the man page and also > changed the errno to EEXIST instead (I thought it would reflect > better the error in case the address

ospfd: prevent additional ospfd from starting

2018-08-21 Thread Remi Locherer
Hi tech, recently we had a short outage in our network. A script started an additional ospfd instance because the -n flag for config test was missing. What then happend was not nice: - The new ospfd unlinked the control socket of the first ospfd - The new ospfd removed all routes from the first o

Re: IP_SENDSRCADDR cmsg_len and dnsmasq

2018-08-21 Thread Alexander Bluhm
On Mon, Jul 16, 2018 at 11:11:58AM +0200, Vincent Gross wrote: > I have a regression test for this based on Alexander Markert code + > rework by mpi@, do you want me to commit it right now ? Finally I have commited the fix. Could you take care of the regression test? bluhm

[patch] uvm_mmap / little change proposal

2018-08-21 Thread David CARLIER
Hi, For portability sake and to make it more "visible" I changed the __MAP_NOREPLACE to MAP_EXCL, documented it in the man page and also changed the errno to EEXIST instead (I thought it would reflect better the error in case the addressed mapped already exists but can be changed back in case ...)