On Sun, 12 Aug 2018 22:51:24 -0700, Ori Bernstein wrote:
>
This patch adds preliminary support for creating qcow2 disk images. It gives
the 'vmctl create' command an option '-f', which can be given arguments of
either 'raw' (defualt) or 'qcow2', and it creates a disk of the appropriate
format.
On Sun, 12 Aug 2018 22:51:24 -0700, Ori Bernstein wrote:
> On Sun, 5 Aug 2018 00:52:32 -0700, Ori Bernstein wrote:
>
> And, now something that actually appears to work. You can create a
> disk on OpenBSD using qemu:
>
> qemu-img create foo.qc2 16G
>
> add it to your vm.conf:
>
>
One more minor update to this patch:
- Remove unused enum
- Remove unused function prototype
- Move some qcow2-specific headers into the qcow2 patch.
---
usr.sbin/vmd/Makefile | 2 +-
usr.sbin/vmd/vioraw.c | 73 ++
usr.sb
> Date: Mon, 20 Aug 2018 11:43:31 +1000
> From: Jonathan Gray
>
> On Sun, Aug 19, 2018 at 07:38:44PM +0200, Mark Kettenis wrote:
> > If memory is supposed to be cached, we should make it so. Matches
> > what the Linux version of this code does.
> >
> > ok?
>
> Sure, I had something similiar in
Sorry, I made a mistake in review here:
On Sun, Aug 19, 2018 at 11:26:22PM -0500, Scott Cheloha wrote:
> On Sun, Aug 19, 2018 at 09:40:43AM +0100, Ricardo Mestre wrote:
> >
> > [...]
> > @@ -446,7 +451,8 @@ ac(FILE *fp)
> > */
> > if (*usr.ut_name) {
> >
On Sun, Aug 19, 2018 at 09:40:43AM +0100, Ricardo Mestre wrote:
>
> With your suggestion now it doesn't segfault anymore, but it still outputs
> crazy stuff, do we really want this? Also -p still shows contents of the file
> as per below:
>
> 0 serial@skoll:/usr/src/usr.sbin/ac$ obj/ac -w ./ac.c
Mark Kettenis wrote:
>I have to think through the consequences of simply doing a delay
>without checking the condition here though.
Right now __wait_event_intr_timeout has a KASSERT(!cold), so, if its code
is changed to have an "if (cold) { delay(tick); ret = 1; }" then we know
that this new code
On Sun, Aug 19, 2018 at 07:38:44PM +0200, Mark Kettenis wrote:
> If memory is supposed to be cached, we should make it so. Matches
> what the Linux version of this code does.
>
> ok?
Sure, I had something similiar in a tree here.
Could you keep the comment in the original code as well?
Index: t
Hi,
At BSDCan, someone reported that a sparc64 machine would panic if it was
receiving any traffic on a member interface of a switch(4) during reboot. We
got as far as getting this trace:
panic: trap type 0x34 (mem address not aligned): pc=15864ec
npc=15864f0 pstate=99820006
Stopped at db_en
If memory is supposed to be cached, we should make it so. Matches
what the Linux version of this code does.
ok?
Index: dev/pci/drm/ttm/ttm_bo_util.c
===
RCS file: /cvs/src/sys/dev/pci/drm/ttm/ttm_bo_util.c,v
retrieving revision 1.1
> Date: Sun, 19 Aug 2018 13:08:15 -0400
> From: Philippe Meunier
>
> Philippe Meunier wrote:
> >Yes, the delay is okay. The problem is that when "cold" is 1, the vblank
> >counter never changes during a call to drm_wait_one_vblank, so the
> >condition inside __wait_event_intr_timeout is never tr
On Sunday 19 August 2018 08:44:24 Theo Buehler wrote:
> Coverity complains about the case where EVP_Digest() fails, but there
> are a couple more.
One thing worth mentioning... previously it would return -1 without setting an
error, whereas now it will always set RSA_R_OAEP_DECODING_ERROR (even
OK @inoguchi
2018/08/19 22:44 "Theo Buehler" :
> On Sun, Aug 19, 2018 at 09:53:32PM +0900, Kinichiro Inoguchi wrote:
> > I feel that "error case free" should be done in do_accept() rather than
> caller.
> > After strdup(), there are 2 "return (0)".
> > How about adding "free(*host)" before these 2
On Sun, Aug 19, 2018 at 09:53:32PM +0900, Kinichiro Inoguchi wrote:
> I feel that "error case free" should be done in do_accept() rather than
> caller.
> After strdup(), there are 2 "return (0)".
> How about adding "free(*host)" before these 2 "return (0)" ?
You're right, that makes more sense.
I feel that "error case free" should be done in do_accept() rather than caller.
After strdup(), there are 2 "return (0)".
How about adding "free(*host)" before these 2 "return (0)" ?
I worried that error return occurs before strdup() in do_accept().
On Sun, Aug 19, 2018 at 10:40:55AM +0200, Theo B
It looks good to me.
OK inoguchi@
On Sun, Aug 19, 2018 at 08:44:24AM +0200, Theo Buehler wrote:
> Coverity complains about the case where EVP_Digest() fails, but there
> are a couple more.
>
> Index: rsa/rsa_oaep.c
> ===
> RCS file:
Hi,
With your suggestion now it doesn't segfault anymore, but it still outputs
crazy stuff, do we really want this? Also -p still shows contents of the file
as per below:
0 serial@skoll:/usr/src/usr.sbin/ac$ obj/ac -w ./ac.c
total762774013172614.25
0 serial@skoll:/usr/
do_accept() may strdup() the host name and store it in `name', so we
need to free it before exiting. Perhaps a refactor might be more
appropriate, but I'm not sure I want to touch this mess.
Index: s_socket.c
===
RCS file: /var/cvs/sr
At this point sktmp may be allocated by sk_dup(), so we need to free it.
Remove a free guard at the end while there.
Index: x509/x509_vfy.c
===
RCS file: /var/cvs/src/lib/libcrypto/x509/x509_vfy.c,v
retrieving revision 1.70
diff -u -p
19 matches
Mail list logo
