CVE-2018-3615, CVE-2018-3620, CVE-2018-3646

2018-08-14 Thread Theo de Raadt
These 3 issues all relate to a bug in Intel cpus The cpu will speculatively honour invalid PTE against data in the on-core L1 cache. Memory disclosure occurs into the wrong context. These 3 issues (CVE-2018-3615, CVE-2018-3620, CVE-2018-3646) together are the currently public artifacts of this o

Re: inteldrm(4) regression from 6.1 to 6.2: wrong console resolution

2018-08-14 Thread Philippe Meunier
Philippe Meunier wrote: >Mark Kettenis wrote: >>Does the diff below fix things? > >Yes, it fixes the console resolution problem, although a bunch of "vblank >wait timed out on crtc 0" messages now show up (see dmesg's output below). How about the patch below? It does essentially the same thing as

Re: umsm(4) and umb(4) separate loading for the same composite USB modem device

2018-08-14 Thread Theo de Raadt
Bryan Vyhmeister wrote: > On Tue, Aug 14, 2018 at 05:53:43PM +0300, Denis wrote: > > Most of modern modems have serial discipline ports and USB Mobile > > Broadband Interface Model (MBIM) interface in some port compositions > > simultaneously. It seems very useful to have different disciplines >

Re: umsm(4) and umb(4) separate loading for the same composite USB modem device

2018-08-14 Thread Bryan Vyhmeister
On Tue, Aug 14, 2018 at 05:53:43PM +0300, Denis wrote: > Most of modern modems have serial discipline ports and USB Mobile > Broadband Interface Model (MBIM) interface in some port compositions > simultaneously. It seems very useful to have different disciplines > supported by umsm(4) and umb(4) dr

Re: soplice.9: Fix struct sosplice usage

2018-08-14 Thread Alexander Bluhm
On Tue, Aug 14, 2018 at 10:19:16PM +0200, Klemens Nanni wrote: > Feedback? OK? OK bluhm@ > Index: sosplice.9 > === > RCS file: /cvs/src/share/man/man9/sosplice.9,v > retrieving revision 1.8 > diff -u -p -r1.8 sosplice.9 > --- sosplic

soplice.9: Fix struct sosplice usage

2018-08-14 Thread Klemens Nanni
sys/sys/socketvar.h changed with revision 1.57 date: 2014/11/03 17:20:46; author: bluhm; state: Exp; lines: +16 -9; commitid: Jo3b0hfgHpuqTRST; Put the socket splicing fields into a seperate struct sosplice that gets only allocated when needed. This way struct

Re: md5: convert from fgetln(3) to getline(3)

2018-08-14 Thread Scott Cheloha
This patch is ok cheloha@ and I can commit if someone else is ok, too. On Tue, Aug 14, 2018 at 10:47:07PM +0300, Lauri Tirkkonen wrote: > [...] > > diff --git a/bin/md5/md5.c b/bin/md5/md5.c > index 84adbcf0989..1abf28cfa16 100644 > --- a/bin/md5/md5.c > +++ b/bin/md5/md5.c > @@ -549,11 +549,11 @

Re: md5: convert from fgetln(3) to getline(3)

2018-08-14 Thread Lauri Tirkkonen
On Tue, Aug 14 2018 14:29:30 -0500, Scott Cheloha wrote: > On Tue, Aug 14, 2018 at 08:55:14PM +0300, Lauri Tirkkonen wrote: > > Hi, > > > > On Tue, Aug 14 2018 12:08:54 -0500, Scott Cheloha wrote: > > > > + len = (size_t)linelen; > > > > + if (line[len - 1] == '\n') > >

Re: md5: convert from fgetln(3) to getline(3)

2018-08-14 Thread Scott Cheloha
On Tue, Aug 14, 2018 at 08:55:14PM +0300, Lauri Tirkkonen wrote: > Hi, > > On Tue, Aug 14 2018 12:08:54 -0500, Scott Cheloha wrote: > > > + len = (size_t)linelen; > > > + if (line[len - 1] == '\n') > > > + line[len - 1] = '\0'; > > > > You can just use linelen dire

Re: md5: convert from fgetln(3) to getline(3)

2018-08-14 Thread Lauri Tirkkonen
Hi, On Tue, Aug 14 2018 12:08:54 -0500, Scott Cheloha wrote: > > + len = (size_t)linelen; > > + if (line[len - 1] == '\n') > > + line[len - 1] = '\0'; > > You can just use linelen directly and skip the assignment. I did it this way because this bit later

Re: reduce pledge(2) on rdate(8)

2018-08-14 Thread Ricardo Mestre
please disregard, this is bogus... note to self since I seem to keep forgetting this, on programs that fiddle with the time and where we can override the timezone by setting TZ if we do it to a path not whitelisted by pledge then rpath is needed unconditionlly since libc internally will try to ope

Re: md5: convert from fgetln(3) to getline(3)

2018-08-14 Thread Scott Cheloha
On Tue, Aug 14, 2018 at 03:34:53PM +0300, Lauri Tirkkonen wrote: > Similar to previous diffs for join(1) and paste(1). No intended > functional change. I agree with the direction. Comments inline. > diff --git a/bin/md5/md5.c b/bin/md5/md5.c > index 84adbcf0989..a8f18262a92 100644 > --- a/bin/md

nologin(8): unveil(2)

2018-08-14 Thread Scott Cheloha
nologin(8) caught my eye for a different reason, but before doing anything else we ought to unveil(2) it. ok? -- Scott Cheloha Index: sbin/nologin/nologin.c === RCS file: /cvs/src/sbin/nologin/nologin.c,v retrieving revision 1.6 dif

umsm(4) and umb(4) separate loading for the same composite USB modem device

2018-08-14 Thread Denis
Hello there, Most of modern modems have serial discipline ports and USB Mobile Broadband Interface Model (MBIM) interface in some port compositions simultaneously. It seems very useful to have different disciplines supported by umsm(4) and umb(4) drivers on the same device. For instance, Sierra W

Re: inteldrm(4) regression from 6.1 to 6.2: wrong console resolution

2018-08-14 Thread Philippe Meunier
Mark Kettenis wrote: >Does the diff below fix things? Yes, it fixes the console resolution problem, although a bunch of "vblank wait timed out on crtc 0" messages now show up (see dmesg's output below). Philippe OpenBSD 6.4-beta (GENERIC) #5: Tue Aug 14 22:20:08 CST 2018 r...@usb.my.domain

Re: [patch] consistent verb form in nc.1

2018-08-14 Thread Jason McIntyre
On Tue, Aug 14, 2018 at 06:23:54PM +0800, Nan Xiao wrote: > Hi tech@, > > This patch uses consistent verb form ("specifies") in nc.1, thanks! > > Index: nc.1 > === > RCS file: /cvs/src/usr.bin/nc/nc.1,v > retrieving revision 1.88 > d

Re: inteldrm(4) regression from 6.1 to 6.2: wrong console resolution

2018-08-14 Thread Mark Kettenis
Hi Philippe, Please do send technical discussions to tech@ in the future; misc@ is there to attract the trolls and many of us aren't subscribed to it adn only read it through the mailing list archive ;). Anyway, regarding: https://marc.info/?l=openbsd-misc&m=153424694308657 Thank for the detailed

md5: convert from fgetln(3) to getline(3)

2018-08-14 Thread Lauri Tirkkonen
Similar to previous diffs for join(1) and paste(1). No intended functional change. diff --git a/bin/md5/md5.c b/bin/md5/md5.c index 84adbcf0989..a8f18262a92 100644 --- a/bin/md5/md5.c +++ b/bin/md5/md5.c @@ -549,11 +549,11 @@ digest_filelist(const char *file, struct hash_function *defhash, int se

Re: Add /usr/include/c++ to hier.7

2018-08-14 Thread Jason McIntyre
On Tue, Aug 14, 2018 at 01:57:17PM +0200, Frederic Cambus wrote: > Hi tech@, > > Here is a diff to add /usr/include/c++ in hier.7. > > Comments? OK? > > Index: share/man/man7/hier.7 > === > RCS file: /cvs/src/share/man/man7/hier.7,v

[patch] consistent verb form in nc.1

2018-08-14 Thread Nan Xiao
Hi tech@, This patch uses consistent verb form ("specifies") in nc.1, thanks! Index: nc.1 === RCS file: /cvs/src/usr.bin/nc/nc.1,v retrieving revision 1.88 diff -u -p -r1.88 nc.1 --- nc.128 Nov 2017 16:59:10 - 1.88 +

Add /usr/include/c++ to hier.7

2018-08-14 Thread Frederic Cambus
Hi tech@, Here is a diff to add /usr/include/c++ in hier.7. Comments? OK? Index: share/man/man7/hier.7 === RCS file: /cvs/src/share/man/man7/hier.7,v retrieving revision 1.160 diff -u -p -r1.160 hier.7 --- share/man/man7/hier.7

reduce pledge(2) on rdate(8)

2018-08-14 Thread Ricardo Mestre
Hi, Once the pipe(2) is opened between the parent and child rpath/wpath is not needed in order for communication, nevertheless we cannot drop wpath since we may need O_WRONLY to write on /var/log/wtmp through logwtmp(3) a little bit later. In this case we can drop the first pledge(2) to "stdio wpa

Harmonize spacing after ellipses in install.sub

2018-08-14 Thread Frederic Cambus
Hi tech@, We are using spacing after ellipses in displayed messages in an inconsistant way. A few examples: - openssl: generating isakmpd/iked RSA keys... done. - syncing disks... done - iwm0: no link . got link - iwm0: no lease .. got lease Another example, from syspatch: - Relinking