Re: Fwd: [patch] ifconfig.c

On 08/10/18 03:09, Sebastian Benoit wrote: i know about the tab in ieee80211_listnodes() but your diffs are unreadable, please fix that. sorry about that. I blame thunderbird. Index: ifconfig.c === RCS file: /cvs/src/sbin/ifco

Re: LACP Administrative Knobs

On Fri, Aug 10, 2018 at 11:36:01AM +0200, Remi Locherer wrote: > On 2018-08-09 03:53, Carlos Cardenas wrote: > > On Mon, Aug 06, 2018 at 08:18:23PM -0700, Carlos Cardenas wrote: > > > Howdy. > > > > > > Attached is a patch from my work that started at g2k18 on adding > > > administrative knobs to

umsm(4) Sierra Wireless MC7304 mini PCIe modem card recognition patch

--- usbdevs.origFri Aug 10 16:23:00 2018 +++ usbdevs Fri Aug 10 16:24:03 2018 @@ -3858,6 +3858,7 @@ product SIERRA MC8355 0x9013 MC8355 product SIERRA AIRCARD_340U0x9051 Aircard 340U product SIERRA AIRCARD_770S0x9053 Aircard 770S +product SIERRA MC7304 0x

Re: avoid overflow in snmp message id

On 2018/08/10 10:26, Rob Pierce wrote: > Prevent server side (snmpd) overflow for message id in the snmp header. > > ok? Matches RFC3412 6.2, OK sthen@ > Index: snmpclient.c > === > RCS file: /cvs/src/usr.sbin/snmpctl/snmpclient.c,

avoid overflow in snmp message id

Prevent server side (snmpd) overflow for message id in the snmp header. ok? Index: snmpclient.c === RCS file: /cvs/src/usr.sbin/snmpctl/snmpclient.c,v retrieving revision 1.16 diff -u -p -r1.16 snmpclient.c --- snmpclient.c8

unveil(2) kdump(1)

Hi, kdump(1) only needs access to tracefile which by default is ktrace.out unless argument -f is used. We can just unveil(2) that file with read permissions. I tried it with all possible arguments just to make sure nothing breaks. Comments? OK? Index: kdump.c ===

unveil(2) biff(1)

Hi, Just like in mesg(1) in biff(1) we just need to push down pledge a little bit to get the tty name. After this we can unveil the tty with rw access in order to stat(2)/chmod(2) it, once this is done we can put back the same pledge(2) just right afterwards. OK? Index: biff.c ==

Re: correct exit values when unveil/pledge do not succeed on mesg(1)

On Fri, Aug 10, 2018 at 11:01:02AM +0100, Ricardo Mestre wrote: > This one was my fault, mesg(1) should only return 1 when we disallow > messages. When we want to exit if an error has occurred it must be >1 > instead. Additionally the err(3) for the pledge case must be changed. OK kn

correct exit values when unveil/pledge do not succeed on mesg(1)

Hi, This one was my fault, mesg(1) should only return 1 when we disallow messages. When we want to exit if an error has occurred it must be >1 instead. Additionally the err(3) for the pledge case must be changed. OK? Index: mesg.c =

Re: LACP Administrative Knobs

On 2018-08-09 03:53, Carlos Cardenas wrote: On Mon, Aug 06, 2018 at 08:18:23PM -0700, Carlos Cardenas wrote: Howdy. Attached is a patch from my work that started at g2k18 on adding administrative knobs to our LACP driver. The driver now has a new ioctl (SIOCxTRUNKOPTS), which for now only has

Re: pfctl: use mask parameter and zap bits in host_v4()

On Thu, Aug 09, 2018 at 12:01:41PM +0200, Klemens Nanni wrote: > On Wed, Aug 01, 2018 at 01:27:48AM +0200, Klemens Nanni wrote: > > Updated diff bringing this function in line with its counterparts by > > using `mask' the same way. > > > > If a mask was specified, `mask' would always equal to `bit

Re: Fwd: [patch] ifconfig.c

i know about the tab in ieee80211_listnodes() but your diffs are unreadable, please fix that. Edgar Pettijohn III(ed...@pettijohn-web.com) on 2018.08.09 20:34:37 -0500: > Unfortunantly it wasn't that easy. This version doesn't segfault with > bad input :) Also just noticed there is a bunch of st