LACP Administrative Knobs

2018-08-06 Thread Carlos Cardenas
Howdy. Attached is a patch from my work that started at g2k18 on adding administrative knobs to our LACP driver. The driver now has a new ioctl (SIOCxTRUNKOPTS), which for now only has options for LACP: * Mode - Active or Passive (default Active) * Timeout - Fast or Slow (default Slow) * System P

Pass more EFI related information from bootloader to kernel

2018-08-06 Thread Mark Kettenis
I suspect that at some point in the future we'll have to bite the bullet and call into EFI runtime services on amd64 as well. The diff below paves the road by passing the necessary information from our bootloader to the kernel. There is a potential issue with this diff. The EFI memory map is sto

Re: Floating point exception on boot after using syspatch(8)

2018-08-06 Thread Zbyszek Żółkiewski
and we have errata: https://ftp.openbsd.org/pub/OpenBSD/patches/6.3/common/016_fpuinit.patch.sig I confirm AMI now works as expected Thank you for great work! _ Zbyszek Żółkiewski > Wiadomość napisana przez Zbyszek Żółkiewski w dniu > 06.08.2018, o godz. 11:54: > >> On Thu, 2 Aug 2018,Mike E

Re: ifconfig join: show list of configured ess ids

2018-08-06 Thread Todd T. Fries
Always consider ramdisk builds after adding code to ifconfig not inside SMALL. Thanks, Penned by Sebastian Benoit on 20180804 14:12.27, we have: | Hi, | | with this diff, | | ifconfig join | | will print the list of networks that are configured for autojoin. | | $ ifconfig iwm0 join | iwm

fix 11n interop with Aruba 105 APs

2018-08-06 Thread Stefan Sperling
Aruba 105 APs announce a mandatory Rx MCS set in association responses. Specifically, they claim to require that all clients support MCS 0-31. This seems very wrong, and I believe it's a bug in this brand of APs. Because our Intel drivers only do MCS 0-16, and the AP tells us that we're required t

Re: refactor ieee80211_match_ess() / ieee80211_set_ess()

2018-08-06 Thread Florian Obser
please ignore On Mon, Aug 06, 2018 at 04:22:28PM +0200, Florian Obser wrote: > > Refactor ieee80211_match_ess() and ieee80211_set_ess(): > nwids are binary data with an explicit length, so treat them as such > instead of treating them like strings with a fixed len of > IEEE80211_NWID_LEN. > > To

Re: refactor ieee80211_del_ess()

2018-08-06 Thread Florian Obser
please ignore On Mon, Aug 06, 2018 at 03:18:59PM +0200, Florian Obser wrote: > > Inspired by stsp's recent ieee80211_add_ess commit. > > Refactor ieee80211_del_ess(): > nwids are binary data with an explicit length, so treat them as such > instead of treating them like strings with a fixed len o

Re: relayd: remove lognotify

2018-08-06 Thread Florian Obser
On Mon, Aug 06, 2018 at 03:46:48PM +0200, Sebastian Benoit wrote: > > RELAYD_OPT_LOGNOTIFY seems to do nothing. > > ok? > > (benno_remove_lognotify.diff) > > diff --git usr.sbin/relayd/hce.c usr.sbin/relayd/hce.c > index e4b50292d69..7f0d70ba0e7 100644 > --- usr.sbin/relayd/hce.c > +++ usr.sbin

refactor ieee80211_match_ess() / ieee80211_set_ess()

2018-08-06 Thread Florian Obser
Refactor ieee80211_match_ess() and ieee80211_set_ess(): nwids are binary data with an explicit length, so treat them as such instead of treating them like strings with a fixed len of IEEE80211_NWID_LEN. To avoid two searches in a row ieee80211_set_ess() accepts a struct ieee80211_ess which ieee8

Re: Unlock pipe(2) and pipe2(2)

2018-08-06 Thread Martin Pieuchot
On 02/08/18(Thu) 13:06, Martin Pieuchot wrote: > On 01/08/18(Wed) 01:53, Mark Kettenis wrote: > > > Date: Tue, 31 Jul 2018 14:55:45 -0300 > > > From: Martin Pieuchot > > > > > > On 26/06/18(Tue) 12:31, Martin Pieuchot wrote: > > > > These syscalls do two operations: they allocate FDs and some buf

NXP PCF8574(A) I/O port expander driver

2018-08-06 Thread Johannes Krottmayer
Hello, I have written a driver for the I2C device PCF8574(A) from NXP and I have tested the driver (with gpioctl) on a PINE64 ROCK64 board and a small test circuit. The driver works. I hope you can need the driver. Index: sys/dev/i2c/files.i2c

Re: Check lo(4) rdomain before attempting to move it to another

2018-08-06 Thread Claudio Jeker
On Mon, Aug 06, 2018 at 03:37:38PM +0200, Sebastian Benoit wrote: > Ayaka Koshibe(akosh...@openbsd.org) on 2018.08.05 17:43:34 -0700: > > Hi, > > > > I noticed that if you try to move an immovable lo(4) to a nonexistent > > rdomain, > > a new routing table will be created despite the operation fa

Re: relayd: remove lognotify

2018-08-06 Thread Claudio
On Mon, Aug 06, 2018 at 03:46:48PM +0200, Sebastian Benoit wrote: > > RELAYD_OPT_LOGNOTIFY seems to do nothing. > > ok? If you're also removing RELAYD_OPT_LOGALL after that than OK claudio@ > (benno_remove_lognotify.diff) > > diff --git usr.sbin/relayd/hce.c usr.sbin/relayd/hce.c > index e4b5

relayd: remove lognotify

2018-08-06 Thread Sebastian Benoit
RELAYD_OPT_LOGNOTIFY seems to do nothing. ok? (benno_remove_lognotify.diff) diff --git usr.sbin/relayd/hce.c usr.sbin/relayd/hce.c index e4b50292d69..7f0d70ba0e7 100644 --- usr.sbin/relayd/hce.c +++ usr.sbin/relayd/hce.c @@ -197,7 +197,7 @@ hce_notify_done(struct host *host, enum host_error he

Re: Check lo(4) rdomain before attempting to move it to another

2018-08-06 Thread Sebastian Benoit
Ayaka Koshibe(akosh...@openbsd.org) on 2018.08.05 17:43:34 -0700: > Hi, > > I noticed that if you try to move an immovable lo(4) to a nonexistent rdomain, > a new routing table will be created despite the operation failing with an > EPERM. > yes, i dont think it should do that > The following mo

refactor ieee80211_del_ess()

2018-08-06 Thread Florian Obser
Inspired by stsp's recent ieee80211_add_ess commit. Refactor ieee80211_del_ess(): nwids are binary data with an explicit length, so treat them as such instead of treating them like strings with a fixed len of IEEE80211_NWID_LEN. This recycles the ``all'' parameter and calls it len. If len == 0

Re: correction on /etc/examples/ldpd.conf

2018-08-06 Thread Claudio Jeker
On Mon, Aug 06, 2018 at 11:45:37AM +0100, Ricardo Mestre wrote: > Sure, even better, but we also need to change ldpd.conf(5) which shows > exactly the same bad behaviour. Maybe something like this, which I've > borrowed lightly from bgpd? Sure OK claudio@ > Index: etc/examples/ldpd.conf > ==

Re: ifconfig join: show list of configured ess ids

2018-08-06 Thread Florian Obser
On Mon, Aug 06, 2018 at 12:05:30PM +0200, Stefan Sperling wrote: > On Mon, Aug 06, 2018 at 11:42:51AM +0200, Florian Obser wrote: > > I don't understand why we have a limit on the join list. > > The ioctl interface is easier to deal with if the max size is known in > advance. The recalloc dance in

Re: correction on /etc/examples/ldpd.conf

2018-08-06 Thread Ricardo Mestre
Sure, even better, but we also need to change ldpd.conf(5) which shows exactly the same bad behaviour. Maybe something like this, which I've borrowed lightly from bgpd? Index: etc/examples/ldpd.conf === RCS file: /cvs/src/etc/examples

refactor ieee80211_add_ess()

2018-08-06 Thread Stefan Sperling
No functional change. Drop ieee80211_add_ess's nwid parameter. Read nwid and length from the ic. The intention is to make it more obvious what the current implementation is doing. Our long-term goal should be to pass essid/essid-length/crypto params in one pass but the current WPA ioctl interface

Re: ifconfig join: show list of configured ess ids

2018-08-06 Thread Stefan Sperling
On Mon, Aug 06, 2018 at 11:42:51AM +0200, Florian Obser wrote: > I don't understand why we have a limit on the join list. The ioctl interface is easier to deal with if the max size is known in advance. The recalloc dance in benno's diff isn't actually necessary (nevermind that it's still enforcing

Re: correction on /etc/examples/ldpd.conf

2018-08-06 Thread Claudio Jeker
On Mon, Aug 06, 2018 at 09:26:46AM +0100, Ricardo Mestre wrote: > Hi, > > The example file for ldpd(8) is using the reserved word "password" so we get > this nice error below, and it's also mentioned in the manpage that we > shouldn't > use reserved words such as "password" for macros. > > skoll

proposal: possible autoconf/automake tweaks in ports framework

2018-08-06 Thread Marc Espie
This comes from an idea from sthen@ One issue is that ports running autoconf/autoreconf and friends never quite know whether to do it in post-patch or pre-configure. post-patch: + done once during patch phase - if it fails for whatever reason, you have to do a full clean - if you need to tweak it

Re: Floating point exception on boot after using syspatch(8)

2018-08-06 Thread Zbyszek Żółkiewski
On Wed, 1 Aug 2018, Philip Guenther wrote: >> This smells like some compatibility issue with the eager-FPU change. One >> thought is whether the Xen presents the guest with a correctly reset FPU >> state on all CPUs, or if there's some odd state that we're not clearing. >> >> I made a later commit

Re: ifconfig join: show list of configured ess ids

2018-08-06 Thread Florian Obser
On Mon, Aug 06, 2018 at 11:31:27AM +0200, Stefan Sperling wrote: > On Sat, Aug 04, 2018 at 09:12:27PM +0200, Sebastian Benoit wrote: > > Hi, > > > > with this diff, > > > > ifconfig join > > > > will print the list of networks that are configured for autojoin. > > > > $ ifconfig iwm0 join >

Re: ifconfig join: show list of configured ess ids

2018-08-06 Thread Stefan Sperling
On Sat, Aug 04, 2018 at 09:12:27PM +0200, Sebastian Benoit wrote: > Hi, > > with this diff, > > ifconfig join > > will print the list of networks that are configured for autojoin. > > $ ifconfig iwm0 join > iwm0: flags=208843 mtu 1500 > lladdr a4:7f:da:a4:d7:c1 > index 1 pri

Re: do not set nwid over and over again

2018-08-06 Thread Stefan Sperling
On Sun, Aug 05, 2018 at 06:35:05PM +0200, Florian Obser wrote: > we just found the ess by comparing the nwid. It will not have > magically changed behind our back. > > OK? OK By the way, this function has other small problems: 1) It assumes that len(nwid) == ic->ic_des_esslen which is only t

Re: smtpd: improve message parser

2018-08-06 Thread Gilles Chehade
On Thu, Jul 26, 2018 at 09:08:02PM +0200, Eric Faurot wrote: > Hi, > > The message parser was introduced for different reasons, when it > turned out that altering the incoming message was actually needed. > It is used to add required "Date" and "Message-ID" headers if missing, > to append the loca

Re: Nuke PLEDGE_STAT for further pledge/unveil disentaglement.

2018-08-06 Thread Sebastien Marie
On Sun, Aug 05, 2018 at 12:01:09PM -0600, Bob Beck wrote: > So this gets rid of unveil's PLEDGE_STAT. > > Instead we use UNVEIL_INSPECT which is set by the stat and access opeerations > that are needed for realpath() type traversals that effectively call > stat/access > for each component of a pa

correction on /etc/examples/ldpd.conf

2018-08-06 Thread Ricardo Mestre
Hi, The example file for ldpd(8) is using the reserved word "password" so we get this nice error below, and it's also mentioned in the manpage that we shouldn't use reserved words such as "password" for macros. skoll$ doas ldpd -dv -f /etc/examples/ldpd.conf /etc/examples/ldpd.conf:4: syntax erro