Re: [PATCH] find(1) man page, source comment: assumed -print

2018-07-31 Thread Theo Buehler
On Wed, Aug 01, 2018 at 07:19:13AM +0100, Jason McIntyre wrote: > On Mon, Jul 30, 2018 at 05:19:40PM -0500, Kris Katterjohn wrote: > > Hey, > > > > A statement in the find(1) man page and a source comment in find.c are > > outdated and incorrect. > > > > The man page didn't mention that using -de

Re: [PATCH] find(1) man page, source comment: assumed -print

2018-07-31 Thread Jason McIntyre
On Mon, Jul 30, 2018 at 05:19:40PM -0500, Kris Katterjohn wrote: > Hey, > > A statement in the find(1) man page and a source comment in find.c are > outdated and incorrect. > > The man page didn't mention that using -delete or -execdir prevents > -print from being assumed. > > Similarly for a co

Re: [PATCH] find(1) man page: -exec evaluation

2018-07-31 Thread Jason McIntyre
On Mon, Jul 30, 2018 at 02:27:54PM -0500, Kris Katterjohn wrote: > Hey, > > The man page for find(1) does not mention when the -exec primary > evaluates to true. > > -exec utility ... ; evaluates to true when the utility exits with a > zero exit status, while -exec utility ... {} + always evaluat

Re: Unlock pipe(2) and pipe2(2)

2018-07-31 Thread Mark Kettenis
> Date: Tue, 31 Jul 2018 14:55:45 -0300 > From: Martin Pieuchot > > On 26/06/18(Tue) 12:31, Martin Pieuchot wrote: > > These syscalls do two operations: they allocate FDs and some buffers. > > Thanks to the work done for sockets the file-related bits are now > > mp-safe, so we can push the KERNEL

Re: pfctl: use mask parameter and zap bits in host_v4()

2018-07-31 Thread Klemens Nanni
On Mon, Jul 23, 2018 at 11:51:33AM +0200, Klemens Nanni wrote: > Coming from the only caller `host()', the `mask' parameter is -1 iff > `*s' does not contain "/". > > Let's not discard that information and avoid the redundant search; this > makes the `mask' parameter actually being used. Updated d

Re: [PATCH] jot(1): negative and overflowing reps

2018-07-31 Thread Kris Katterjohn
On Wed, Aug 01, 2018 at 12:24:59AM +0200, Theo Buehler wrote: > ok tb if anyone wants to commit. Cool, thanks for looking at this. > > + errx(1, "Bad reps value, %s: %s", errstr, > > A single blank space after the colon would be enough. I agree. I only used two space

Re: [PATCH] jot(1): negative and overflowing reps

2018-07-31 Thread Theo Buehler
> I have a patch below to use strtonum instead of sscanf when converting > reps (like the way a precision value is converted and checked). Since > reps is a long, bound it by 0 and LONG_MAX. Makes sense. ok tb if anyone wants to commit. > + errx(1, "Bad reps value, %

ntpd: make host_*() AF agnostic

2018-07-31 Thread Klemens Nanni
This diff merges `host_v4()' and `host_v6()' into the much simpler `host_addr()'. Instead of calling inet_pton() and getaddrinfo() while using AF specific structs for IPv4 and IPv6 respectively, use getaddrinfo() for both in combination with `struct sockaddr_storage'. `host_dns()' can adapt the s

[PATCH] jot(1): negative and overflowing reps

2018-07-31 Thread Kris Katterjohn
Hey, Currently jot(1) allows reps to be negative and also allows reps to overflow (in some cases) without being caught. $ uname -ms OpenBSD i386 $ jot -n -- -1 $ jot -n 2147483648 $ jot 4294967297 1 $ In the negative case, nothing is printed (except for a newline if -n is not given). FreeBSD's

Re: Newer unveil diffs

2018-07-31 Thread Pratik Vyas
* Theo de Raadt [2018-07-30 12:52:46 -0600]: unveil(2) is now enabled in -current. For those who want to play along at home, here are some diffs which use this in a variety of programs. Not all these diffs are correct or complete yet. This is a learning experience. Based upon what we learn,

Re: Unlock pipe(2) and pipe2(2)

2018-07-31 Thread Martin Pieuchot
On 26/06/18(Tue) 12:31, Martin Pieuchot wrote: > These syscalls do two operations: they allocate FDs and some buffers. > Thanks to the work done for sockets the file-related bits are now > mp-safe, so we can push the KERNEL_LOCK() down. > > Diff below adds some KERNEL_LOCK/UNLOCK() dances around k

bgpd: sofreconfig in reshuffle

2018-07-31 Thread Claudio Jeker
Instead of walking the Adj-RIB-In per RIB walk it once and check per prefix if the RIB needs an update or not. This will make it easier to make this run without blocking the system for a long time. OK? -- :wq Claudio Index: rde.c ==

Re: Newer unveil diffs

2018-07-31 Thread Theo Buehler
I ran into this change of behavior in doas(1). Not sure if it's intentional or a bug: > Index: usr.bin/doas/doas.c [...] > + if (unveilcommands(safepath, cmd) == 0) Previously, a doas.conf such as permit tb as root would allow me to run an arbitrary command in my $PATH as root by do

Re: ssdfb(4): SSD1309 OLED display (128x64)

2018-07-31 Thread Mark Kettenis
> Date: Fri, 27 Jul 2018 17:10:32 +0200 > From: Patrick Wildt > > Hi, > > I have an SPI-connected SSD1309 OLED display (128x64) that I would like > to support. At some point I'd like to attach a graphical program to it, > so that a userland tool can draw graphics (or maybe something like X11).

ssdfb(4): mmap(2) support for X11

2018-07-31 Thread Patrick Wildt
Hi, this adds mmap(2) support for ssdfb(4), so we can map the framebuffer from userland and have X11 or another graphical program write into it. ok? Patrick diff --git a/sys/dev/fdt/ssdfb.c b/sys/dev/fdt/ssdfb.c index e91762a0ad2..8f141608c91 100644 --- a/sys/dev/fdt/ssdfb.c +++ b/sys/dev/fdt/s

Re: relocate some public ber functions

2018-07-31 Thread Claudio Jeker
On Mon, Jul 30, 2018 at 04:39:39PM -0400, Rob Pierce wrote: > Some public ber functions sneaked in below the internal functions comment. > Move > them up so the comment regains its former truthiness. > > Ok? OK claudio@ > Index: usr.bin/ldap/ber.c >

httpd rewrite support and REQUEST_URI

2018-07-31 Thread Tim Baumgard
I was testing the new rewrite support in httpd in conjunction with the "fastcgi" option and noticed that the REQUEST_URI CGI variable is set to the rewritten path and query string instead of the requested URI and query string. The patch below mimics what happens with http_descriptor->http_path_alia

Re: unveil: incomplete unveil_flagmatch semantic

2018-07-31 Thread Sebastien Marie
On Mon, Jul 30, 2018 at 12:00:59PM -0600, Theo de Raadt wrote: > + for (i=0; flags[i].pledge != 0; i++) > + if (ISSET(pledge_flags, flags[i].pledge)) { > + SET(permissions, flags[i].unveil); > + CLR(pledge_flags, flags[i].pledge); > +

uaudioctl() shadow variable 'error'

2018-07-31 Thread Michael W. Bombardieri
Hello, The function usbioctl() has an error variable and two more which are declared in nested blocks, i.e. switch cases for USB_REQUEST and USB_DEVICE_GET_FDESC. The following patch to remove the nested declarations builds cleanly, and if I'm following things correctly the function works the same

bgpd: make announced networks more like regular prefixes

2018-07-31 Thread Claudio Jeker
This brings the network code more in line with what regular update processing does. It adds the prefix to Adj-RIB-In and if "log update" is set it will also log the addition and removal of a prefix. To make the output of log update nicer I pimped peerself and also initialize the remote address to t