Re: paste(1): use getline instead of fgetln

On Tue, Jul 17 2018 21:14:29 +0300, Lauri Tirkkonen wrote: > In the same vein as my previous diff for join(1), make paste(1) use > getline instead of fgetln. ping. the join(1) fix was committed but this one still needs attention. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: systat.1 bar graph - add lockspin "@"

On Mon, Jul 23, 2018 at 11:29:03AM +0200, Alexander Bluhm wrote: > On Mon, Jul 23, 2018 at 10:07:03AM +0200, Marcus MERIGHI wrote: > > I've noticed that systat(1), in the CPU bar graph, shows "@"s, which > > aren't explained in systat(1). I went looking and found: > > This commit is more relevant

Re: Kill MD-specific interrupt enable/disable API on amd64

On Tue, Jul 24, 2018 at 1:02 PM Mark Kettenis wrote: > Diff below switches to the MI equivalent and kills the MD-specific > API. > > ok? > ok guenther@

tracking down sources of spin cpu%

My workstation is freezing up a lot again (usually in 30-60ish second bursts with no or very slow response to mouse or keyboard or screen updates). I have a status bar (xstatbar) that displays a graph of the last minute or so's cpu% split off into user/nice/system/spin/interrupt/idle. It skips a l

Kill MD-specific interrupt enable/disable API on amd64

Diff below switches to the MI equivalent and kills the MD-specific API. ok? Index: arch/amd64/amd64/amd64_mem.c === RCS file: /cvs/src/sys/arch/amd64/amd64/amd64_mem.c,v retrieving revision 1.13 diff -u -p -r1.13 amd64_mem.c --- arc

Re: pcidevs Sandisk or WD

> Date: Tue, 24 Jul 2018 13:29:52 -0700 > From: Bryan Vyhmeister > > Do we want the WD Black NVMe identified or should we just leave it out? > Also, if you want the SSD to not be identified, should at least the > vendor be added? Thanks again. Committed, Thanks > Index: sys/dev/pci/pcidevs > ==

Re: pcidevs Sandisk or WD

Do we want the WD Black NVMe identified or should we just leave it out? Also, if you want the SSD to not be identified, should at least the vendor be added? Thanks again. Bryan Index: sys/dev/pci/pcidevs === RCS file: /cvs/src/sys/d

dd(1): plug operand leak

Hi, In jcl() since args.c v1.3 we strdup every string in argv before parsing it so that w(1) shows an accurate command invocation. But after parsing we only need to keep these string copies for the input and output file paths. Everything else is effectively leaked. So, strdup the paths for the

Re: inteldrm: always use probed screen size for fb

On Mon, Jul 23, 2018 at 01:28:40PM -0500, joshua stein wrote: > On the 2015 MacBook Pro and the 12" MacBook, the firmware reports a > framebuffer size of 2880x1800 but the screens are 2560x1600 and > 2304x1440. Our console ends up drawing text off screen and the > latest few lines can't be read

Re: Setting MTU in slaacd (1/4)

Florian Obser wrote: > I think this is the right place to put this. > > (The diff is missing context, this is the wroute pledge). > > dhclient(8) is also using this ioctl so one step closer to pledge > the dhclient priv process, too. > > this is OK florian@ but you will need an ok from deraadt

Re: Setting MTU in slaacd (1/4)

I think this is the right place to put this. (The diff is missing context, this is the wroute pledge). dhclient(8) is also using this ioctl so one step closer to pledge the dhclient priv process, too. this is OK florian@ but you will need an ok from deraadt, too! On Tue, Jul 24, 2018 at 08:28:4

Re: Setting MTU in slaacd (2/4)

On Tue, Jul 24, 2018 at 08:29:30PM +0200, Björn Ketelaars wrote: > Assuming that the pledge bits are in, the diff below enables setting of > MTU on the interface by slaacd. > > If a MTU is advertised it is checked that it is at least 1280 bytes. If > not MTU is set to 1280. If no MTU is advertised

Setting MTU in slaacd (4/4)

Assuming that the other patches have been applied this patch enables slaacctl(8) to print the set, advertised MTU. diff --git usr.sbin/slaacctl/slaacctl.c usr.sbin/slaacctl/slaacctl.c index 5b2a22f12e6..97b460aee08 100644 --- usr.sbin/slaacctl/slaacctl.c +++ usr.sbin/slaacctl/slaacctl.c @@ -228,6

Setting MTU in slaacd (3/4)

Diff below makes an advertised MTU available from slaacd(8) to slaacctl(8). diff --git sbin/slaacd/engine.c sbin/slaacd/engine.c index 762fb3af7a3..88e8b6531aa 100644 --- sbin/slaacd/engine.c +++ sbin/slaacd/engine.c @@ -887,6 +887,7 @@ send_interface_info(struct slaacd_iface *iface, pid_t pid)

Setting MTU in slaacd (2/4)

Assuming that the pledge bits are in, the diff below enables setting of MTU on the interface by slaacd. If a MTU is advertised it is checked that it is at least 1280 bytes. If not MTU is set to 1280. If no MTU is advertised nothing is done. diff --git sbin/slaacd/engine.c sbin/slaacd/engine.c in

Setting MTU in slaacd (1/4)

I recently sent a diff for enabling slaacctl(8) to show the advertised MTU [0]. florian@ commented that it is confusing that slaacctl is showing a different MTU than ifconfig, and noted that setting MTU is "perfectly simple to do it in slaacd". This is the first in a series of 4 patches, which ena

Re: ospfd: document in which cases the route prio filter is not used

On Tue, Jul 24, 2018 at 04:18:38PM +0200, Sebastian Benoit wrote: > phessler@ noticed that we dont document which redistribute settings > cause the priority filter to be enabled/disabled. > > Add this text: > > The use of redistribute prefix and redistribute rtlabel can in >

Re: rasops(9): Remove rasops4 functions?

> Date: Sun, 22 Jul 2018 15:12:09 +0200 > From: Frederic Cambus > > Hi tech@, > > Nothing uses the rasops4 (4-bit color depth) functions anymore. > > It seems unlikely that any future new platform will ever need them. > > Should we remove them? > > Comments? OK? Hmm, apparently 4-bit is quit

Re: net/bpf: +23year old gross hack within ifdef _KERNEL.

I believe what you are proposing is userland/kernel ABI break, utilizing exposure of a __packed data structure. __packed equiv is not supported by some languages, so they would be unable to parse these headers. Furthermore, it means objects after the packing are now misaligned if their alignment

ospfd: document in which cases the route prio filter is not used

phessler@ noticed that we dont document which redistribute settings cause the priority filter to be enabled/disabled. Add this text: The use of redistribute prefix and redistribute rtlabel can in some situations result in higher cpu usage because ospfd(8) ne

Re: pfctl: use strtonum in host()

On Mon, Jul 23, 2018 at 04:36:05PM -0600, Theo de Raadt wrote: > I am not sure either is right. > > The string may begin with an arbitrary amount of whitespace (as > determined by isspace(3)) followed by a single optional `+' or `-' sign. > > What about the '+' sign case? It's caught ev

bgpd, move nexthop pointer to struct prefix

After a lot of preparation diffs this does the actuall change of moving the nexthop form struct rde_aspath to struct prefix. Also the nexthop flags are moved into their own flag variable (reducing the flag masking that happened before). I tested this with most nexthop combos I can think of and all

Re: bgpd, use prefix_nexthop to access nexthop

Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.07.24 10:22:40 +0200: > This diff simply changes all the nexthop accesses from asp->nexthop to > calling prefix_nexthop() which currently does the same. This will ease > moving the nexthop into struct prefix and is part of a larger diff that > does ex

Re: pfctl: introduce print_addr_str() helper

Klemens Nanni(k...@openbsd.org) on 2018.07.23 16:52:11 +0200: > Here's a start to avoid duplicate routines that moves the inet_ntop > wiggle from four locations into a small new helper called > `print_addr_str()'. > > Feedback? OK? ok benno@ > Index: pf_print_state.c >

bgpd, use prefix_nexthop to access nexthop

This diff simply changes all the nexthop accesses from asp->nexthop to calling prefix_nexthop() which currently does the same. This will ease moving the nexthop into struct prefix and is part of a larger diff that does exactly that. OK? -- :wq Claudio Index: mrt.c ===