Re: use BN_swap_ct() instead of BN_consttime_swap() in ec_GF2m_montgomery_point_multiply()

looks good to me. ok inoguchi@ On Sat, Jul 14, 2018 at 02:46:17PM +0200, Theo Buehler wrote: > The new BN_swap_ct() API is an improved version of the public > BN_consttime_swap() function: it allows for error checking doesn't > assert() and has fewer assumptions on the input. > > This eliminates

Re: BN_swap_ct() use size_t for byte count

I checked this diff libressl portable build. ok inoguchi@ On Sat, Jul 14, 2018 at 02:30:12PM +0200, Theo Buehler wrote: > As pointed out by jsing, using size_t for nwords would be more > appropriate for the new internal API BN_swap_ct(). Let's switch to it > and cast to an int internally after ch

dd(1): don't cast malloc(3) size to u_int

Hi, tobias@ spotted this one a few months ago when reviewing a different diff of mine. Casting the size given to malloc(3) here causes it to wrap if our block sizes are large enough, and then dd(1) misbehaves, at least on 64-bit platforms: # dd bs=$(((1 << 31) + 1)) cbs=$((1 << 31)) conv=ascii i

Re: add pledge(2) to midiplay(1)

On Fri, Jul 20, 2018 at 09:12:29AM +0100, Ricardo Mestre wrote: > Hi, > > This adds pledge to midiplay, it only needs stdio rpath if reading > files, otherwise (playing the sample or from stdin) only stdio is > needed. > > OK? The diff seems correct. I can't test it right now, if you managed to

Re: Kill SS_NBIO

On Thu, Jul 12, 2018 at 06:18:06PM +0200, Martin Pieuchot wrote: > > > @@ -1157,8 +1154,7 @@ sosplice(struct socket *so, int fd, off_ > > > } > > > > > > /* Lock both receive and send buffer. */ > > > - if ((error = sblock(so, &so->so_rcv, > > > - (so->so_state & SS_NBIO) ? M_NOWAIT : M_W

Re: pcidevs Sandisk or WD

On Fri, Jul 20, 2018 at 11:09:09AM +0200, Mark Kettenis wrote: > Right. It's best if the names are unique and using > pre-merger/takeover company names typically helps with that. If that is the consensus then here is a diff. The WD Black High-performance NVMe SSDs were never marketed under SanDis

smtpd: improve internal resolver interface

Implement a generic interface to forward resolver queries to the lka process. Use it for the reverse lookups required by smtp and mta. Until now, DNS-related lookups were implemented using ad-hoc IMSGs between the lka and other processes. It turns out to be confusing and difficult to extend. So

Re: point to glob in section 7 not 3 for various base tools

On Fri, 20 Jul 2018 14:10:09 +0200, Klemens Nanni wrote: > Looking at which programs use and document globbing patterns, it seems > odd that some manuals point at glob's C API in the "Library functions" > sections instead of the list of special characters in the > "Miscellaneous information" secti

Re: call for testing: rad(8) - a rtadvd(8) replacement

On Fri, Jul 20, 2018 at 03:40:07PM +0200, Björn Ketelaars wrote: > New diff, which addresses all your comments except the "no mtu" bit in > the parser as I do not understand what you mean. Never mind then :) I was thinking about something like this: 8< mtu 1480 interface ix0 # gets mtu 1

Re: call for testing: rad(8) - a rtadvd(8) replacement

On Fri 20/07/2018 07:57, Florian Obser wrote: > On Thu, Jul 19, 2018 at 09:47:06PM +0200, Björn Ketelaars wrote: > > On Wed 18/07/2018 08:54, Florian Obser wrote: > > > During g2k18 I commited rad(8). > > > > > > The latest amd64 and i386 snapshots should contain it with enough > > > features to r

Re: Replace getprogname() to argv[0] in bnaddsub

Currently, argv[0] is used in regression tests and command line tools only, and it is not in libraries. But, I'll try to think of that. Thanks. On Fri, Jul 20, 2018 at 05:56:07AM -0600, Theo de Raadt wrote: > Disagree with this. argv[0] could be a long path, which could info > disclose directory

Re: point to glob in section 7 not 3 for various base tools

Jason McIntyre wrote: > On Fri, Jul 20, 2018 at 02:10:09PM +0200, Klemens Nanni wrote: > > Looking at which programs use and document globbing patterns, it seems > > odd that some manuals point at glob's C API in the "Library functions" > > sections instead of the list of special characters in th

Re: point to glob in section 7 not 3 for various base tools

On Fri, Jul 20, 2018 at 02:10:09PM +0200, Klemens Nanni wrote: > Looking at which programs use and document globbing patterns, it seems > odd that some manuals point at glob's C API in the "Library functions" > sections instead of the list of special characters in the > "Miscellaneous information"

Re: [patch] make(1) remove unused tutorial

Jason McIntyre wrote: > On Thu, Jul 19, 2018 at 09:02:07PM +0300, Leonid Bobrov wrote: > > Index: PSD.doc/Makefile > > === > > evening. > > all the PSD/USD/... docs in src that remain have been previously > vouched for by other dev

point to glob in section 7 not 3 for various base tools

Looking at which programs use and document globbing patterns, it seems odd that some manuals point at glob's C API in the "Library functions" sections instead of the list of special characters in the "Miscellaneous information" section actual patterns are described. Diff below adjusts pax(1), tar(

Re: fix compilation failure when sr_debug is defined.

I am very unhappy to see use of #undef It doesn't feel like the right approach. Karel Gardas wrote: > > > Hello, > > following small patch fixes compilation failure when SR_DEBUG is defined in > softraidvar.h which results in definition of DPRINTF which results in error > about already de

Re: Replace getprogname() to argv[0] in bnaddsub

Let me see if I understand what you think: Windows lacks the *BSD extension getprogname(), but it surely must have the older *BSD extension __progname That about sum it up? Thanks... Gleydson Soares wrote: > On Tue, Jul 17, 2018 at 10:09:37PM +0900, Kinichiro Inoguchi wrote: > > To run regres

Re: Replace getprogname() to argv[0] in bnaddsub

Disagree with this. argv[0] could be a long path, which could info disclose directory hierarchy into a context that bounces stderr to the wrong place. Instead, the Windows compat should have a have a getprogname() stub which does the right thing. Kinichiro Inoguchi wrote: > To run regress bnad

spamd.conf.5: document https

Hi, spamd.conf supports method=https, but this is not documented. So document it and also modify the example config to default to it. diff --git a/etc/mail/spamd.conf b/etc/mail/spamd.conf index b080300d952..1361e864742 100644 --- a/etc/mail/spamd.conf +++ b/etc/mail/spamd.conf @@ -27,7 +27,7 @@

Re: pcidevs Sandisk or WD

> Date: Thu, 19 Jul 2018 18:36:18 +0100 > From: Stuart Henderson > > On 2018/07/19 10:00, Bryan Vyhmeister wrote: > > I am wanting to add the WD Black High-performance NVMe SSD PCI > > IDs to pcidevs and I am not sure how to proceed. WD bought Sandisk a > > while back but the vendor ID is 15b7 wh

Re: add pledge(2) to midiplay(1)

From: Ricardo Mestre Index: midiplay.c === RCS file: /cvs/src/usr.bin/midiplay/midiplay.c,v retrieving revision 1.19 diff -u -p -u -r1.19 midiplay.c --- midiplay.c 24 Apr 2017

add pledge(2) to midiplay(1)

Hi, This adds pledge to midiplay, it only needs stdio rpath if reading files, otherwise (playing the sample or from stdin) only stdio is needed. OK? Index: midiplay.c === RCS file: /cvs/src/usr.bin/midiplay/midiplay.c,v retrieving r