Re: pthread_create: fix segfault when attr is NULL

2018-07-06 Thread Anthony J. Bentley
Ingo Schwarze writes: > Hi Jason, > > Jason McIntyre wrote on Sat, Jul 07, 2018 at 07:17:29AM +0100: > > > the 2/3 pages should really reference the most recent standards too. > > it's just the work hasn;t been done. > > According to my understanding, the difference in policy is deliberate. > Some

Re: pthread_create: fix segfault when attr is NULL

2018-07-06 Thread Jason McIntyre
On Sat, Jul 07, 2018 at 08:25:07AM +0200, Ingo Schwarze wrote: > Hi Jason, > > Jason McIntyre wrote on Sat, Jul 07, 2018 at 07:17:29AM +0100: > > > the 2/3 pages should really reference the most recent standards too. > > it's just the work hasn;t been done. > > According to my understanding, the

systat(1) iostat vs. iostat(1)

2018-07-06 Thread Marcus MERIGHI
Hello, when I run 'iostat(1) sd1 1' I get the transfer speed in MB/s. Running 'systat(1) iostat 1' in parallel I get the transfer speed in bytes, as calculations show. Therefore adjust the manual of systat(1): kilobytes -> bytes. Marcus Index: systat.1 =

Re: pthread_create: fix segfault when attr is NULL

2018-07-06 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Sat, Jul 07, 2018 at 07:17:29AM +0100: > the 2/3 pages should really reference the most recent standards too. > it's just the work hasn;t been done. According to my understanding, the difference in policy is deliberate. Some people may want to write C code accor

Re: pthread_create: fix segfault when attr is NULL

2018-07-06 Thread Jason McIntyre
On Sat, Jul 07, 2018 at 07:42:44AM +0200, Ingo Schwarze wrote: > Hi, > > Scott Cheloha wrote on Fri, Jul 06, 2018 at 07:31:36PM -0500: > > On Fri, Jul 06, 2018 at 03:07:12PM +0200, Mark Kettenis wrote: > >> Paul Irofti wrote on Fri, 6 Jul 2018 15:36:07 +0300: > >>> somebody wrote: > > POSIX

Re: pthread_create: fix segfault when attr is NULL

2018-07-06 Thread Ingo Schwarze
Hi, Scott Cheloha wrote on Fri, Jul 06, 2018 at 07:31:36PM -0500: > On Fri, Jul 06, 2018 at 03:07:12PM +0200, Mark Kettenis wrote: >> Paul Irofti wrote on Fri, 6 Jul 2018 15:36:07 +0300: >>> somebody wrote: POSIX currently says: The behavior is undefined if the value specified b

Re: pthread_create: fix segfault when attr is NULL

2018-07-06 Thread Scott Cheloha
On Fri, Jul 06, 2018 at 03:07:12PM +0200, Mark Kettenis wrote: > > Date: Fri, 6 Jul 2018 15:36:07 +0300 > > From: Paul Irofti > > > > > POSIX currently says: > > > > > > The behavior is undefined if the value specified by the attr > > > argument to pthread_create() does not refer to an initi

Re: uaudio: fix detection of a bunch of logitech webcams

2018-07-06 Thread Remco
@@ -1814,6 +1827,10 @@ sc->sc_audio_rev = UGETW(acdp->bcdADC); DPRINTFN(2,("%s: found AC header, vers=%03x, len=%d\n", __func__, sc->sc_audio_rev, aclen)); + + /* Some webcams descriptors advertise an off-by-one wTotalLength */ + if (sc->sc_quirks & UAU

Re: pthread_create: fix segfault when attr is NULL

2018-07-06 Thread Mark Kettenis
> Date: Fri, 6 Jul 2018 15:36:07 +0300 > From: Paul Irofti > > > POSIX currently says: > > > > The behavior is undefined if the value specified by the attr > > argument to pthread_create() does not refer to an initialized thread > > attributes object. > > I don't see that bit: > > http:/

Re: uaudio: fix detection of a bunch of logitech webcams

2018-07-06 Thread Landry Breuil
On Fri, Jul 06, 2018 at 01:52:57PM +0200, Landry Breuil wrote: > On Thu, Jul 05, 2018 at 11:13:42AM +0200, Landry Breuil wrote: > > On Thu, Jul 05, 2018 at 11:04:34AM +0200, Martin Pieuchot wrote: > > > On 05/07/18(Thu) 09:28, Landry Breuil wrote: > > > > On Fri, Jun 29, 2018 at 01:50:24PM +0200, L

Re: pthread_create: fix segfault when attr is NULL

2018-07-06 Thread Paul Irofti
> POSIX currently says: > > The behavior is undefined if the value specified by the attr > argument to pthread_create() does not refer to an initialized thread > attributes object. I don't see that bit: http://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_create.html On the co

Re: pthread_create: fix segfault when attr is NULL

2018-07-06 Thread Mark Kettenis
> Date: Fri, 6 Jul 2018 15:05:56 +0300 > From: Paul Irofti > > Hi, > > The current implementation does not check for NULL attr values and > segfaults when creating new threads if that's the case: > > Program received signal SIGSEGV, Segmentation fault. > 0x0a77e9550ade in pthread_create (th

pthread_create: fix segfault when attr is NULL

2018-07-06 Thread Paul Irofti
Hi, The current implementation does not check for NULL attr values and segfaults when creating new threads if that's the case: Program received signal SIGSEGV, Segmentation fault. 0x0a77e9550ade in pthread_create (threadp=0x7f7e5488, attr=0x7f7e5480, start_routine=0xa7539a00600

Re: uaudio: fix detection of a bunch of logitech webcams

2018-07-06 Thread Landry Breuil
On Thu, Jul 05, 2018 at 11:13:42AM +0200, Landry Breuil wrote: > On Thu, Jul 05, 2018 at 11:04:34AM +0200, Martin Pieuchot wrote: > > On 05/07/18(Thu) 09:28, Landry Breuil wrote: > > > On Fri, Jun 29, 2018 at 01:50:24PM +0200, Landry Breuil wrote: > > > > On Fri, Jun 29, 2018 at 09:05:56AM +0200, R

add logitech c250

2018-07-06 Thread Landry Breuil
Hi, thx to Raf Czlonka who sent me the usb descriptor for this model, it's also affected by the 'wrong feature_unit bLength' issue so should be added to usbdevs too. okay ? I'll of course add it to the other uaudio diff.. Index: usbdevs ===

Re: slaacd, can we use AF_INET6 to restrict route messages?

2018-07-06 Thread Claudio Jeker
On Fri, Jul 06, 2018 at 12:20:18PM +0100, Stuart Henderson wrote: > Already heard from.Florian - I'm travelling to fix a router today but > this is what I plan to commit after I'm back and have gained confidence > in it :) > > More changes may make sense but this seems a useful initial change. OK

Re: slaacd, can we use AF_INET6 to restrict route messages?

2018-07-06 Thread Stuart Henderson
Already heard from.Florian - I'm travelling to fix a router today but this is what I plan to commit after I'm back and have gained confidence in it :) More changes may make sense but this seems a useful initial change. Index: slaacd.c ==

Re: slaacd, can we use AF_INET6 to restrict route messages?

2018-07-06 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.07.06 07:44:43 +0200: > On Thu, Jul 05, 2018 at 10:51:24PM +0100, Stuart Henderson wrote: > > I noticed relatively high cpu use from slaacd on a BGP router > > that was undergoing some route churn earlier (no interfaces were > > actually configured to

[PATCH] Add OPENSSL_NO_EC2M around calls to EC_GROUP_get_curve_GF2m in ecparam.c

2018-07-06 Thread Richard Clarke
Hi tech@ When compiling ecparam with OPENSSL_NO_EC2M defined, it fails to link as the appropriate #ifndef are not placed around the call to EC_GROUP_get_curve_GF2m. The included patch fixes this. Best Regards, Richard Clarke (@rsclarke) Index: ecparam.c =